Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Feb 26 22:18
    johnMinelli edited #1797
  • Feb 26 22:04
    johnMinelli review_requested #1797
  • Feb 26 22:04
    johnMinelli review_requested #1797
  • Feb 26 22:04
    johnMinelli opened #1797
  • Feb 26 19:07

    calohmn on master

    Handle failures in resolveGroup… (compare)

  • Feb 26 19:07
    calohmn closed #1792
  • Feb 26 19:07
    soheilade commented #1780
  • Feb 26 18:15
    boaks opened #1796
  • Feb 26 15:39
    sophokles73 commented #1780
  • Feb 26 15:02
    soheilade commented #1780
  • Feb 26 14:16
    ctron commented #1793
  • Feb 26 13:25

    sophokles73 on master

    [#1780] Fix AKS setup guide Ad… (compare)

  • Feb 26 13:22
    sophokles73 milestoned #1780
  • Feb 26 13:21
    sophokles73 labeled #1780
  • Feb 26 13:21
    sophokles73 labeled #1780
  • Feb 26 13:21
    sophokles73 commented #1780
  • Feb 26 13:15

    sophokles73 on 1.1.x

    [#1780] Fix AKS setup guide Fi… [#1780] Fix AKS setup guide Ad… (compare)

  • Feb 26 12:37

    sophokles73 on master

    [#1780] Fix AKS setup guide Fi… (compare)

  • Feb 26 12:11

    sophokles73 on master

    Fix http/lora/sigfox metrics S… Improve concept pages Added di… (compare)

  • Feb 26 11:28
    calohmn commented #1793
Dejan Bosanac
@dejanb
@calohmn nothing from my side
Kai Hudalla
@sophokles73
@all I am currently looking at our build process and have been wondering if anybody of you has ever considered any of the code coverage data generated by the JaCoCo maven plugin.
Dejan Bosanac
@dejanb
@sophokles73 I don't find it too useful tbh
Kai Hudalla
@sophokles73
Neither do I. In fact, I have never even bothered to even take a look at the result on codecov, not the least because it requires me to register for yet another system ...
Carsten Lohmann
@calohmn
I haven't gotten useful information from the codecov check results in the PRs yet. The results are usually very confusing and sometimes checks fail although they shouldn't.
See #1536 for example - no code changes here at all and still the 'codecov/project' check has failed and some coverage changes are found (why?).
Maybe the integration test results make the coverage results too varied because the tests behave a bit different each time.
So, I would rather have the checks removed or maybe just the integration test results can be removed to make results more reliable.
johnMinelli
@johnMinelli
the credential registration for client works in the same way as for the devices? i'm not able to connect a consumer using notdefault credential in plain conn (default is consumer@HONO:verysecret)
johnMinelli
@johnMinelli
another thing: a chat for the support would be nice, to not over-disturb you devs. (or shuld i use git to let my problem be on records for others?)
Kai Hudalla
@sophokles73
@johnMinelli in general, and if the answer to the question would be helpful to others as well, you should post questions on stackoverflow using the eclipse-hono tag
johnMinelli
@johnMinelli
oks, can you answer me on the auth problem?
Kai Hudalla
@sophokles73
@johnMinelli downstream applications that use Hono's north bound APIs to consume data and send commands connect to the AMQP Messaging Network, not to the protocol adapters. Thus, applications are authenticated by the AMQP Messaging Network. If you are using the example deployment that comes with Hono, then the Qpid Dispatch Router (which is part of the AMQP Messaging Network implementation) delegates to the Auth Server component for authenticating applications. In order to add another user you need to edit the eclipse-hono/example/example-permissions.json. At the bottom of that file is the definition of the consumer@HONO user which you can use as a template. After you have made the changes you need to redeploy Hono for the change to take effect ...
@all I would like to do the 1.1.0-M2 today. Any specific pending PRs that you need to be included?
Dejan Bosanac
@dejanb
@sophokles73 go for it ... nothing from my side
Kai Hudalla
@sophokles73
@all I am now starting the 1.1.0-M2 release build ...
Karthees Kalidass
@kaniyan
:+1:
johnMinelli
@johnMinelli
@sophokles73 i was aware of the first part of your message, but thanks a lot to point that out. I'll try to modify the json file as you said.
Kai Hudalla
@sophokles73
@all So far, nobody seems to care about the coverage stats gathered by JaCoCo. So I suggest to remove it from our build process altogether. Any objections?
Kai Hudalla
@sophokles73
@all GitHub has started to automatically create pull requests for our dependencies which it believes to be subject to vulnerabilities: #1715
Personally, I think that this could be useful as an early warning system and would therefore tend to let GitHub continue doing it. WDYT?
Kai Hudalla
@sophokles73
@ctron @dejanb @calohmn any opinion regarding these two issues?
Carsten Lohmann
@calohmn
@sophokles73 yes, the dependency update PRs look useful, cool feature
Jens Reimann
@ctron
@sophokles73 :+1 jacoco … I agree, no one really used it. … About github security issues, I like the warning system. I am not so fond of the automatic PR creation …
Kai Hudalla
@sophokles73
Ok, then I'll remove the JaCoCo stuff ...
Kai Hudalla
@sophokles73
@ctron @dejanb @calohmn we really need to come to a conclusion regarding the scope of Hono's public API. Please add your comments/opinion to the thread on the mailing list. We will have a very hard time making any reasonable changes to Hono if we are not clear about which classes we can change without affecting compatibility and which classes we can't.
Kai Hudalla
@sophokles73
@ctron @dejanb @calohmn I have posted a proposal regarding the Hono Helm chart on the mailing list which I hope finds your approval. Can you please review and cast your vote?
Kai Hudalla
@sophokles73
Hi everybody, I have created and published the Hono 1.1.0 release. The Helm chart is now available from the Eclipse IoT Packages project. Next step is integrating it with Ditto and hawkBit into a real package ...
Patrick Sernetz
@patrickse
:+1: great addition to Eclipse IoT Packages...
will test the package later
Karthees Kalidass
@kaniyan
:+1:
Patrick Sernetz
@patrickse
Works like a charm ... deployed hono in seconds on my dev k8n. So much easier to deploy from eclipse iot packages :+1:
Kai Hudalla
@sophokles73
@patrickse thanks for the feed back. That was the overall intention :-) May I ask what you are using Hono for?
Patrick Sernetz
@patrickse
@sophokles73 sure. We can talk about in person if you're attending BCX this year?
Kai Hudalla
@sophokles73
I do. I will be lingering around, trying to coach people regarding Open Source :-)
Patrick Sernetz
@patrickse
Perfect match ... :-D
Carsten Lohmann
@calohmn
@jbtrystram @dejanb Are you already working on removing the EventBus usage in the DeviceConnection service (as part of #1346)? I'm about to add some methods in there, so if you haven't started yet, it would be good to choose another service as the next one to remove the EventBus in.
Dejan Bosanac
@dejanb
@calohmn we're not started with that one ... please go ahead
Carsten Lohmann
@calohmn
ok, good
Bob Claerhout
@BobClaerhout
When starting the lora adapter v1.1.0 I'm getting following exception. Since I'm rather new in the dependency injection part hono, anyone got a hint on this? I've got a feeling that somebody with more experience is able to pinpoint this immediatly.
Caused by: org.springframework.beans.factory.NoUniqueBeanDefinitionException: No qualifying bean of type 'org.eclipse.hono.adapter.http.HttpAdapterMetrics' available: expected single matching bean but found 2: micrometerBasedHttpAdapterMetrics,adapterMetrics
    at org.springframework.beans.factory.config.DependencyDescriptor.resolveNotUnique(DependencyDescriptor.java:221)
    at org.springframework.beans.factory.support.DefaultListableBeanFactory.doResolveDependency(DefaultListableBeanFactory.java:1233)
    at org.springframework.beans.factory.support.DefaultListableBeanFactory.resolveDependency(DefaultListableBeanFactory.java:1175)
    at org.springframework.beans.factory.annotation.AutowiredAnnotationBeanPostProcessor$AutowiredMethodElement.inject(AutowiredAnnotationBeanPostProcessor.java:670)
    ... 31 common frames omitted
Bob Claerhout
@BobClaerhout
New day, new insights....
When I remove the @component from class MicrometerBasedHttpAdapterMetrics I'm able to start the lora protocol adapter again. Do we have any reason why this class should be known by the DI container? It is never consturcuted automatically, always via its constructor(sigofx and lora)
Abel Büchner-Mihaljević
@b-abel

Hi Bob! You are right, the bean is declared two times for the Lora and Sigfox adapters.
I don't know what you are working on, so here is some background information that hopefully might be helpful:
In Spring there are are several options for bean creation. One is "annotation-based configuration", which means that you add an annotation like @Component to the class to be "automagically" instanciated. This requires component scanning to be enabled, for example like this. Another option is "Java-based configuration", this is done by calling the constructor of the class to be instantiated in a method annotated with @Bean inside of a class with a @Configuration annotation.
There are more options and variants of this, but those are the basics relevant to this case.

Back to your problem: as you pointed out Lora and Sigfox adapters already use Java-based configuration (which I personally prefer since it is less invasive, no need to introduce dependencies in the target code), so it might be the best option to remove the annotations from MicrometerBasedHttpAdapterMetrics and use it with Java-based configuration for the HTTP adapter.

Bob Claerhout
@BobClaerhout
Ok, I've tried removing the @component annotation but if I do, the HttpAdapter is not able to startup anymore because it is looking for the metrics as well. Should we add the java-based configuration in the http adapter to fix this? Or do you propose something else?
Abel Büchner-Mihaljević
@b-abel

Ok, I've tried removing the @component annotation but if I do, the HttpAdapter is not able to startup anymore because it is looking for the metrics as well. Should we add the java-based configuration in the http adapter to fix this?

Yes. I think this should look like the configuration of the Lora adapter.

Bob Claerhout
@BobClaerhout
PR created: eclipse/hono#1773
Thanks for your input @b-abel
johnMinelli
@johnMinelli
Hi, i'm trying to do something for #1486: I've some doubt about the handling of the default configuration. I maintained actual the spring boot configuration overwriting it, but i'm not sure how the secure-connection and certs are configuration is intended (there are some comments in the application.yml). Also why the profile amqp-send and amqp-command are handled in a different way (also there is no mention in the docs, or at least i'havn't found it)
Abel Büchner-Mihaljević
@b-abel
Hi @johnMinelli , does my comment on the ticket help you with this?
Abel Büchner-Mihaljević
@b-abel
Regarding the profiles: There's a mess there right now. Unrelated things are mingled together. To shed some light on this, it might be helpful to see which properties are set in each profile. It might be better, as I wrote in the ticket, to rewrite the CLI application more or less completely and replace it with two separate (of course compatible) applications.
The profiles are mentioned in the documentation here: https://www.eclipse.org/hono/docs/user-guide/amqp-adapter/#amqp-command-line-client
Abel Büchner-Mihaljević
@b-abel
@johnMinelli I just saw that you've already done quite a bit on it. Please don't let the goals I set out in the ticket stop you from contributing. It's not necessary to make all these changes at once.
johnMinelli
@johnMinelli
Thanks for the reply, i'll watch the implementation of the factory you suggusted for the device side with the already existing one (thanks for the doc reference). I'm very new to the project so if you think that split the application in two is a better thing i'll do it, but for my experience more files are more confusing for a new user. I thought to do as in the screenshoot. The upperbound is ok, i reused almost all the code already in the cli module. The south part is just a copy and paste to make the screen.
Cattura.PNG