I have a websocket app (https://github.com/rampatra/jbot/) talking to slack - it works just fine when launching via maven jetty plugin, but as a .war in a standalone jetty it failed looking for provider implementation, it can find it when adding —module websockets, but it then fails at the http layer - where should jetty-websocket-httpclient.xml be placed?
web | org.eclipse.jetty.websocket.api.UpgradeException: Failed to upgrade to websocket: Unexpected HTTP Response Status Code: 0 null
the
jetty-websocket-httpclient.xml should be in your classpath, it is to load a specific HttpClient configuration for JSR356 users (useful for proxy configurations, specific security configurations, specific ssl/tls configurations, etc)
if you are using
maven-jetty-plugin then you are using the old plugin.
the correct and up to date plugin is
jetty-maven-plugin
@davidkarlsen please file an issue at https://github.com/eclipse/jetty.project/issues and include the specific version of jetty you are using and complete stacktrace.
The
Failed to upgrade to websocket: Unexpected HTTP Response Status Code: 0 null indicates both an old Jetty version in use (the message has been cleaned up in recent versions), and an HTTP response from the remote that isn't a WebSocket upgrade. (details of the failure are typically reported in logging)
I’ll check if some deps snook in
tomate et2448$ unzip -t target/icp-automate-1.0-SNAPSHOT.war |grep -i jetty
testing: WEB-INF/jetty-web.xml OK
testing: WEB-INF/jetty-websocket-httpclient.xml OK
Davids-Work-MacBook-Pro:icp-automate et2448$
testing: WEB-INF/jetty-web.xml OK
testing: WEB-INF/jetty-websocket-httpclient.xml OK
Davids-Work-MacBook-Pro:icp-automate et2448$
joakime @joakime is afk
joakime @joakime is back
if you are using slf4j, then the slf4j configuration needs to be edited.
you have an account there (if you have one on github.com)
and you can delete the log later (if you want)
1;38;5;2mweb [0m | 2018-11-28 17:22:09.397:WARN:oejwc.XmlBasedHttpClientProvider:main: Unable to load: file:/app/resources/jetty-websocket-httpclient.xml
[1;38;5;2mweb [0m | java.lang.ClassNotFoundException: org.eclipse.jetty.client.HttpClient
[1;38;5;2mweb [0m | java.lang.ClassNotFoundException: org.eclipse.jetty.client.HttpClient
I’ll post my config in the gist
howto configure proxy then?
proxy is the
proxy module in your ${jetty.base}
ait - got it to work, added the config file on class path and added http://repo1.maven.org/maven2/org/eclipse/jetty/websocket/javax-websocket-client-impl/ to the app -> happytimes
I am able to access this class through a WebServerFactoryCustomizer: https://docs.spring.io/spring-boot/docs/current/api/org/springframework/boot/web/embedded/jetty/JettyServletWebServerFactory.html
but I am not sure how I can use it to add some kind of redirection rule
Next, add the SecureRedirectHandler to your handler list (somewhere early, perhaps even the first entry)
For redirects, you can either use the Servlet API's .sendRedirect() from a Servlet
or you can use the Jetty RedirectHandler and whatever rules you want to attach to it.
just make sure that RedirectHandler sits before your application handlers in the handler tree.
