You can also review them, create an issue for one you think makes sense and provide a PR to fix it.
nightswimmings
@nightswimmings
Is there any feature on the JKube that I might miss if I choose to build the image through spring-boot:build-image?
To put it in other words, now the image is built with a built-in option of the Boot ecosystem, will I regret if I migrate my jkube setup to it and keep it only for the resources goal part?
nightswimmings
@nightswimmings
In a way its like if SpringBoot had standarized the k8s:build and k8s:push goals, and as the plugin already wraps the underlying generator features..
Rohan Kumar
@rohanKanojia
I'm not sure since I haven't tried out spring-boot:build-image goal
Does it use docker daemon to build docker image? Can it build image without any docker daemon?
I mean does it provide different build strategies for building images?
nightswimmings
@nightswimmings
AFAIK, it works by creating the image and saving it in the local repo, and then it pushes like if it were a docker push
Rohan Kumar
@rohanKanojia
Does it allow configuring image to be created using custom Dockerfile/XML configuration?
nightswimmings
@nightswimmings
yes
wait, not sure if through Dockerfile
it uses buildpack internally by default
but its plenty customizable
I think you can indeed customize the image creator if not
Rohan Kumar
@rohanKanojia
ohk, if it fits your use case. You might be able to avoid k8s:build and switch to spring-boot:build-image goal.
Yes it looks quite similar, but begin such an important part of the build process, relying on boot community opinionated implementations is interesting, even though we had 0 problems with fabric8 and jkube
Rohan Kumar
@rohanKanojia
I remember Marc told me that this spring-boot:build-image goal only works for newer versions of spring boot, not with spring boot 1.x
But jkube works with all spring boot versions
nightswimmings
@nightswimmings
right, that is why no. one is using it yet
Marc Nuri
@manusa
It was introduced in 2.3 (I think)
The main difference so far is that the Spring build-image supposedly creates optimized layered images, so when rerunning the build process, everything is quicker
We are working on some enhancements to provide this in JKube too (eclipse/jkube#425)
Kindly review this issue, if seems correct I will send a PR, for the proposed solution. Thank You
Rohan Kumar
@rohanKanojia
looks good to me :+1:
lumeche
@lumeche
Now another question. Helm uses goland templating and in general we could take advantages of it when building the yaml. I tested and saw that the Jackson parser failed if I tried to use. Do you know how can I use it? For example if I want to do {{ .Values.something | quote }}
I want to come back to this question.
How can I add some goland specific template things that helm is able to process like quote?
Sorry for the wait, there's a really long queue of pending PRs :sweat:. Hopefully we can get that in by the end of today
K007
@theexplorist
looks good to me :+1:
Sending PR.
lumeche
@lumeche
I'm having problems with quotes. I need to generate a config from values.yml. I need the numbers been in quotes. Things like this
data:
cluster-agent-configmap-refresh-time: "10000"
But instead I'm always getting
data:
cluster-agent-configmap-refresh-time: 10000
Sorry about the font size :(
now. I'm not able to get the quotes regardless if in the Values.yaml I'm having the value with quotes or in the template I put ${myvalue} or "${myvalue}"
is there a way I could solve this?
Marc Nuri
@manusa
That's due to YAML serialization, YAML is a fantastic markup language where strings can be quoted or not.