Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jan 29 10:47
    codecov[bot] commented #2013
  • Jan 29 10:47
    codecov[bot] commented #2013
  • Jan 29 10:46
    rohit9625 reopened #2013
  • Jan 29 06:07
    manusa commented #1987
  • Jan 29 06:07
    manusa commented #1987
  • Jan 29 05:59
    manusa commented #1987
  • Jan 29 05:20
    manusa commented #1987
  • Jan 29 05:20
    manusa commented #1987
  • Jan 29 05:19
    manusa commented #1987
  • Jan 29 05:16
    manusa commented #1987
  • Jan 29 05:14
    manusa commented #1987
  • Jan 29 05:12
    manusa commented #1987
  • Jan 29 05:11
    manusa commented #1987
  • Jan 29 05:10
    manusa commented #1987
  • Jan 29 05:10
    manusa commented #1987
  • Jan 29 05:10
    manusa commented #1987
  • Jan 29 05:08
    manusa commented #1987
  • Jan 29 05:07
    manusa commented #1987
  • Jan 29 05:07
    manusa commented #1987
  • Jan 29 05:07
    manusa commented #1987
Rohan Kumar
@rohanKanojia
I think this one is okay
Could you please update the title of your PR?
Jendrik Badde
@chambora1312
changed it
hope its ok this time
Rohan Kumar
@rohanKanojia
cool, thanks a lot
I think it will be merged soon
Jendrik Badde
@chambora1312
thanks a lot for your help! i really appreciate it. my mistake was that i tried to push from eclipse itself. so i think i somehow missed to add the changed file. from now on, i will work with git bash
Rohan Kumar
@rohanKanojia
:+1:
what were you using earlier?
Jendrik Badde
@chambora1312
i tried everything directly out of eclipse ide
I have a question concerning issue #822. i replaced the line, but now i want to mvn clean install it. i have no idea how to do it directly in eclipse
Rohan Kumar
@rohanKanojia
Umm, I'm not sure. I don't use Eclipse at work. I use IntelliJ. Let me try jkube with eclipse :-)
Rohan Kumar
@rohanKanojia
I think you'll need to install lombok plugin in Eclipse for working with jkube
Jendrik Badde
@chambora1312
Ok thanks, will try it :)
Rohan Kumar
@rohanKanojia
On a quick try I wasn't able to get Eclipse working with JKube :-(
Jendrik Badde
@chambora1312
I will try it tomorrow :)
Rohan Kumar
@rohanKanojia
no rush. Would it be possible for you to try out IntelliJ ;-) ?
Jendrik Badde
@chambora1312
I will try
Rohan Kumar
@rohanKanojia
Thanks! I think you'll like it :-)
Install IntelliJ > Install Lombok IntelliJ Plugin > run mvn clean install on terminal > Load jkube as a maven project in IntelliJ
Jendrik Badde
@chambora1312
I already worked with intellij ultimate. Thats why i always thought that it want free. Didnt know of intellij community
Rohan Kumar
@rohanKanojia
I think with IntelliJ Community addition you can do it.
I was also using intellij community an year ago
Jendrik Badde
@chambora1312
I installed Intellij, but for some reason my maven plugin doesn't work properly. How can i verify the changes for issue#822?
Rohan Kumar
@rohanKanojia
Do you have docker installed on your system?
After compilation, you can go to quickstarts/maven/spring-boot folder and run mvn k8s:build
Build offers different strategies, default is docker. Plain mvn k8s:build should generate docker image
Mvn k8s:build -Djkube.build.strategy=jib creates image with JIB build strategy
Jendrik Badde
@chambora1312
Ok will try it later :)
Kartik Sapra
@theexplorist

On a quick try I wasn't able to get Eclipse working with JKube :-(

Eclipse does not works with jkube, it is very hard to make it work, intellij community edition is the best option. @maycap123

@rohanKanojia @manusa #825 I have updated the PR with required changes and kuberenetes testing, I think everything is working fine. Kindly give your reviews on it.

Have a nice day!

Sandra
@Onyinye91-ctrl
Hello @rohanKanojia for the issue #914. I have done all you said i do. I actually want to share a screenshot but can't find where to. Will do on github
Rohan Kumar
@rohanKanojia
Hi, Have you pushed updated commit to github?
git push origin master -f
Sandra
@Onyinye91-ctrl
@rohanKanojia I have done it. Is it visible in your end?
Rohan Kumar
@rohanKanojia
No
oh, sorry. It seems to be fixed now(ECA check)
Sandra
@Onyinye91-ctrl
Okay. Thanks
Rohan Kumar
@rohanKanojia
sorry for not being clear but I wasn't referring to this. I wanted to get commit title updated. It's first commit right now. could you please do git commit --amend --signoff and set title same as this comment? You would need to push to github after doing this
Sandra
@Onyinye91-ctrl
How do i set the title
Rohan Kumar
@rohanKanojia
run git commit --amend, it will open up an editor where you can do it
Sandra
@Onyinye91-ctrl
Okay
Jendrik Badde
@chambora1312
I'm working on #802 right now. The task is to replace GenericCustomResource with GenericKubernetesResource throughout the whole project. Is there an easy way to find all occurrences of GenericCustomResource?
Sandra
@Onyinye91-ctrl
@rohanKanojia I have made the changes but it seems that it didn't work. Can you check it out?
Rohan Kumar
@rohanKanojia
Sorry, it doesn't look like your changes are actually pushed. It should get reflected on eclipse/jkube#855
@maycap123 : git grep -in GenericCustomResource
You can also do Ctrl+Shift+F in IntelliJ to search across project
Sandra
@Onyinye91-ctrl
@rohanKanojia I have done it. Please confirm
Rohan Kumar
@rohanKanojia
yes, it seems to be updated. Thanks