Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 11:49
  • 11:46
    manusa commented #1787
  • 11:46
    manusa commented #1787
  • 11:45
    manusa commented #1787
  • 11:43
    manusa commented #1787
  • 11:42
    codecov[bot] commented #1787
  • 11:42
    manusa commented #1787
  • 11:41
    sonarcloud[bot] commented #1787
  • 11:41
    manusa commented #1787
  • 11:39
    anurag-rajawat commented #1787
  • 11:38
    manusa commented #1787
  • 11:38
    manusa commented #1787
  • 11:38
    manusa commented #1787
  • 11:37
    manusa commented #1787
  • 11:37
    manusa commented #1787
  • 11:36
    manusa commented #1787
  • 11:36
    manusa commented #1787
  • 11:36
    manusa commented #1787
  • 11:36
    manusa commented #1787
  • 11:34
    manusa commented #1787
Sandra
@Onyinye91-ctrl
@rohanKanojia I have made the changes but it seems that it didn't work. Can you check it out?
Rohan Kumar
@rohanKanojia
Sorry, it doesn't look like your changes are actually pushed. It should get reflected on eclipse/jkube#855
@maycap123 : git grep -in GenericCustomResource
You can also do Ctrl+Shift+F in IntelliJ to search across project
Sandra
@Onyinye91-ctrl
@rohanKanojia I have done it. Please confirm
Rohan Kumar
@rohanKanojia
yes, it seems to be updated. Thanks
Jendrik Badde
@maycap123
For my understanding: i should replace GenericCustomResource with GenericKubernetesResource. In every method, class and so on?
Should i then delete the class GenericCustomResource as well?
Rohan Kumar
@rohanKanojia
yes
Jendrik Badde
@maycap123
Ok thanks
yberkov
@yaakov-berkovitch
Hi, I have my own customized helm chart files and want jkube only to package it and push it to repo (using mvn k8s:helm). I cannot make it working. How should I specify the location of my helm chart files ?
Rohan Kumar
@rohanKanojia
I don't think we support this
yberkov
@yaakov-berkovitch
Thanks @rohanKanojia . I read the answer @manusa gave to stackoverflow and explained there that JKube is meanly for generating. But for building docker image I can provide my own Dockerfile. So I expect that the same behavior will be also for helm charts, that is giving a folder where my chart files are located. BTW, our charts are not so simple, and we are using chart libraries, templates...And I would prefer to use only one plugin (jkube).
Rohan Kumar
@rohanKanojia
good point.
Marc is on PTO and will be back next week
Shall we create an issue about it for discussion?
yberkov
@yaakov-berkovitch
@rohanKanojia, not sure if you addressed your question to me, but anyway do you want me to open a feature request ?
Rohan Kumar
@rohanKanojia
Yes, please.
Jendrik Badde
@maycap123
What do i do to include the added lines in tests so that i pass the sonarcloud test? In Pull request 860
Rohan Kumar
@rohanKanojia
You would need to add tests. Sonar usually expects at least 80% test coverage
Jendrik Badde
@maycap123
Ok never did that. Is there a good explanation anywhere?
IntelliJ's unit test video can give you a quick walkthrough of writing tests and checking code coverage via IDE
Jendrik Badde
@maycap123
Thanks, i will look into it! :)
Slok
@kumar-cloud

Issue: I have docker limiting issue with busybox. This is impicitly creaed/encriched by Jkube in k8s environment.

is there anyway to change busybox image name in jkube-volume-permission container enricher .....I want to use my own ECR image ,
Is there any coniguration for the same ?

WDYT? Shall we create an issue?
Slok
@kumar-cloud
Thanks @rohanKanojia
I feel so , we need to create an issue. I did create an issue eclipse/jkube#891
These days mostly every one have their own ECR from aws,azure..etc..
But anybody have temporary fix for this ..?
Rohan Kumar
@rohanKanojia
Could you please try by providing a custom yaml fragment in src/main/jkube ?
Slok
@kumar-cloud
I did that, we have custom yamls with initContainer named same as : jkube-volume-permission and with different image name , but that not picksup.....
Slok
@kumar-cloud
@rohanKanojia Can i fork this Project to my github account and fix there and do PullRequest after that ?
Rohan Kumar
@rohanKanojia
yes
Slok
@kumar-cloud
OK Thanks , I am working on it right now.
Can I add issue number in java class where we have issue ?
like
27 replies
// Issue:#891: busybox image name is hardcoded in VolumePermissionEnricher class, need to make it as config
.withImage(getConfig(Config.IMAGE_NAME,Config.IMAGE_NAME.getDefaultValue()))
Slok
@kumar-cloud
I did mvn compile after code fix , anything else you want me to run ?
Nishant Raut
@nishantraut
Hi @rohanKanojia and @manusa Hope you are well. I was going through code and found some typo's in comments, let me know if you want me to correct it.
Rohan Kumar
@rohanKanojia
Could you please share the files where you found typos?
Nishant Raut
@nishantraut
for ex AssemblyFiles, AssemblyManager etc
4 replies
Slok
@kumar-cloud
@rohanKanojia Can you please help me , I have submitted PR for busybox change
Rohan Kumar
@rohanKanojia
okay.
@kumar-cloud : What issue are you facing?
Slok
@kumar-cloud
I have added the testcase for the changes. Could you please help me to review ..
Marco Ronconi
@m.ronconi_gitlab
hello, I need to set the following annotation (kubernetes.io/ingress.class: "nginx") to Ingress, but the name contains a char "/" and it is not possible to define it via XML enricher. Do you know an alternative?
Thanks.
~
7 replies