Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 19:05
    codecov[bot] commented #1544
  • 19:05
    codecov[bot] commented #1544
  • 19:05
    MMajd edited #1544
  • 19:05
    MMajd edited #1544
  • 18:22
    rohanshankar commented #1607
  • 15:29
    manusa commented #1447
  • 15:29
    manusa commented #1447
  • 15:28
    manusa commented #1447
  • 15:20
    manusa commented #1447
  • 15:19
    manusa commented #1447
  • 15:18
    manusa commented #1447
  • 15:18
    manusa commented #1447
  • 15:17
    codecov[bot] commented #1447
  • 15:16
    manusa commented #1447
  • 15:16
    codecov[bot] commented #1447
  • 15:15
    codecov[bot] commented #1447
  • 15:15
    manusa commented #1447
  • 15:15
    sonarcloud[bot] commented #1447
  • 15:15
    sonarcloud[bot] commented #1447
Rohan Kumar
@rohanKanojia
Yes, please.
Jendrik Badde
@maycap123
What do i do to include the added lines in tests so that i pass the sonarcloud test? In Pull request 860
Rohan Kumar
@rohanKanojia
You would need to add tests. Sonar usually expects at least 80% test coverage
Jendrik Badde
@maycap123
Ok never did that. Is there a good explanation anywhere?
IntelliJ's unit test video can give you a quick walkthrough of writing tests and checking code coverage via IDE
Jendrik Badde
@maycap123
Thanks, i will look into it! :)
Slok
@kumar-cloud

Issue: I have docker limiting issue with busybox. This is impicitly creaed/encriched by Jkube in k8s environment.

is there anyway to change busybox image name in jkube-volume-permission container enricher .....I want to use my own ECR image ,
Is there any coniguration for the same ?

WDYT? Shall we create an issue?
Slok
@kumar-cloud
Thanks @rohanKanojia
I feel so , we need to create an issue. I did create an issue eclipse/jkube#891
These days mostly every one have their own ECR from aws,azure..etc..
But anybody have temporary fix for this ..?
Rohan Kumar
@rohanKanojia
Could you please try by providing a custom yaml fragment in src/main/jkube ?
Slok
@kumar-cloud
I did that, we have custom yamls with initContainer named same as : jkube-volume-permission and with different image name , but that not picksup.....
Slok
@kumar-cloud
@rohanKanojia Can i fork this Project to my github account and fix there and do PullRequest after that ?
Rohan Kumar
@rohanKanojia
yes
Slok
@kumar-cloud
OK Thanks , I am working on it right now.
Can I add issue number in java class where we have issue ?
like
27 replies
// Issue:#891: busybox image name is hardcoded in VolumePermissionEnricher class, need to make it as config
.withImage(getConfig(Config.IMAGE_NAME,Config.IMAGE_NAME.getDefaultValue()))
Slok
@kumar-cloud
I did mvn compile after code fix , anything else you want me to run ?
Nishant Raut
@nishantraut
Hi @rohanKanojia and @manusa Hope you are well. I was going through code and found some typo's in comments, let me know if you want me to correct it.
Rohan Kumar
@rohanKanojia
Could you please share the files where you found typos?
Nishant Raut
@nishantraut
for ex AssemblyFiles, AssemblyManager etc
4 replies
Slok
@kumar-cloud
@rohanKanojia Can you please help me , I have submitted PR for busybox change
Rohan Kumar
@rohanKanojia
okay.
@kumar-cloud : What issue are you facing?
Slok
@kumar-cloud
I have added the testcase for the changes. Could you please help me to review ..
Marco Ronconi
@m.ronconi_gitlab
hello, I need to set the following annotation (kubernetes.io/ingress.class: "nginx") to Ingress, but the name contains a char "/" and it is not possible to define it via XML enricher. Do you know an alternative?
Thanks.
~
7 replies
Rohan Kumar
@rohanKanojia
You can try placing a small YAML fragment that just contains the annotation part: https://github.com/eclipse/jkube/blob/master/quickstarts/maven/external-resources/src/main/jkube/deployment.yml#L15
Marco Ronconi
@m.ronconi_gitlab
I tried, but if I use the YAML fragment (ingress.yml) with only the specific annotation, the generated YAML file is not enriched with XML definitions.
Rohan Kumar
@rohanKanojia
Hm, I think maybe mixing XML and resource fragment configuration is not supported. Could you please try moving XML definition to fragment?
Marco Ronconi
@m.ronconi_gitlab
If i moving the XML definition in fragment works fine. Thanks a lot.
Rohan Kumar
@rohanKanojia
@m.ronconi_gitlab : Np, Thanks a lot for trying out jkube :-)
Cristiano GaviĆ£o
@cvgaviao

Hi all. I'm researching alternatives for our current docker-daemon based image build. I would like to hear any suggestions from you.
Currently, we are building an image using dockerFile with multi-stages feature.

In the first stage, I take a graal-vm image and I install native-image on it.
In the next stage, I copy our project's generated jars to it and run native-image tool on them.
And in the last stage, I take a small Linux distro and copy the artifacts from stage 2 to it.

Question: can we achieve that using docker-daemon-less feature of jkube ?

Marc Nuri
@manusa
I'm not sure what you're referring to with docker daemon-less feature. I've never tried a mutli-stage build with the Dockerfile mode, but it should work.
2 replies
robinroos
@robinroos
Hi Marc / Rohan. I am trying to push images to our in-house Nexus (Docker Registry) whilst still doing an S2I build in OpenShift. I get the following warning:
[WARNING] oc: Image is pushed to OpenShift's internal registry during oc:build goal. Skipping...
So far I have configured the registry tag withing the plugin configuration to point to our Nexus. Is there something else to do, or am I attempting the impossible? Thanks and regardsm, Robin.
16 replies
Marc Nuri
@manusa
image.png
Noel O'Connor
@noeloc_twitter
Hi, I'm struggling to use jkube on an existing quarkus multimodule project. For some reason jKube cannot detect that it's a quarkus project and then can't generate the correct resources. How does jkube detect that it's a quarkus project ?
Rohan Kumar
@rohanKanojia
oh, could this be related to eclipse/jkube#923
Which version of quarkus are you using?
JKube has this concept of generators in which it creates opinionated container images by checking your plugins: https://github.com/eclipse/jkube/blob/master/jkube-kit/jkube-kit-quarkus/src/main/java/org/eclipse/jkube/quarkus/generator/QuarkusGenerator.java#L69
Noel O'Connor
@noeloc_twitter
thanks Rohan, I'll try that....I do have the plugin but only on the parent pom so that might be the issue
Rohan Kumar
@rohanKanojia
Do you have the project available publicly somewhere so that we can also try out and check?
Noel O'Connor
@noeloc_twitter
yep...hold on 1 min
https://github.com/noelo/istio-demo just a playground at the moment I'm using for a few things
Noel O'Connor
@noeloc_twitter
yep just confirmed it was linked to the jkube#923 that you mentioned