Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 16:33
    manusa commented #590
  • 16:30
    manusa labeled #630
  • 16:30
    manusa milestoned #630
  • 16:30
    manusa labeled #630
  • 16:26
    manusa milestoned #663
  • 16:26
    manusa labeled #663
  • 16:05
    codecov[bot] commented #664
  • 16:05
    manusa review_requested #664
  • 15:21
    manusa commented #664
  • 15:21
    manusa commented #664
  • 15:17
    manusa commented #664
  • 15:15
    manusa commented #664
  • 15:12
    manusa commented #664
  • 15:12
    manusa commented #660
  • 15:11
    manusa commented #660
  • 15:10
    manusa commented #664
  • 15:10
    manusa commented #664
  • 15:08
    manusa commented #664
  • 15:08
    codecov[bot] commented #664
  • 15:08
    manusa commented #664
Rohan Kumar
@rohanKanojia
I think it should show up java -jar logs(if this is the entrypoint)
Are you able to run the docker image created during mvn k8s:build goal
Rohan Kumar
@rohanKanojia
Let me check your reproducer project again
Ghassen Khalil Ati
@ghassenkhalil:matrix.org
[m]
I just updated it
thank you
Rohan Kumar
@rohanKanojia
I think I can see your issue now :-(
In Dockerfile mode, I'm not able to override default image name with jkube.generator.name
Ghassen Khalil Ati
@ghassenkhalil:matrix.org
[m]
oh thank god, finally you reproduce it
:)
Rohan Kumar
@rohanKanojia
I've created this issue: eclipse/jkube#624
For now you can either move Dockerfile to some other directory and use imageconfiguration like this: https://github.com/eclipse/jkube/blob/master/quickstarts/maven/docker-file-provided/pom.xml#L114
or drop Dockerfile and switch to full XML configuration like this:
            <plugin>
                <groupId>org.eclipse.jkube</groupId>
                <artifactId>kubernetes-maven-plugin</artifactId>
                <version>1.1.1</version>
                <configuration>
                    <images>
                        <image>
                            <name>usernaeme/${project.artifactId}:${project.version}</name>
                            <build>
                                <from>adoptopenjdk/openjdk11:latest</from>
                                <cmd>java -jar maven/${project.artifactId}-${project.version}.jar</cmd>
                                <ports>
                                    <port>8080</port>
                                </ports>
                            </build>
                        </image>
                    </images>
                </configuration>
            </plugin>
Do-min-ik
@Do-min-ik
Hi there. I'm trying to deploy strimzi along with a custom object to kubernetes. So I've copied the CustomResourceDefinition file to src/man/jkube and "KafkaTopic" kind into file called bla-kt.yml. However, I get this error message: [...] org.eclipse.jkube:kubernetes-maven-plugin:1.1.1:resource failed: No resource type found for:kafka.strimzi.io#KafkaTopic
Rohan Kumar
@rohanKanojia
Hi Dominik
Are you specifying Kafka CustomResource in XMl configuration like this: https://github.com/r0haaaan/jkube-custom-resource-fragments/blob/master/pom.xml#L89
Till, 1.1.1 we need to specify it
In upcoming release you will get much better support for CustomResources
Do-min-ik
@Do-min-ik
Specifying customResourceDefinitions in pom.xml makes no difference, unfortunately
Rohan Kumar
@rohanKanojia
We also need to prefix customresource fragment file names with *-cr.yml
Do-min-ik
@Do-min-ik
With bla-cr.yml the error is gone. However k8s:apply does not seem to apply that file . In addition, I don't see its content anywhere in my target folder
Rohan Kumar
@rohanKanojia
till 1.1.1, CustomResources were applied direcly during k8s:apply phase. We have changed this behavior now and it's included in target folder. But it will be available in 1.2.0
Would it be possible to try out jkube's master build of 1.2.0-SNAPSHOT and see if your experience is improved?
Do-min-ik
@Do-min-ik
Yes, of course. I'll try it later. Thanks, Rohan!
Rohan Kumar
@rohanKanojia
We'll be releasing a new version by the end of this month, I'll ping you whenever we release
Do-min-ik
@Do-min-ik
Unfortunately, I can't get 1.2.0-SNAPSHOT to work as I get some weird unresolved type errors during mvn k8s:resource
Rohan Kumar
@rohanKanojia
Do you have some reproducer project that I cant ry out?
Do-min-ik
@Do-min-ik
https://github.com/Do-min-ik/jkube-custom-resource-fragments I actually just changed the version to 1.1.1., applied it and checked kubectl get dummies.demo.fabric8.io
Rohan Kumar
@rohanKanojia
@Do-min-ik : Hello, I tried out your reproducer and checked that dummies.demo.fabric8.io customresource actually got applied
Marc Nuri
@manusa
Starting release process for 1.2.0
Domenico Loiacono
@dloiacono
clap clap
Rohan Kumar
@rohanKanojia
:rocket:
Rohan Kumar
@rohanKanojia
I see release announcement, seems like 1.2.0 got released :tada:
@Do-min-ik : Hello, we just released 1.2.0 . Could you please try out this version and see if custom resource support is improved?
Rohan Kumar
@rohanKanojia
Congratulations on the release!
K007
@theexplorist
Congrats on the release!
Is it a good practice to use Iterator for iterating over unparametrized map
@manusa @rohanKanojia
Rohan Kumar
@rohanKanojia
Umm, could you please elaborate? What are you trying to do?
K007
@theexplorist
I have sent a PR on issue #634 , in one case we have a map of raw type!
So if we have to use entrySet, I guess the best we can do is using java.util.Iterator
Rohan Kumar
@rohanKanojia
Umm, I'm not sure. I don't see much difference in both approaches.
K007
@theexplorist
It actually is giving code smells, due to parametrisation
But the map in argument is of raw type
Rohan Kumar
@rohanKanojia
We're getting map as method parameter so I'm not sure we can do much
K007
@theexplorist
Yes so I guess we cannot do much for the sonar smells then
Domenico Loiacono
@dloiacono
Hello, @rohanKanojia @manusa https://github.com/eclipse/jkube/pull/636/ and eclipse/jkube#638 are ready for code review :P
Rohan Kumar
@rohanKanojia
Thanks, will try to review it by the end of today :)
Marc Nuri
@manusa
Hi @dloiacono, thx for the heads-up. I'll try to review as soon as possible, however, we're busy dealing with a new Fabric8 Kubernetes Client release scheduled for tomorrow (5.3.0)