Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Roberto Cortez
    @radcortez
    y sec
    Emily Jiang
    @Emily-Jiang
    thanks
    is 1375 and not 1357 :)
    Emily Jiang
    @Emily-Jiang
    That is an explaination from the template
    Roberto Cortez
    @radcortez
    ah sorry
    Emily Jiang
    @Emily-Jiang
    np
    Roberto Cortez
    @radcortez
    it is confusing because it is a link so the instict is to click on it
    we may need to drop that piece
    Emily Jiang
    @Emily-Jiang
    maybe change 1357 to xxxx
    Roberto Cortez
    @radcortez
    and drop the link
    Emily Jiang
    @Emily-Jiang
    I think the link helps with someone who tries to figure what links to attach
    Roberto Cortez
    @radcortez
    ok
    Roberto Cortez
    @radcortez
    I’ve reused the same issue
    and just changed the links
    Emily Jiang
    @Emily-Jiang
    awesome. thanks
    I have addressed your comments
    to make the link not showing as a link
    you are quick. Thanks!
    Roberto Cortez
    @radcortez
    :D
    Emily Jiang
    @Emily-Jiang
    By the way, I have asked Kevin to mentor MP Config release. He will send an email to microprofile-wg for voting. I'll send email to the other parties and then give him a go ahead.
    Roberto Cortez
    @radcortez
    Ok!
    Emily Jiang
    @Emily-Jiang
    thanks
    Duncan
    @dabloem
    Hi all, I was wondering if there is already something to bring mp-config to spring-boot?
    So, developers can use @ConfigProperty instead of @Value ?
    Jan Bernitt
    @jbee
    isn't MP config dependent on CDI which you do not have in a spring environment?
    Roberto Cortez
    @radcortez
    Yes, for @NonBinding
    spring supports @Inject, not sure now it deals with @NonBinding
    Jan Bernitt
    @jbee
    surely you can make the annotation work in some way on top of spring concepts but it might need some adaptors or even replacement of classes I would guess
    Duncan
    @dabloem
    Well, I did some proof of concept. And it works
    however, I am not a spring guru
    Roberto Cortez
    @radcortez
    which MP Config implementation are you using?
    Duncan
    @dabloem
    I implemented a BeanPostProcessor which is looking for ConfigProperty on fields, and if found it adds a FieldCallBack, which does the lookup via ConfigProvider.getConfig()
    Roberto Cortez
    @radcortez
    ah great
    Duncan
    @dabloem
    Smallrye and Geronimo both work
    Roberto Cortez
    @radcortez
    unfortunately for a single annotation you do required to have the CDI API jar in your CP
    Duncan
    @dabloem
    But because it was not that hard, I was just wondering if this already exists, and probably a bit more mature
    Roberto Cortez
    @radcortez
    not that I’m aware, because no one ever asked for it. usually spring developers stick to what they already have
    but that is interesting work, are you interested in contributing something into SR? :)
    Duncan
    @dabloem
    @radcortez yes, actually (in our company) we would like to advocate the use of @Inject and @Named (instead of @Autowired and @Component)
    so, the applications are not tightly coupled to any specific framework
    therefore our search to make @ConfigProperty Spring ' compatible'
    Roberto Cortez
    @radcortez
    thats great, probably a MP Config intregration may requires some additional pieces
    Duncan
    @dabloem
    of course I am willing to contribute
    Roberto Cortez
    @radcortez
    Duncan
    @dabloem
    exactly
    Roberto Cortez
    @radcortez
    a lot of that are actually validations before doing the injection
    Emily Jiang
    @Emily-Jiang
    Spring already supports @Inject etc. It will be good to get MP Config APIs work on spring boot apps
    Duncan
    @dabloem
    okay, I will make our sources public, see if there are any additional validations to add.