Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Felix Wong
    @fmhwong
    @pavolloffay will you join the call today?
    Felix Wong
    @fmhwong
    @pavolloffay I have been trying out MicroProfile OpenTracing on Quarkus. I have 2 services. The first service will use a JAX-RS client to call the second service. However, I saw the server span but not the client span to the 2nd service. Do you have any tip on how to debug?
    Pavol Loffay
    @pavolloffay
    Hi @fmhwong, it's maybe a configuration issue. I suggest following the quarkus quickstart or you can have a look at my repository https://github.com/pavolloffay/quarkus-tracing
    Felix Wong
    @fmhwong
    @pavolloffay Are you planning to create a release 1.3.2 to address #165? Do we need to revert PR#162?
    Pavol Loffay
    @pavolloffay
    yes I do, we can create a branch just before that commit and continue fom there
    Felix Wong
    @fmhwong
    We need to port the fix back to 1.0, 1.1 and 1.2 too as OpenLiberty is still running those TCKs.
    I can help the backport.
    Pavol Loffay
    @pavolloffay
    Do you want to submit a fix?
    Felix Wong
    @fmhwong
    I can. Do you want to use the fix suggested in #165?
    Pavol Loffay
    @pavolloffay
    I haven't looked closely, does a new version of shrinkwrap uses HTTP? Then we could simply just update it
    Felix Wong
    @fmhwong
    Shrinkwrap resolver 3.0 has changed the default to https. However, latest Arquillian 1.5.0.Final is still picking up resolver 2.2.6.
    Pavol Loffay
    @pavolloffay
    I am more in favor of using a default behavior then overriding old dep to fix it
    Felix Wong
    @fmhwong
    agree
    Felix Wong
    @fmhwong
    Pavol Loffay
    @pavolloffay
    would you like to submit a PR to fix it? We should identify how long it will take to fix the issue and release arquillian . This might take longer
    Pavol Loffay
    @pavolloffay
    @fmhwong I have released 1.3.2 with the fix
    Pavol Loffay
    @pavolloffay
    could you please submit backport PR to 1.1 and 1.0 branches?
    Pavol Loffay
    @pavolloffay
    I have also released 1.2.2
    Pavol Loffay
    @pavolloffay
    We need the fix also in the master
    Felix Wong
    @fmhwong
    @pavolloffay Thanks for creating 1.2.2 and 1.3.2. Will backport the fix to 1.0 and 1.1
    Felix Wong
    @fmhwong
    Pavol Loffay
    @pavolloffay
    merged and released
    Felix Wong
    @fmhwong
    :thumbsup:
    Pavol Loffay
    @pavolloffay
    I will have to cancel tomorrow's meeting, I am traveling to a conference
    Can we move it to the next week?
    Felix Wong
    @fmhwong
    I have a conflict on Jan 29 4pm GMT. I am available on 3pm GMT.
    Emily Jiang
    @Emily-Jiang
    For @Inject Tracer tracer, is there a spi version to get hold of the tracer object?
    @pavolloffay @fmhwong
    Pavol Loffay
    @pavolloffay
    what do you mean by hold?
    Tracer is just a CDI bean, maybe CDI provides API/SPI to your use-case
    Emily Jiang
    @Emily-Jiang
    I meant whether there is a way to directly get Tracer without using CDI. e.g. calling directly Open Tracing APIs
    Pavol Loffay
    @pavolloffay
    No, although at Red Hat projects it's possible to call static GlobalTracer.get()
    Emily Jiang
    @Emily-Jiang
    Thanks @pavolloffay !
    That is the way I thought it might work. I will give it a go.
    Pavol Loffay
    @pavolloffay
    np, the only requirement is to register the tracer to the global tracer.
    we do this in our runtimes platforms
    Emily Jiang
    @Emily-Jiang
    ok. thanks @pavolloffay !
    Pavol Loffay
    @pavolloffay
    @fmhwong will you need release of all version with the fix you did?
    also could you please review eclipse/microprofile-opentracing#177
    Felix Wong
    @fmhwong
    @pavolloffay It will be great if you can create a new service release for all versions. I also reviewed the changes in #177.
    In #162, you changed the return type of httpStatus from int to BigDecimal. I think you were trying to remove the dependency of Jackson. What set of new dependencies do you recommend to run the TCK in master now?
    Pavol Loffay
    @pavolloffay
    any JSON-B implementation
    Pavol Loffay
    @pavolloffay
    @fmhwong please apply the patch also to master branch
    Do you have any other changes in your queue which will require release?
    Felix Wong
    @fmhwong
    I will make a PR for master. I don't have any other changes in the 1.0-1.3 branches.
    Pavol Loffay
    @pavolloffay
    ack I will cut the patch releases tomorrow
    Felix Wong
    @fmhwong
    :thumbsup: