Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Andy McCright
    @andymc12
    @kenfinnigan thanks for opening issue #186. Should we plan on this being part of 1.3 or a future release?
    Ken Finnigan
    @kenfinnigan
    If possible 1.3, but depends on whether my ideas around how to test it are accurate or not
    If they are, then shouldn't be too hard to adjust
    if not, would likely take longer
    Andy McCright
    @andymc12
    cool, that sounds good. I'll go ahead and tag it for 1.3 for now
    Ken Finnigan
    @kenfinnigan
    @andymc12 can you recall what the use case was for adding the AsyncInvocationInterceptor?
    Ken Finnigan
    @kenfinnigan
    nevermind, modified the text in spec around it how I thought made sense
    Michał Szynkiewicz
    @michalszynkiewicz
    @andymc12 @kenfinnigan thank you guys for the review! I will do a rework tomorrow
    Michał Szynkiewicz
    @michalszynkiewicz
    reworked
    Andy McCright
    @andymc12
    @michalszynkiewicz looks good to me. @kenfinnigan do you want to take another look at the SSL changes? #187
    Ken Finnigan
    @kenfinnigan
    Looks fine
    Michał Szynkiewicz
    @michalszynkiewicz
    @andymc12 @kenfinnigan hi, we have a public holiday tomorrow and I won't be able to make the meeting
    Andy McCright
    @andymc12

    @michalszynkiewicz no worries - enjoy your time off!

    @kenfinnigan do you still want to meet tomorrow?

    I'm thinking that if we can merge #187 today, then I can produce a release candidate. we probably won't need the meeting then since the RC will not yet be in Maven Central (it usually takes a day or two). once in the Maven servers, then we'll likely have more to discuss as we run into issues with compatible implementations of the RC. What do you think?

    Ken Finnigan
    @kenfinnigan
    I’m fine with no meeting
    Andy McCright
    @andymc12
    sounds good - I'll go ahead and cancel. are you ok with my proposed changes to #187? (changing .addAsManifestResource(new StringAsset(config), "microprofile-config.properties") to .addAsWebInfResource(new StringAsset(config), "classes/META-INF/microprofile-config.properties") ? If so, I can do that in a separate PR
    Ken Finnigan
    @kenfinnigan
    Will check shortly
    Michał Szynkiewicz
    @michalszynkiewicz
    @kenfinnigan @andymc12 thanks for the explanation on config file location
    @andymc12 I can rework the PR today evening but if you have the changes already done locally, I'm okay with pushing as it is and letting you push your changes on top of that ;)
    Andy McCright
    @andymc12
    @michalszynkiewicz I'll go ahead and make the changes separately. Enjoy your time off! :)
    Michał Szynkiewicz
    @michalszynkiewicz
    thanks !
    Ken Finnigan
    @kenfinnigan
    @andymc12 are we cancelling tomorrows call?
    Andy McCright
    @andymc12
    @kenfinnigan yes - I'll delete the calendar entry
    Ken Finnigan
    @kenfinnigan
    thanks
    Ken Finnigan
    @kenfinnigan
    @andymc12 an FYI that I won't be able to attend the meeting this week
    Andy McCright
    @andymc12
    @kenfinnigan no problem. the main thing is just to decide whether we're ok with releasing a 1.3 final release. are you ok with releasing?
    Ken Finnigan
    @kenfinnigan
    I think so yes
    Andy McCright
    @andymc12
    cool. I'll check with @michalszynkiewicz (either here or on the call tomorrow). I think we still have to wait until at least tomorrow or Thursday to give folks 7 days to experiment with RC1
    Michał Szynkiewicz
    @michalszynkiewicz
    @andymc12 hi, I'm okay with releasing. I cannot attend today's meeting, I fell sick :(
    James Carman
    @jwcarman
    Is the meeting open to the public?
    Ken Finnigan
    @kenfinnigan
    @jwcarman it’s open to anyone interested in participating
    James Carman
    @jwcarman
    How do I find out details on joining?
    Ken Finnigan
    @kenfinnigan
    All the meetings are present in the MP calendar
    Don’t have a link handy, but should be able to find it from MP page at Eclipse
    James Carman
    @jwcarman
    ok, I'm poking around, but it's not jumping out at me. I've tried the "join the discussion" link, but that goes to the google group. Contributors just lists everyone's names/faces.
    I don't see the term "meeting"
    I'm looking here: https://microprofile.io/
    James Carman
    @jwcarman
    The site does look nice, though :)
    found it!
    James Carman
    @jwcarman
    Thanks, @kenfinnigan !
    Andy McCright
    @andymc12
    @michalszynkiewicz I'm running into a problem with the SSL TCK tests that I wonder if you could help me with. I am failing on the tests where the Jetty server uses a trust store - they all fail with the same exception - the exception stack trace and a standalone Java test class is available here: https://gist.github.com/andymc12/25e7a4e445a1bc7e284717b3c1bf6f9a
    Derek P. Moore
    @derekm
    I ran into a need for MP Rest Client to honor the JAX-RS multipart annotations
    Has this been considered yet?
    Derek P. Moore
    @derekm
    Also, having browser-style cache consistency in MP Rest Client would be really nice! Automatic issuance of HEAD requests, honoring of the Cache-Control header, etc. would enable certain projects to remove a bunch of manual caching.
    Andy McCright
    @andymc12

    @derekm

    I ran into a need for MP Rest Client to honor the JAX-RS multipart annotations

    Which annotations? I think multipart support is not yet in the JAX-RS spec (iiuc, it is proposed in a future version of Jakarta JAX-RS). I think most vendors support it, but using custom approaches.

    Also, having browser-style cache consistency in MP Rest Client would be really nice! Automatic issuance of HEAD requests, honoring of the Cache-Control header, etc. would enable certain projects to remove a bunch of manual caching.

    Can you open GitHub issues for these? They sound reasonable to me.

    Derek P. Moore
    @derekm
    Oh yeah, I guess I'm using Jersey's org.glassfish.jersey.media.multipart.FormDataParam
    Andy McCright
    @andymc12
    @michalszynkiewicz have you had a chance to look into the SSL TCKs tests I mentioned? are they failing for you? we may need to exclude those tests in order to have a compatible implementation that passes the TCK in order to release by Wednesday
    Andy McCright
    @andymc12
    @kenfinnigan are you ok with excluding these tests in order to get the release out? (I think otherwise, we end up missing the June release train). we could always add the tests back in a 1.3.1 release once we figure out what is wrong with them
    Ken Finnigan
    @kenfinnigan
    @andymc12 I'm not familiar with the SSL tests to judge that. Maybe it's worth asking on the ML to get a wider perspective?