Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Michał Szynkiewicz
    @michalszynkiewicz
    @kenfinnigan @andymc12 thanks for the explanation on config file location
    @andymc12 I can rework the PR today evening but if you have the changes already done locally, I'm okay with pushing as it is and letting you push your changes on top of that ;)
    Andy McCright
    @andymc12
    @michalszynkiewicz I'll go ahead and make the changes separately. Enjoy your time off! :)
    Michał Szynkiewicz
    @michalszynkiewicz
    thanks !
    Ken Finnigan
    @kenfinnigan
    @andymc12 are we cancelling tomorrows call?
    Andy McCright
    @andymc12
    @kenfinnigan yes - I'll delete the calendar entry
    Ken Finnigan
    @kenfinnigan
    thanks
    Ken Finnigan
    @kenfinnigan
    @andymc12 an FYI that I won't be able to attend the meeting this week
    Andy McCright
    @andymc12
    @kenfinnigan no problem. the main thing is just to decide whether we're ok with releasing a 1.3 final release. are you ok with releasing?
    Ken Finnigan
    @kenfinnigan
    I think so yes
    Andy McCright
    @andymc12
    cool. I'll check with @michalszynkiewicz (either here or on the call tomorrow). I think we still have to wait until at least tomorrow or Thursday to give folks 7 days to experiment with RC1
    Michał Szynkiewicz
    @michalszynkiewicz
    @andymc12 hi, I'm okay with releasing. I cannot attend today's meeting, I fell sick :(
    James Carman
    @jwcarman
    Is the meeting open to the public?
    Ken Finnigan
    @kenfinnigan
    @jwcarman it’s open to anyone interested in participating
    James Carman
    @jwcarman
    How do I find out details on joining?
    Ken Finnigan
    @kenfinnigan
    All the meetings are present in the MP calendar
    Don’t have a link handy, but should be able to find it from MP page at Eclipse
    James Carman
    @jwcarman
    ok, I'm poking around, but it's not jumping out at me. I've tried the "join the discussion" link, but that goes to the google group. Contributors just lists everyone's names/faces.
    I don't see the term "meeting"
    I'm looking here: https://microprofile.io/
    James Carman
    @jwcarman
    The site does look nice, though :)
    found it!
    https://github.com/eclipse/microprofile-rest-client/blob/master/CONTRIBUTING.adoc
    James Carman
    @jwcarman
    Thanks, @kenfinnigan !
    Andy McCright
    @andymc12
    @michalszynkiewicz I'm running into a problem with the SSL TCK tests that I wonder if you could help me with. I am failing on the tests where the Jetty server uses a trust store - they all fail with the same exception - the exception stack trace and a standalone Java test class is available here: https://gist.github.com/andymc12/25e7a4e445a1bc7e284717b3c1bf6f9a
    Derek P. Moore
    @derekm
    I ran into a need for MP Rest Client to honor the JAX-RS multipart annotations
    Has this been considered yet?
    Derek P. Moore
    @derekm
    Also, having browser-style cache consistency in MP Rest Client would be really nice! Automatic issuance of HEAD requests, honoring of the Cache-Control header, etc. would enable certain projects to remove a bunch of manual caching.
    Andy McCright
    @andymc12

    @derekm

    I ran into a need for MP Rest Client to honor the JAX-RS multipart annotations

    Which annotations? I think multipart support is not yet in the JAX-RS spec (iiuc, it is proposed in a future version of Jakarta JAX-RS). I think most vendors support it, but using custom approaches.

    Also, having browser-style cache consistency in MP Rest Client would be really nice! Automatic issuance of HEAD requests, honoring of the Cache-Control header, etc. would enable certain projects to remove a bunch of manual caching.

    Can you open GitHub issues for these? They sound reasonable to me.

    Derek P. Moore
    @derekm
    Oh yeah, I guess I'm using Jersey's org.glassfish.jersey.media.multipart.FormDataParam
    Andy McCright
    @andymc12
    @michalszynkiewicz have you had a chance to look into the SSL TCKs tests I mentioned? are they failing for you? we may need to exclude those tests in order to have a compatible implementation that passes the TCK in order to release by Wednesday
    Andy McCright
    @andymc12
    @kenfinnigan are you ok with excluding these tests in order to get the release out? (I think otherwise, we end up missing the June release train). we could always add the tests back in a 1.3.1 release once we figure out what is wrong with them
    Ken Finnigan
    @kenfinnigan
    @andymc12 I'm not familiar with the SSL tests to judge that. Maybe it's worth asking on the ML to get a wider perspective?
    Andy McCright
    @andymc12
    will do (ML == mailing list == Google Group?)
    Andy McCright
    @andymc12
    posted at https://groups.google.com/d/msg/microprofile/PrBimgpQR7Y/t--kheTyAgAJ
    Michał Szynkiewicz
    @michalszynkiewicz
    @andymc12 hi Andy, I was on sick leave last week and didn't notice your message, sorry
    checking now
    Michał Szynkiewicz
    @michalszynkiewicz
    SslMutualTest works for me with 1.3.RC1
    but in SmallRye we don't have the other features implemented yet
    SmallRye uses a newer wiremock version, and jetty version (jetty 9.2.26.v20180806) :(
    this may be the difference, let me check the test with the old wiremock
    Michał Szynkiewicz
    @michalszynkiewicz
    hmm... still works with the older wiremock/jetty pair
    @andymc12 the only thing that I did in SmallRye to pass the test was adding the keystore with password to the resteasy client builder:
    resteasyClientBuilder.keyStore(keyStore, keystorePassword);
    Michał Szynkiewicz
    @michalszynkiewicz
    could you send me a piece of your maven dependency tree with jetty dependencies?
    this is what I have https://gist.github.com/michalszynkiewicz/3597f56d02b389467876b64899d467f4
    Andy McCright
    @andymc12
    Just an update for the rest of the room (Michal and I were chatting privately to avoid spamming the room) - it looks like the problem is with Jetty. We're not sure what regressed exactly, but it seems like the latest version of Jetty (9.4.18.v20190429) is failing but a slightly older version (9.4.14.v20181114) passes - Michal confirmed that it works for SmallRye and CXF. I'm in the process of updating the version in CXF. Thanks @michalszynkiewicz for all the hard work and investigation!
    Ken Finnigan
    @kenfinnigan
    Thanks @michalszynkiewicz
    Ken Finnigan
    @kenfinnigan
    @andymc12 @michalszynkiewicz do we have agenda items for a meeting today?
    Michał Szynkiewicz
    @michalszynkiewicz
    @kenfinnigan maybe celebrate the release? ;)