Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    James Carman
    @jwcarman
    found it!
    Thanks, @kenfinnigan !
    Andy McCright
    @andymc12
    @michalszynkiewicz I'm running into a problem with the SSL TCK tests that I wonder if you could help me with. I am failing on the tests where the Jetty server uses a trust store - they all fail with the same exception - the exception stack trace and a standalone Java test class is available here: https://gist.github.com/andymc12/25e7a4e445a1bc7e284717b3c1bf6f9a
    Derek P. Moore
    @derekm
    I ran into a need for MP Rest Client to honor the JAX-RS multipart annotations
    Has this been considered yet?
    Derek P. Moore
    @derekm
    Also, having browser-style cache consistency in MP Rest Client would be really nice! Automatic issuance of HEAD requests, honoring of the Cache-Control header, etc. would enable certain projects to remove a bunch of manual caching.
    Andy McCright
    @andymc12

    @derekm

    I ran into a need for MP Rest Client to honor the JAX-RS multipart annotations

    Which annotations? I think multipart support is not yet in the JAX-RS spec (iiuc, it is proposed in a future version of Jakarta JAX-RS). I think most vendors support it, but using custom approaches.

    Also, having browser-style cache consistency in MP Rest Client would be really nice! Automatic issuance of HEAD requests, honoring of the Cache-Control header, etc. would enable certain projects to remove a bunch of manual caching.

    Can you open GitHub issues for these? They sound reasonable to me.

    Derek P. Moore
    @derekm
    Oh yeah, I guess I'm using Jersey's org.glassfish.jersey.media.multipart.FormDataParam
    Andy McCright
    @andymc12
    @michalszynkiewicz have you had a chance to look into the SSL TCKs tests I mentioned? are they failing for you? we may need to exclude those tests in order to have a compatible implementation that passes the TCK in order to release by Wednesday
    Andy McCright
    @andymc12
    @kenfinnigan are you ok with excluding these tests in order to get the release out? (I think otherwise, we end up missing the June release train). we could always add the tests back in a 1.3.1 release once we figure out what is wrong with them
    Ken Finnigan
    @kenfinnigan
    @andymc12 I'm not familiar with the SSL tests to judge that. Maybe it's worth asking on the ML to get a wider perspective?
    Andy McCright
    @andymc12
    will do (ML == mailing list == Google Group?)
    Michał Szynkiewicz
    @michalszynkiewicz
    @andymc12 hi Andy, I was on sick leave last week and didn't notice your message, sorry
    checking now
    Michał Szynkiewicz
    @michalszynkiewicz
    SslMutualTest works for me with 1.3.RC1
    but in SmallRye we don't have the other features implemented yet
    SmallRye uses a newer wiremock version, and jetty version (jetty 9.2.26.v20180806) :(
    this may be the difference, let me check the test with the old wiremock
    Michał Szynkiewicz
    @michalszynkiewicz
    hmm... still works with the older wiremock/jetty pair
    @andymc12 the only thing that I did in SmallRye to pass the test was adding the keystore with password to the resteasy client builder:
    resteasyClientBuilder.keyStore(keyStore, keystorePassword);
    Michał Szynkiewicz
    @michalszynkiewicz
    could you send me a piece of your maven dependency tree with jetty dependencies?
    Andy McCright
    @andymc12
    Just an update for the rest of the room (Michal and I were chatting privately to avoid spamming the room) - it looks like the problem is with Jetty. We're not sure what regressed exactly, but it seems like the latest version of Jetty (9.4.18.v20190429) is failing but a slightly older version (9.4.14.v20181114) passes - Michal confirmed that it works for SmallRye and CXF. I'm in the process of updating the version in CXF. Thanks @michalszynkiewicz for all the hard work and investigation!
    Ken Finnigan
    @kenfinnigan
    Thanks @michalszynkiewicz
    Ken Finnigan
    @kenfinnigan
    @andymc12 @michalszynkiewicz do we have agenda items for a meeting today?
    Michał Szynkiewicz
    @michalszynkiewicz
    @kenfinnigan maybe celebrate the release? ;)
    Ken Finnigan
    @kenfinnigan
    you have champagne handy? ;-)
    Michał Szynkiewicz
    @michalszynkiewicz
    nope, but a convenience store with beer is not far away
    I don't have any items to discuss
    Ken Finnigan
    @kenfinnigan
    neither do i
    will wait for @andymc12
    Andy McCright
    @andymc12
    Nothing on my list but to celebrate! We can cancel today’s meeting.
    Andy McCright
    @andymc12

    Hey @kenfinnigan - was talking with Emily Jiang, and she was saying that by adding a hard dependency on JSON-B (which is an EE8 technology) in MP Rest Client, we should've made that a major version upgrade (2.0 instead of 1.3). The specific text in question is Implementations must provide built-in JSON-P and JSON-B entity providers.. In 1.2, we had this text (essentially making JSON-B optional): Implementations must provide a built-in JSON-P entity provider. If the implementation supports JSON-B, then it must also provide a built-in JSON-B entity provider.

    Would you be ok with releasing a 1.3.1 reverting that language?

    Ken Finnigan
    @kenfinnigan
    @andymc12 sounds ok
    Andy McCright
    @andymc12
    cool, thanks - I'll make the change a little later today. thanks!
    Ken Finnigan
    @kenfinnigan
    I don't have anything for the call on Wednesday
    Andy McCright
    @andymc12
    Me neither. I think the next thing to do is start planning for the next release (1.4 or 2.0), but I think we can wait a week or two yet.
    Ken Finnigan
    @kenfinnigan
    Sounds good
    Andy McCright
    @andymc12
    @michalszynkiewicz - we're planning to cancel today's meeting. We will probably cancel next week too unless something comes up. Have a good week!
    Derek P. Moore
    @derekm
    btw, I posted eclipse/microprofile-rest-client#201 about cache consistency in MP Rest Client
    Andy McCright
    @andymc12
    @derekm thanks - I'll take a look today now that I'm back in the office.
    @kenfinnigan @michalszynkiewicz is there anything urgent that you want to discuss today? If not, I'll go ahead and cancel today's meeting.
    Ken Finnigan
    @kenfinnigan
    I don't have anything
    Andy McCright
    @andymc12
    ok, I'll go ahead and cancel it. Thanks!
    Ken Finnigan
    @kenfinnigan
    FYI. I’m likely not attending these calls going forward. The implementation has been moved into RESTEasy directly, so the team working on that will look to begin attending
    Andy McCright
    @andymc12
    @kenfinnigan sorry to see you leave. on a similar topic, I was kinda thinking that this project might be a good one to go "full async" as has been discussed in the community hangout / google groups.
    Ken Finnigan
    @kenfinnigan
    I think that makes sense