Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Emily Jiang
    @Emily-Jiang
    3pm Belgium, 4pm France time @rdebusscher @Karm
    Michal Karm Babacek
    @Karm
    Both 3pm and 4pm UTC+02:00 are fine by me ATM.
    Emily Jiang
    @Emily-Jiang
    @rdebusscher what about you?
    Rudy De Busscher
    @rdebusscher
    4PM UTC+02:00 for a short meeting is ok for me.
    Emily Jiang
    @Emily-Jiang
    I have reschedule to 4pm UK time for half an hour and also sent you an invitation. Talk to you later. thanks
    Rudy De Busscher
    @rdebusscher
    I have a customer meeting at 4 PM UK time and can't join.
    regarding ref property for OpenAPI document. I'll check if using ref only works (and removing other properties)
    But it seems a TCK test is missing is ref is not allowed with other properties.
    Emily Jiang
    @Emily-Jiang
    The spec says non-portable behaviour occurs
    for that combination
    Not sure whether you need a tck for that
    @Karm are you around now? how about moving our meeting to tomorrow but keep the same timeslot? 2:00pm for UK, Belgium and 3pm for France
    @rdebusscher @Karm ^^
    Michal Karm Babacek
    @Karm
    @Emily-Jiang I am around, can chat, but I can't talk. Tomorrow is fine for sound too for me.
    Rudy De Busscher
    @rdebusscher

    The spec says non-portable behaviour occurs for that combination
    Not sure whether you need a tck for that

    Ok, but then it is no surprise that we have differences between the implementations. And examples must be different according to each runtime (as my PR)

    I'm off for the rest of the week, so unable to make it tomorrow.
    Emily Jiang
    @Emily-Jiang

    The spec says non-portable behaviour occurs for that combination
    Not sure whether you need a tck for that

    Ok, but then it is no surprise that we have differences between the implementations. And examples must be different according to each runtime (as my PR)

    My point is that the starter is supposed to show best practices not using the undetermined behaviour, which is very confusing. I prefer not to use ref and implementation as it is a bad practice

    Emily Jiang
    @Emily-Jiang
    @Karm I will meet with you in 2hours
    Michal Karm Babacek
    @Karm
    @Emily-Jiang Joining in 2m
    Emily Jiang
    @Emily-Jiang
    meeting time @Karm @rdebusscher
    Emily Jiang
    @Emily-Jiang
    ah, I see. It makes sense now. I think we can document the files to be updated when supporting the new MP versions
    thanks @rdebusscher
    Michal Karm Babacek
    @Karm
    Automatic message: Hello, new build has started.
    Michal Karm Babacek
    @Karm
    Automatic message: Hello, new build is live on https://test-start.microprofile.io/
    Emily Jiang
    @Emily-Jiang
    @rdebusscher eclipse/microprofile-starter#414 done the changes and tested against payara, wildfly and they are fine as well. It is a standard pattern recommended by the spec. Once we merge this one, we can release mp starter
    Emily Jiang
    @Emily-Jiang
    @rdebusscher can you approve the #414 so that we can merge in and prepare for the release?
    Michal Karm Babacek
    @Karm
    Automatic message: Hello, new build has started.
    Michal Karm Babacek
    @Karm
    Automatic message: Hello, new build is live on https://test-start.microprofile.io/
    Emily Jiang
    @Emily-Jiang
    @Karm @rdebusscher I have a clash for today's call. Are you ok to move today's call 30min earlier? I think we just need to release microprofile starter. what do you all think?
    Rudy De Busscher
    @rdebusscher
    ok for me (is even better for me this week)
    Michal Karm Babacek
    @Karm
    I can join for a while and I could handle the release in the late evening UTC+2, but I am engaged otherwise :-|
    Emily Jiang
    @Emily-Jiang
    okay, talk to you shortly. Hopefully it won't last long
    I've started the call
    @rdebusscher @Karm are you joining?
    Michal Karm Babacek
    @Karm
    @Emily-Jiang As soon as the kid falls asleep I tag & release 1.6 tonight....
    Michal Karm Babacek
    @Karm
    1.6.0 is live on https://start.microprofile.io/ and it seems fine.
    Emily Jiang
    @Emily-Jiang
    @Karm thank you so much! Awesome!
    Emily Jiang
    @Emily-Jiang
    I just realised that it is bank holiday Monday next week, so I won't be able to attend the call. @Karm @rdebusscher do you want to meet? If not, we can cancel the call?
    Rudy De Busscher
    @rdebusscher
    No need to have a meeting I think. If I have any feedback on the Gradle testing, I'll post it here.
    Michal Karm Babacek
    @Karm
    +1
    Rudy De Busscher
    @rdebusscher
    Gradle tests are ok. There is now only an issue due to the usage of Commons3.Tuple to have that executable flag. It doesn't implement equals and hashcode correct which means that overriding a file in the archive does not work anymore. (and incorrect code is places in service-a and service-b).
    I'm working on a solution.
    Not sure I can attend this afternoon due to a meeting
    Rudy De Busscher
    @rdebusscher
    The Commons3.Tuple problem with equals and hashcode was not the cause (it was a coincidence it was on a 'redefined' file.) It was with alternative management within Gradle.
    Emily Jiang
    @Emily-Jiang
    I have a clash as well today. Let's cancel today's call then
    Thank @rdebusscher for the update on Gradle
    do you need any help?
    Rudy De Busscher
    @rdebusscher
    No everything is good. PR is up for final review and merge.
    Emily Jiang
    @Emily-Jiang
    @rdebusscher I reviewd your PR and added some comments