Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Feb 01 12:33
    anthonycrumley closed #688
  • Feb 01 12:33
    anthonycrumley closed #687
  • Jan 21 12:43

    anthonycrumley on master

    Fix potential vulnerabilities Merge pull request #691 from an… (compare)

  • Jan 21 12:43
    anthonycrumley closed #691
  • Jan 17 12:57
    anthonycrumley synchronize #691
  • Jan 17 12:50
    anthonycrumley synchronize #691
  • Jan 17 12:39
    anthonycrumley opened #691
  • Jan 15 12:11
    anthonycrumley assigned #690
  • Jan 15 12:04
    anthonycrumley commented #689
  • Jan 15 12:03

    anthonycrumley on master

    Fixed Inconsistent Placeholder … Fix Inconsistent Placeholder Te… Fix Inconsistent Placeholder Te… and 4 more (compare)

  • Jan 15 12:03
    anthonycrumley closed #689
  • Jan 13 07:29
    Trevonte commented #689
  • Jan 13 06:50
    Trevonte synchronize #689
  • Jan 08 12:51
    anthonycrumley edited #690
  • Jan 08 12:50
    anthonycrumley edited #690
  • Jan 08 12:37
    anthonycrumley opened #690
  • Jan 07 03:41
    Trevonte commented #689
  • Jan 07 03:41
    Trevonte reopened #689
  • Jan 07 03:41
    Trevonte closed #689
  • Jan 07 03:41
    Trevonte commented #689
Anthony Crumley
@anthonycrumley
Chatup: @Trevonte Worked on a defect for sending emails to Event contacts, documented the development process for branching when doing new work and created two new issues for you to work on.
@Trevonte I have created two new issues, #687 and #688, that are now assigned to you. Please follow the instructions for branching on this wiki page (https://github.com/edbirmingham/network/wiki/Development-Process) to create a branch for each of the issues with the fix in that branch. Branching becomes more important as you work on more issues and get to a place where you have code for more than one issue waiting to be merged at a time.
Anthony Crumley
@anthonycrumley
@Trevonte Here is an article that gives some reasoning for why branching is needed on software projects. https://www.git-tower.com/learn/git/ebook/en/command-line/branching-merging/branching-can-change-your-life
Anthony Crumley
@anthonycrumley
@Trevonte Also, here is an article about writing good commit messages. https://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html
Trevonte
@Trevonte
@anthonycrumley When adding the line "<p class="text-right"><%= page_entries_info @members %></p>" to display members. I get the error "undefined method `size' for nil:NilClass". I tried adding a few lines of code and changing the added line of code as well, but I'm getting nowhere.
Anthony Crumley
@anthonycrumley
@Trevonte The page_entries_info method is creating the text "Displaying members 1-25 of 6594 in total" based on the data in the variable @members on the Members index view. On the Members page that variable contains an Array of Member model objects that were queried from the database. This variable was set in the MembersController#index action. There is a similar variable beginning with the @ symbol in the index view for Events, Actions and Tasks as well, except it has a different name than @members. This other @ variable needs to be substituted for @members on each of the other index views.
Trevonte
@Trevonte
@anthonycrumley Thank you! Successfully created a pull request for fixes on pagination information on the "Events", "Tasks", and "Actions" pages. Also fixed the inconsistent text on "Filter by..." on the "Actions" and "Members" page. Currently, no blocking issues.
Trevonte
@Trevonte
Merry Christmas to all 🎄
Anthony Crumley
@anthonycrumley
@Trevonte Very belated Merry Christmas!!
@Trevonte I added a comment to the pull request.
Trevonte
@Trevonte
@anthonycrumley Read your comment and added a 2nd commit with Page Entry info code rearranged above "<div class="table responsive">". Please let me know if there are any issues I need to fix. Currently, no blocking issues.
Anthony Crumley
@anthonycrumley
@Trevonte I added a couple of more comments to the pull request.
Trevonte
@Trevonte
@anthonycrumley I mistakenly closed the pull request for "Fix Inconsistent Placeholder Text and Add Pagination Info". I believed I re-opened it, and with that I added the link for pagination at the bottom of the "Actions" page as well as indented the two "end" lines of code in a 4th commit that hopefully fixed everything.
Anthony Crumley
@anthonycrumley
@Trevonte Yes, the pull request was reopened. While testing, a couple more issues were found and commented on.
Trevonte
@Trevonte
@anthonycrumley The Ed Network page that I'm previewing is unresponsive so I cannot log in. Are you experiencing the same issues?
Anthony Crumley
@anthonycrumley
PaginationLinks.png
@Trevonte Are you trying to look at the url in this screen shot?
If so, that is my development environment and other people can't access that link.
Anthony Crumley
@anthonycrumley
If this is what is happening then you would need to look at the same page in your development environment. To get pagination to work, several things can be done. To make this screen shot I added .per(1) to filtered_network_actions.page(params[:page]).per(1). I did this to test but don't recommend it for development because it is easy to accidentally commit it and break the page when it is deployed. I recommend creating more than 25 actions in the db/seeds.rb file. An action is created on line 242 of db/seeds.rb as an example of how to do it. I would add an each like the one on line 288 and create about 30 actions, something like this (1..30).each do |i|. The variable i can be used in the action description to give each action a unique name like it is used on line 290 to make each member first name different. This seeds file change should be committed too so that other developers in the future will have enough actions in their data to see the pagination. Then rake db:reset will need to be ran to create the new seed data. At this point, you should be able to see the pagination links.
More than 25 actions need to be created because that is the default page size for pagination.
Anthony Crumley
@anthonycrumley
@Trevonte Now that I am trying to access my Cloud9 environment, my preview is unresponsive too. I have another cloud9 environment for a separate project and it is unresponsive as well. It may be an AWS problem.
I have not seen it act like this before.
Anthony Crumley
@anthonycrumley
This problem seems to be affecting Chrome but it working for me in Firefox.
Anthony Crumley
@anthonycrumley
I posted a question about this to the AWS Cloud9 forum.
Anthony Crumley
@anthonycrumley
@Trevonte As I googled about this problem, people keep saying it was a problem with Chrome extensions. It turned out to be the grammarly extension for me. I kept turning them off until I found the one that fixed it.
Trevonte
@Trevonte
@anthonycrumley Thank you, I'll look into my Chrome extensions as well and get right back to solving the issues as soon as possible!
Trevonte
@Trevonte
@anthonycrumley I'm having trouble when attempting to push the commit for the fixes you requested. It says that "! [rejected] Updates -> Updates (non-fast-forward)" with some hints below it. I'm sending a screenshot with the issue circled in red.
ComputerScreenshot.png
Anthony Crumley
@anthonycrumley
@Trevonte I would try doing git pull origin Updates.
Trevonte
@Trevonte
@anthonycrumley I pushed 2 commits yesterday that should
have fixed the issues. Please do report any problems that you may have with them.
Anthony Crumley
@anthonycrumley
@Trevonte Everything was working correctly. It has been merged and released.
@Trevonte Here is the next issue for you to work on. Please let me know if you have any questions. edbirmingham/network#690
Trevonte
@Trevonte
@anthonycrumley My laptop's battery is having issues at the moment, and I've ordered a replacement for it. It'll take me a bit longer to fix the issues as of now. Sorry for the inconvenience!
Anthony Crumley
@anthonycrumley
@Trevonte I hope it all works out well.
Anthony Crumley
@anthonycrumley
@Trevonte How is your laptop coming along?
Trevonte
@Trevonte
@anthonycrumley I installed the new battery so I think it may be in an okay shape. Turns out that the inside of my laptop was also dusty so my fan wasn't running as fast it needed to to keep my CPU cool. I used compressed air to clean it out. Hopefully it doesn't shut off on me while I'm fixing the issue.
Trevonte
@Trevonte
@anthonycrumley Having issues using 'bundle exec rake db:migrate' for the 'AddEncryptionToUsers' file. Receiving the errors: 'rake aborted!
StandardError: An error has occurred, this and all later migrations canceled:' and 'PG::DuplicateColumn: ERROR: column "encrypted_otp_secret_key" of relation "users" already exists
: ALTER TABLE "users" ADD "encrypted_otp_secret_key" character varying'. How can I fix this issue?
Image.png
Anthony Crumley
@anthonycrumley
@Trevonte Those fields are already in the database. They can be seen in db/schema.rb. I believe this migration file is generated by the two_factor_authentication gem. I generated and ran that migration when we added two factor authentication to the application. Therefore, I think this generated migration file should just be deleted.
Anthony Crumley
@anthonycrumley
@Trevonte How is it coming along?
Trevonte
@Trevonte
@anthonycrumley We may have to schedule a skype call. Give me 1 more day on this, I try my best to work things out before asking for assistance.
Anthony Crumley
@anthonycrumley
@Trevonte Hey, was you able to work through the problems you were having?
Trevonte
@Trevonte
@anthonycrumley No sir, still having issues unfortunately.
Anthony Crumley
@anthonycrumley
@Trevonte When are some times that you would be able to have a skype call?
Trevonte
@Trevonte
Tomorrow possibly around 2PM or 3PM, today is a busy day. Is that okay?
Anthony Crumley
@anthonycrumley
@Trevonte That sounds good.
Anthony Crumley
@anthonycrumley
@Trevonte 3pm is better for me today.
Trevonte
@Trevonte
@anthonycrumley Thats good.