Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Oct 12 19:34

    ehmicky on master

    Upgrade @ehmicky/dev-tasks 0.30… (compare)

  • Oct 12 19:31

    ehmicky on master

    Upgrade chalk 3.0.0-beta.1 -> 3… Upgrade execa 2.0.5 -> 2.1.0 Upgrade lolex 4.2.0 -> 5.0.0 (compare)

  • Oct 05 13:32

    ehmicky on master

    Upgrade @ehmicky/dev-tasks 0.30… (compare)

  • Oct 05 10:37

    ehmicky on master

    Upgrade mocha 6.2.0 -> 6.2.1 Upgrade tap 14.6.5 -> 14.6.7 Upgrade tap 14.6.7 -> 14.6.9 and 3 more (compare)

  • Sep 29 13:19

    ehmicky on master

    Upgrade @ehmicky/dev-tasks 0.30… (compare)

  • Sep 29 13:15

    ehmicky on master

    Fix tests (compare)

  • Sep 29 12:57

    ehmicky on master

    Fix default `colors` option val… (compare)

  • Sep 28 18:06

    ehmicky on master

    Upgrade @ehmicky/dev-tasks 0.30… (compare)

  • Sep 28 18:01

    ehmicky on master

    Upgrade husky 3.0.5 -> 3.0.7 (compare)

  • Sep 28 18:00

    ehmicky on master

    Upgrade chalk to 3.0.0-beta.1 (compare)

  • Sep 28 15:40

    ehmicky on master

    Upgrade supports-color 7.0.0 ->… (compare)

  • Sep 28 15:06

    ehmicky on master

    Upgrade tap 14.6.4 -> 14.6.5 Use filter-obj (compare)

  • Sep 22 14:18

    ehmicky on master

    Upgrade @ehmicky/dev-tasks 0.30… (compare)

  • Sep 22 14:01

    ehmicky on master

    Upgrade jasmine 3.4.0 -> 3.5.0 (compare)

  • Sep 21 10:21

    ehmicky on master

    Upgrade @ehmicky/dev-tasks 0.30… (compare)

  • Sep 21 10:16

    ehmicky on master

    Upgrade tap 14.6.2 -> 14.6.4 Upgrade ava 2.3.0 -> 2.4.0 (compare)

  • Sep 15 13:43

    ehmicky on master

    Upgrade Travis from Ubuntu 16.0… (compare)

  • Sep 14 10:15

    ehmicky on master

    Upgrade tap 14.6.1 -> 14.6.2 Upgrade has-ansi 3.0.0 -> 4.0.0 Upgrade @ehmicky/dev-tasks 0.30… (compare)

  • Sep 08 17:30

    ehmicky on master

    Update CONTRIBUTING.md Update ava.config.js Update gulpfile.js and 2 more (compare)

  • Sep 08 17:07

    ehmicky on master

    Update CONTRIBUTING.md Update .prettierrc Update .eslintrc.yml and 2 more (compare)

Hongarc
@Hongarc
Hi, I see you have too much eslint-disable(example 22 line disable import/no-unassigned-import), are you want disable to all project?
ehmicky
@ehmicky
Hi there @Hongarc
The ESLint configuration I use is for all my projects, not just this one: https://github.com/ehmicky/eslint-config-standard-prettier-fp
It enforces functional programming, e.g. side-effects should be avoided: https://github.com/ehmicky/eslint-config-standard-prettier-fp#functional-programming
log-process-errors is a little different because of the way process errors work. First, they are global. Second, they use events, which are not functional programming friendly.
This leads to much more eslint-disable comments than in my other projects. That's because I depend on another project (Node.js itself) which does not follow my own coding conventions.
However I prefer to still keep those eslint-disable comments one by one, instead of disabling in the whole project, because the rules are still relevant for the rest of the code.
ehmicky
@ehmicky
When it comes to import/no-unassigned-import, it's because the testing option is about test runners. Test runners imply side effects. For example, when you run mocha, you are not trying to retrieve a value, but instead you wait for: 1) reporting to be printed on the console, 2) process exit and relevant exit code. Those two are side-effects.
I.e. when I test each test runner, I need to disable that ESLint rule.
But in the rest of the repo, the rule is still relevant
Hongarc
@Hongarc
Sorry, my mean is disable all of that rule for this project(not all your project, bad english).
ehmicky
@ehmicky
Yes I know that's what you meant :)
I meant: those rules can still be relevant for the rest of the repository, even though they are disabled in some parts of it