Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jan 07 2019 09:21
    oribensasson forked
    oribensasson/pytest-catchlog
  • Dec 15 2018 21:40
    Herklos starred eisensheng/pytest-catchlog
  • Sep 10 2018 11:23
    nschlemm starred eisensheng/pytest-catchlog
  • Sep 01 2018 11:51
    jdnrg starred eisensheng/pytest-catchlog
  • Jun 24 2018 19:37
    The-Compiler closed #76
  • Jun 24 2018 19:37
    The-Compiler commented #76
  • Jun 24 2018 15:27
    thisch commented #76
  • Jun 24 2018 15:26
    thisch commented #76
  • Jun 02 2018 07:23
    gloc-mike starred eisensheng/pytest-catchlog
  • May 30 2018 16:32
    marc1n commented #44
  • Mar 30 2018 13:32
    hlef commented #76
  • Mar 30 2018 13:14
    The-Compiler commented #76
  • Mar 30 2018 13:05
    hlef opened #76
  • Feb 23 2018 16:38
    The-Compiler closed #14
  • Feb 23 2018 16:38
    The-Compiler commented #14
  • Feb 23 2018 16:15
    thisch commented #14
  • Feb 09 2018 11:08
    lukas-bednar closed #38
  • Feb 09 2018 11:08
    lukas-bednar commented #38
  • Feb 09 2018 11:08
    lukas-bednar closed #39
  • Feb 09 2018 11:08
    lukas-bednar commented #39
Florian Bruhin
@The-Compiler
@s0undt3ch sounds good to me, though I don't mind much either way to be honest, I'm fine with both
Eldar Abusalimov
@abusalimov
Inspired by #32, are there options in pytest-core for saving stdout/stderr into file as well?
Florian Bruhin
@The-Compiler
there's --junit-xml=path and --result-log=path - but I'm not sure if they include stdout. Probably not for passed tests anyways.
@s0undt3ch btw, you might find pytest-html interesting as well, it produces HTML reports like this: http://www.qutebrowser.org/testresults/archlinux/1523.html
Eldar Abusalimov
@abusalimov
I'm afraid that a log file as suggested in #32 could become a mess without proper tests separation i.e. naming each test...
Florian Bruhin
@The-Compiler
good point
I have to admit I'm entirely uninterested in having a logfile myself, but I'd really like to get the existing PRs merged so we can discuss the renaming again and then I might start contributing my "fail on unexpected logging" thing
Eldar Abusalimov
@abusalimov
Judging by the code of pytest-html, it should already be able to show captured logs for failed tests. @s0undt3ch what do you think?
Florian Bruhin
@The-Compiler
I'm not sure report.longrepr exists for passed tests - at least for my tests I don't see any stdout/log output for passed tests
Eldar Abusalimov
@abusalimov
I'm almost sure this could be fixed by extracting that loop over report.sections from the if report.longrepr condition: https://github.com/davehunt/pytest-html/blob/0500aa622fab4e9bc6db671339bab347cb281d2b/pytest_html/plugin.py#L139-L142
Arthur Skowronek
@eisensheng
the new #33 approach looks nice to me. I like that the verbosity flag has been dropped. It simplifies the user interface on the command line and also the implementation.
Florian Bruhin
@The-Compiler
yeah, and I personally don't like -v doing too much
I'm already annoyed I have to use -vv (-> 3500 lines of output) on CI only to get full diffs in case of an error, so I did pytest-dev/pytest#1314
Florian Bruhin
@The-Compiler
Hey, @abusalimov @eisensheng @s0undt3ch anyone of you interested in going to https://pytest.org/latest/announce/sprint2016.html to get catchlog up in shape again? Seems like things stalled a bit, and that'd be a great opportunity to work on it together :) Depending on how much money is left from the crowdfunding, it might be possible to pay for your travel/lodging too.
Eldar Abusalimov
@abusalimov
Honestly, I can't tell for sure. There's a slight chance that I'll visit Berlin & Amsterdam this summer to meet my friends there, and in this case I could probably arrange a trip to southern Germany as well and join the pytest camp. Things are also a bit complicated since I'm looking for a new job now, and I'm not sure how a new employer would feel about summer vacation at all.
Arthur Skowronek
@eisensheng
I'm in a similar situation. If everything goes well I'll change my employer soon(ish). On the bright side I'll probably have more time to spend on open source projects then and with some luck will even be able to get back to other projects.
But until then I'll be too busy to keep track of what's happening around pytest-catchlog. I'm sorry for that. But the future looks even brighter.
Florian Bruhin
@The-Compiler
Okay, glad to hear that :)
Pedro Algarvio
@s0undt3ch
I'd love to attend that sprint, but I'm not sure I'll be able to.
Eldar Abusalimov
@abusalimov
@eisensheng are you OK? I start to worry about your disappearance...
Arthur Skowronek
@eisensheng
i'm fine and I finally got out of my old job. So I have some spare time now to spend on other things like pytest-catchlog again
left my old job on thursday and started the new on friday. :grin:
Eldar Abusalimov
@abusalimov
Oh, congratulations on that! :+1: And I'm going to a job interview on Monday too :smile:
Arthur Skowronek
@eisensheng
i'm very confident you'll do very well. :+1:
Eldar Abusalimov
@abusalimov
@eisensheng Thank you! I hope so..
Well, I'll merge #40, OK? :shipit: Any objections?
Arthur Skowronek
@eisensheng
just taking a look
the description sounds neat but I can't think of a use case. Can you give me one?
Eldar Abusalimov
@abusalimov
I encountered few complains on pytest-capturelog's performance overhead when I was researching pytest mailing list archives. And I have some ideas on how to make it faster, but one can't just claim smth. is "faster" without proofs on his hands :smile:
Oh, and just for fun, of course!
Arthur Skowronek
@eisensheng
Still reading through the changeset but it looks good to me and I'm in favor of merging this. I find it a little bit amusing that we're back to tox on travis with this PR :wink2:
Eldar Abusalimov
@abusalimov
Yeah, but I resisted, TBH :smile:
Arthur Skowronek
@eisensheng
is the before_install script a template you found elsewhere?
and I'm wondering a little bit which python version will be chosen by tox to run the tests. Will it be the version that's being used with the container?
Hum
I'll comment this on the PR.
ah, this is what the script does, neat. Nevermind what I was babbling above.
Eldar Abusalimov
@abusalimov
No, I came up with it myself. It infers TOXENVfrom a Python version running inside the container, yes. And tox respects TOXENV
Eldar Abusalimov
@abusalimov
BTW I made a PR to pytest-plugin cookiecutter template some time ago (pytest-dev/cookiecutter-pytest-plugin#13) and used a similar trick to infer TOXENV from TRAVIS_PYTHON_VERSION: https://github.com/pytest-dev/cookiecutter-pytest-plugin/pull/13/files#diff-354f30a63fb0907d4ad57269548329e3R14
Arthur Skowronek
@eisensheng
i like the short form. :smiley:
Eldar Abusalimov
@abusalimov
I decided to make it more explicit and verbose (+ announce() stuff)
Arthur Skowronek
@eisensheng
yes, this is also a favorable approach
Arthur Skowronek
@eisensheng
other than this I can't find anything else aside from the evil usage of eval but oh well. :shipit:
Eldar Abusalimov
@abusalimov
:smile: I'm not who invented this, pytest itself uses a similar eval trick within its marker handling logic.
Thank you!
Eldar Abusalimov
@abusalimov
OK, everything seems to work, I'll rebase and merge then
Arthur Skowronek
@eisensheng
ok. :+1:
Eldar Abusalimov
@abusalimov
Hi, could someone take a look at #42, please? Nothing interesting there, but it hinders some more useful changes...
Michael Aquilina
@MichaelAquilina
Hi, is pytest-catchlog basically a near drop in replacement for pytest-capturelog? I have a pytest warning about a deprecated argument. Would changing to this package remove that?
Eldar Abusalimov
@abusalimov
@MichaelAquilina pretty much. That deprecation warning is fixed, though catchlog itself might warn about legacy usage of caplogfixture, like caplog.records() should be replaced with plain caplog.records, etc.