These are chat archives for ellipsis/ellipsis

9th
Jul 2016
Zach Kelling
@zeekay
Jul 09 2016 19:53
Yeah, not sure what the deal is.
Out-dated extension?
some sort of variable pollution on my end maybe?
Gertjan Roggemans
@groggemans
Jul 09 2016 19:54
Did you use the init system before running tests?
Zach Kelling
@zeekay
Jul 09 2016 19:54
no
doesn't seem to help to manually source init.sh
run extension.is_compatible "999.0.0" [ $status -eq 1 ]
is currently failing
so is_compatible is returning 0 on invalid extension?
you check for greater than or equals
so 999.0.0 should be 0 i think?
test is wrong?
err no you are testing if it's too new, no?
Gertjan Roggemans
@groggemans
Jul 09 2016 19:57
not testing if its to new, only to old
Zach Kelling
@zeekay
Jul 09 2016 19:58
ELLIPSIS_VERSION seems unset
Gertjan Roggemans
@groggemans
Jul 09 2016 19:58
aha, that's the problem :)
now let's find out why..
Zach Kelling
@zeekay
Jul 09 2016 19:59
not sure
I see load version at end of src/init.
Gertjan Roggemans
@groggemans
Jul 09 2016 20:02
are only the tests failing or is ellipsis not running too?
Zach Kelling
@zeekay
Jul 09 2016 20:04
actually seems broken
el up no longer updates any extensions
updates ellipsis and stops
Gertjan Roggemans
@groggemans
Jul 09 2016 20:08
updating a specific package seems to work
dam, how good i brake everything so hard without touching much of it X)
*could
Gertjan Roggemans
@groggemans
Jul 09 2016 20:15
found the update bug
by quoting the $2 var in the cli command the test for parameters $# gives wrong results
I still can't reproduce the error with the version test..
Gertjan Roggemans
@groggemans
Jul 09 2016 20:30
(pr with temporary fix for the $2 bug opened)
Gertjan Roggemans
@groggemans
Jul 09 2016 20:47
merged it myself to get the bug fixed quickly
Zach Kelling
@zeekay
Jul 09 2016 21:11
okay cool
yep seems good
Gertjan Roggemans
@groggemans
Jul 09 2016 21:11
still can't find anything wrong with the version testing..
Zach Kelling
@zeekay
Jul 09 2016 21:21
yea
i'll toy with it
broken here
but rest seems fine
Gertjan Roggemans
@groggemans
Jul 09 2016 21:22
ok! When i fix the quoting/$2 bug I'll also improve the tests, definitely don't want to have this a second time..
Zach Kelling
@zeekay
Jul 09 2016 21:22
kk
sounds good