michaelsbradleyjr@discord when attempting to listen to a channel I get:
Error: Returned error: Invalid params: invalid type: string "messages", expected struct FilterRequest.
Jo@discord Quite possible that Parity doesn't support Whisper
michaelsbradleyjr@discord it seems to; included in parity --help:
Whisper Options:
--whisper
Enable the Whisper network.
--whisper-pool-size=[MB]
Target size of the whisper message pool in megabytes. (default: 10)in any case, at least latest parity is mostly viable for embark v4 users. I could poke at getting geth 1.9 working w/ embark v4, but I think it would either involve a fragile workaround for the simples problem or replacing the guts of the proxy
michaelsbradleyjr@discord it seems to; included in parity --help:
Whisper Options:
--whisper
Enable the Whisper network.
--whisper-pool-size=[MB]
Target size of the whisper message pool in megabytes. (default: 10)in any case, at least latest parity is mostly viable for embark v4 users. I could poke at getting geth 1.9 to work w/ embark v4, but I think it would either involve a fragile workaround for the simples problem or replacing the guts of the proxy
Jo@discord > but I think it would either involve a fragile workaround for the simples problem or replacing the guts of the proxy
might not be worth it then
might not be worth it then
michaelsbradleyjr@discord looks like parity's RPC for whisper, i.e.
shh_* calls, varies a bit from geth's
Jo@discord That's no good
michaelsbradleyjr@discord looks like parity's RPC for whisper, i.e.
note: maybe not, I think I was comparing old docs
shh_* calls, varies a bit from geth'snote: maybe not, I think I was comparing old docs
Jo@discord Not sure we ever tested that for Teller.
Jo@discord Have you? Does it behave weirdly?
barryg@discord testing now, works on MM not on status
barryg@discord at least for me
Jo@discord Break as in that code never triggers, or it just throws when reaching that code?
Jo@discord Ah, I can see it throwing, since it uses
ethereum
barryg@discord > Does the Status wallet support window.ethereum.on('accountsChanged' ?
no because on account change we refresh dapp and clear data
no because on account change we refresh dapp and clear data
barryg@discord probably just have to wrap it in a try catch, probably the way to go for most ethereum listeners since it's hard to know which wallet supports what
PascalPrecht@discord Right now we're busy stabilizing Embark V5
Andrey@discord kk thanks
Andrey@discord there are breaking changes in MM https://medium.com/metamask/breaking-changes-to-the-metamask-inpage-provider-b4dde069dd0a
Andrey@discord regarding your question
window.ethereum.send({jsonrpc:"2.0",method:"eth_accounts","params":[],"id":1}, console.log)
Andrey@discord i'll fix that but there will be a Promise with empty array
rramos@discord so, with that fix, getAccounts will not return the error from this block? https://github.com/status-im/status-react/blob/df098f82f648f947ae38abd2dce60722a158ab71/src/status_im/browser/core.cljs#L348-L358
rramos@discord yes
Andrey@discord btw if you call
ethereum.send({jsonrpc:"2.0",method:"eth_accounts" you will not have an error
Andrey@discord error will be only for sendAsync({jsonrpc:"2.0",method:"eth_accounts"
Andrey@discord after my changes both send and sendAsync will work the same , and i'll make a change for "eth_accounts" , it will return empty account instead of error
rramos@discord nice!!
rramos@discord I was not aware of the send/sendAsync difference
michaelsbradleyjr@discord @Andrey what's the underlying mechanism for the synchronous
.send (assuming it's synchronous)?
Andrey@discord there is no synchronous .send anymore
Andrey@discord "all" send return promise
michaelsbradleyjr@discord nice, okay, that's what I was wondering about
Andrey@discord i mean in status beta it's still synchronous, but in v1 it will return promise according to eip
Jo@discord
sendAsync is mostly deprecated I think too, but both are async anyway
michaelsbradleyjr@discord synchronous XHR used to be a thing, but gladly is a thing of the past, though I guess some runtimes still support it