enarx/dev

For in-depth technical discussion on the Enarx project.

Harald Hoyer

@haraldh

@npmccallum Oh... #![deny(clippy::integer_arithmetic)] really helps thinking about corner cases... e.g. I turned your: https://github.com/enarx/enarx/blob/master/enarx-keep-sgx/src/layout.rs#L19-L24
into

fn raise(value: usize, boundary: usize) -> Option<usize> {
    value
        .checked_add(boundary)
        .and_then(|v| v.checked_sub(1))
        .map(|v| lower(v, boundary))
}

Nathaniel McCallum

@npmccallum

:thumbsup:

Harald Hoyer

@haraldh

and if you know you don't have to check, just put it in a block with

#[allow(clippy::integer_arithmetic)]
{
   // whatever
}

it's like unsafe {}

Harald Hoyer

@haraldh

ok, scratch my last comment.. only works for functions ... doh!

#[inline(always)]
const fn lower(value: usize, boundary: usize) -> usize {
    #![allow(clippy::integer_arithmetic)]
    // integer_arithmetic checked
    value / boundary * boundary
}

#[inline(always)]
fn raise(value: usize, boundary: usize) -> Option<usize> {
    value
        .checked_add(boundary)
        .map(|v| v.wrapping_sub(1))
        .map(|v| lower(v, boundary))
}

one can write wrapping_*

haraldh @haraldh heads to bed.. gn8

Nathaniel McCallum

@npmccallum

In a macro that I'm writing, I need an attribute that has no effect to satisfy the parser. Something like #[cfg(true)]. Any suggestions?

Harald Hoyer

@haraldh

#[allow(missing_docs)]

#[cfg(not(feature = "unlikely_to_exist_feature"))

Connor Kuehl

@connorkuehl

[cfg(noop)] ?

can we define one like that

Harald Hoyer

@haraldh

#[cfg(not(__my_macro_name_undefined_cfg = ""))]

if it has to be cfg.. @npmccallum say something :)

Nathaniel McCallum

@npmccallum

It doesn't.

@haraldh I'm currently using your first suggestion.

Harald Hoyer

@haraldh

good :)

Harald Hoyer

@haraldh

rust turned 5

https://blog.rust-lang.org/2020/05/15/five-years-of-rust.html

Connor Kuehl

@connorkuehl

same

Harald Hoyer

@haraldh

hehe

Lily Sturmann

@lkatalin

lol

Mark Bestavros

@mbestavros

@npmccallum I have very positive news re. the runner: the public image (https://github.com/joeyx22lm/docker-github-actions-runner) should work exactly as we need it to, as long as we can store a Github-provided token securely on the Packet server.

Nathaniel McCallum

@npmccallum

@mbestavros That shouldn't be a problem. Just get it into the kickstart and we should be good to go!

Mark Bestavros

@mbestavros

In other words, if the container stops, we can invoke the same command (with the same token) after a reboot to restart the same runner, with the same name. We shouldn't need any manual interaction apart from initially provisioning the token.

Nathaniel McCallum

@npmccallum

That's great!

Mark Bestavros

@mbestavros

I'm looking at the kickstart now!

Mark Bestavros

@mbestavros

@npmccallum I'm forgetting... is there a way to provide input/arguments to the kickstart? Not just for the token, but also for runner names...

Nathaniel McCallum

@npmccallum

Yes and no.

Don't worry about it.

Just presume the token is in a file on the disk somehow.

Mark Bestavros

@mbestavros

Presume the same for runner name?

heh that rhymed

Nathaniel McCallum

@npmccallum

Yes.

Mark Bestavros

@mbestavros

Great. I'll submit a PR very soon then!

Mark Bestavros

@mbestavros

@npmccallum @haraldh enarx/packet.com#10

Nathaniel McCallum

@npmccallum

@haraldh Can you touch this? enarx/enarx#537

Lily Sturmann

@lkatalin

@connorkuehl Do we know that we can set env variables for cargo make as part of a task?

I can basically bake a path into a "script" value with bash but can't assign it as its own cargo make env var unless I do it outside a task

Harald Hoyer

@haraldh

@npmccallum done

Lily Sturmann

@lkatalin

Actually it looks like it's possible to set env vars in tasks with Duckscript

Lily Sturmann

@lkatalin

And a few other ways

@lkatalin reads all the docs

Nathaniel McCallum

@npmccallum

@connorkuehl SGX v30 is out. But don't build it. It only contains documentation changes. v31 should be out shortly.

Harald Hoyer

@haraldh

@npmccallum @connorkuehl I have a small PR for you :grin: enarx/enarx#542

Nathaniel McCallum

@npmccallum

@haraldh Ditto! enarx/enarx#541 :)

Harald Hoyer

@haraldh

An unexpected error occurred when executing this workflow. Please submit a new support request using our Support website:

https://support.github.com/contact

Please include this unique ID in your request: 3E09:14F5:1AE197:1CCCFE:5EBEFC75

meh

@npmccallum oh my... looks like I have to expand the macros with cargo expand...

Where communities thrive

People

Repo info

Activity