enarx/dev

For in-depth technical discussion on the Enarx project.

Lily Sturmann

@lkatalin

I can basically bake a path into a "script" value with bash but can't assign it as its own cargo make env var unless I do it outside a task

Harald Hoyer

@haraldh

@npmccallum done

Lily Sturmann

@lkatalin

Actually it looks like it's possible to set env vars in tasks with Duckscript

Lily Sturmann

@lkatalin

And a few other ways

@lkatalin reads all the docs

Nathaniel McCallum

@npmccallum

@connorkuehl SGX v30 is out. But don't build it. It only contains documentation changes. v31 should be out shortly.

Harald Hoyer

@haraldh

@npmccallum @connorkuehl I have a small PR for you :grin: enarx/enarx#542

Nathaniel McCallum

@npmccallum

@haraldh Ditto! enarx/enarx#541 :)

Harald Hoyer

@haraldh

An unexpected error occurred when executing this workflow. Please submit a new support request using our Support website:

https://support.github.com/contact

Please include this unique ID in your request: 3E09:14F5:1AE197:1CCCFE:5EBEFC75

meh

@npmccallum oh my... looks like I have to expand the macros with cargo expand...

@npmccallum we can't test, that something doesn't compile, or can we?

Nathaniel McCallum

@npmccallum

@haraldh I wondered the same thing...

https://doc.rust-lang.org/edition-guide/rust-2018/rustdoc/documentation-tests-can-now-compile-fail.html

Harald Hoyer

@haraldh

very cool

yeah, I should add more doc tests

at least for the parts, which don't rely on kvm

Harald Hoyer

@haraldh

my PR is cursed... the CI won't run all tests

ah.. rebase might fix it

now we are talking

Lily Sturmann

@lkatalin

@connorkuehl Totally fine if you reply to this on Monday, but do you have insight as to why you need both workspace = false and condition = { env_not_set = ["CARGO_MAKE_CRATE_NAME"]} to create a top-level task? I would expect it to work with just the former. However, as I'm testing, having only workspace = false does nothing and adding the env var not set condition means the task is skipped entirely at the crate level and top level.

Connor Kuehl

@connorkuehl

@lkatalin hmm, I checked my notes and I think I ran into the same thing with the include_members -- I think we should file a bug with upstream cargo-make. If you're just about to head into your weekend I can make a reproducer and file it with the upstream developer

Lily Sturmann

@lkatalin

@connorkuehl I'm going to work on this a bit longer, but I also trust myself less not to just be doing something dumb with cargo make since I'm only partway through the docs

Connor Kuehl

@connorkuehl

@lkatalin no worries! If I don't hear back from you in a couple hours I'll file a bug upstream, because my notes corroborate your experience and I think I did the condition to help work around it. The upstream dev might also patch it by Monday; they are very quick

Lily Sturmann

@lkatalin

@connorkuehl I love that they have a quick turnaround

Hmmmmm

I think I'm sort of blocked until this part makes sense. My next step would actually be to make a minimal version that doesn't work as a sanity-check. Maybe that would be useful to the bug report.

Connor Kuehl

@connorkuehl

@lkatalin Okay! Yeah, I would make a git repo and just make two crates, then make a root-level Makefile.toml that enables workspace emulation -- then make a task that sets CARGO_MAKE_WORKSPACE_INCLUDE_MEMBERS = "crate-a" or something and have it run an echo hello world or something. Then it should be clear to the developer that CARGO_MAKE_WORKSPACE_INCLUDE_MEMBERS doesn't work as intended with workspace emulation when hello world is emitted for both crates in the workspace rather than just the one we specified to include

Lily Sturmann

@lkatalin

@connorkuehl Good idea - that's basically what I've been doing in the Enarx repo anyway haha (I commented out a bunch of the workspace members, etc.)

I'll send a message when I've made the repo

Lily Sturmann

@lkatalin

@connorkuehl I think this actually has something to do with it: "This flag (workspace=....) is only checked for the task on the cargo-make command line and is completely ignored for all other tasks which are executed as part of the flow." It'll work properly if I'm not calling it as part of another task or flow.

OMG I think we have to fork

Connor Kuehl

@connorkuehl

hmm... does the process copy environment variables when it forks?

Lily Sturmann

@lkatalin

No, that's the thing. That's the only way to get the workspace flag to be different per task across a flow. So, this works actually: https://github.com/lkatalin/cargomakeworkspace/blob/master/Makefile.toml

It's just buried 3892 pages into the documentation.

Lily Sturmann

@lkatalin

Okay, I'm checking out for the day, but this is promising and finishing that test shouldn't be too hard on Monday.

Connor Kuehl

@connorkuehl

Ah I see... but what about only descending into certain specified member crates?

Lily Sturmann

@lkatalin

@connorkuehl I'm experimenting with it currently.

Nathaniel McCallum

@npmccallum

@mbestavros https://zapier.com/help/create/code-webhooks/use-javascript-code-in-zaps

Nathaniel McCallum

@npmccallum

@mbestavros So it appears that if zapier doesn't offer the exact integration you want, you can code it yourself.

Mark Bestavros

@mbestavros

That is very neat!

Nathaniel McCallum

@npmccallum

@axelsimon @mbestavros Someone I know who's an expert in OAuth has agreed to help me set up Rocket.Chat.

So hopefully that will be done by this afternoon.

Mark Bestavros

@mbestavros

Fantastic!

Nathaniel McCallum

@npmccallum

I suspect this is 90% OAuth knowledge...

Nathaniel McCallum

@npmccallum

It is working.

The only major downside so far is that when you use GitHub for authentication, you have to create a new chat username and you can type anything you want.

I wish it would use the GitHub username directly.

Nathaniel McCallum

@npmccallum

Okay. I've enabled anonymous chat, GitHub logins and disabled user registration.

@mbestavros and @axelsimon Would you join the server please so we can start polishing off the rough edges?

Where communities thrive

People

Repo info

Activity