These are chat archives for ensime/ensime-atom

9th
Jul 2016
Ghost
@ghost~540393fe163965c9bc2018ce
Jul 09 2016 19:27
@hedefalk are you using websockets yet?
Viktor Hedefalk
@hedefalk
Jul 09 2016 19:56
@fommil yes, exclusively which seems to still be a problem for a few with dying connections. Not for me though…
Ghost
@ghost~540393fe163965c9bc2018ce
Jul 09 2016 19:57
weird
Viktor Hedefalk
@hedefalk
Jul 09 2016 19:57
I did an interface to re-introduce the old socket too as an option, but haven't come around to impl.
Ghost
@ghost~540393fe163965c9bc2018ce
Jul 09 2016 19:57
I've got a PR with SWANKY and was wondering if we could remove JERK in favour of JERKY entirely
definitely don't... that protocol is being removed
I'd like to get Emacs using WebSockets too
then we can close down the TCP port entirely
Viktor Hedefalk
@hedefalk
Jul 09 2016 19:58
ok, yeah, I don't like it, but felt compelled helping those poor ones with dying connections out…
Ghost
@ghost~540393fe163965c9bc2018ce
Jul 09 2016 19:58
we should probably debug that further
there is an effort to rewrite the websocket server, so that could fix it if the problem has been with akka-http
using netty
Viktor Hedefalk
@hedefalk
Jul 09 2016 19:59
Yeah, I haven't been able to reproduce at all… ensime/ensime-atom#225
Ghost
@ghost~540393fe163965c9bc2018ce
Jul 09 2016 20:00
I'm adding two protocols actually: SWANKI and SWANKY
I is over TCP and is only temporary (help Emacs migration)
Y is over WebSockets
I'll remove JERK if that's ok with you
Viktor Hedefalk
@hedefalk
Jul 09 2016 20:01
Ok!
Rory Graves
@rorygraves
Jul 09 2016 20:03
@hedefalk do you have keeps lives configure on your websockets library. Could be shutting down on inactivity.
Ghost
@ghost~540393fe163965c9bc2018ce
Jul 09 2016 20:03
websockets has Ping support on the media layer, so no need to do anything like that in the userland protocol
Rory Graves
@rorygraves
Jul 09 2016 20:04
The websockets protocol supports its own keepalives (no use level messages).
@fommil yep, but you need to make sure the client is correctly configured otherwise you get disconnects if people get a coffee ;)
I figured I could just make a reconnection if it was closed, but since I haven't been able to reproduce at all myself it seems hard to test. Coding blindly…
Ghost
@ghost~540393fe163965c9bc2018ce
Jul 09 2016 20:07
I'm waiting to hear from the Vim folk
Viktor Hedefalk
@hedefalk
Jul 09 2016 20:08
Great job with the graphocalypse by the way! Reaaaally looking forward to what that can bring…
Ghost
@ghost~540393fe163965c9bc2018ce
Jul 09 2016 20:10
at the rate of client dev, you folk and vim will get the features before Emacs :-P
Rory Graves
@rorygraves
Jul 09 2016 20:28
Looking at http://stackoverflow.com/questions/10585355/sending-websocket-ping-pong-frame-from-browser sounds like JS does not allow the flags to specify keepalives. So dependent on browser/env. Sounds like you might want to add user level keepalives.
Ghost
@ghost~540393fe163965c9bc2018ce
Jul 09 2016 20:28
this might explain why we have the connectioninfo request/response pair
we should document that with a link to this SO question
oh, or does this mean the server should be sending the pings?
Rory Graves
@rorygraves
Jul 09 2016 20:30
It doesn't matter. I think we should update to have an unit message then plain keepalives we could hide (not log)
Ghost
@ghost~540393fe163965c9bc2018ce
Jul 09 2016 20:31
right, I'm off
SWANKY PR in
almost done
Viktor Hedefalk
@hedefalk
Jul 09 2016 20:32
Cool!