Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jan 05 2017 04:37
    jacobdlewis removed as member
  • Feb 23 2015 16:19

    erlandsona on erlandsona

    finding matches now works clicking button on profile show… when user profile is complete, … and 2 more (compare)

  • Feb 23 2015 15:35

    luketlancaster on master

    fix bug to keep matches showing… (compare)

  • Feb 23 2015 03:07

    jacobdlewis on master

    when user profile is complete, … Matches are styled when display… (compare)

  • Feb 22 2015 23:36

    jacobdlewis on master

    finding matches now works clicking button on profile show… (compare)

  • Feb 22 2015 23:35

    jacobdlewis on jake

    clicking button on profile show… (compare)

  • Feb 22 2015 23:18

    jacobdlewis on jake

    default image appears at end of… finding matches now works (compare)

  • Feb 22 2015 18:44

    mollytaryn on mollysbranch

    passing uid and image to matche… minor changes refactored like a bawhs and 3 more (compare)

  • Feb 20 2015 23:06

    erlandsona on master

    default image appears at end of… (compare)

  • Feb 20 2015 23:06

    erlandsona on erlandsona

    default image appears at end of… (compare)

  • Feb 20 2015 22:27

    jacobdlewis on jake

    merged all the user branches merge with mollybranch minified the profile submit fun… and 29 more (compare)

  • Feb 20 2015 22:25

    luketlancaster on luke

    cleaning half-way finished undecided users function is wor… Merge remote-tracking branch 'o… and 14 more (compare)

  • Feb 20 2015 22:02

    erlandsona on master

    displaying potentials and makin… (compare)

  • Feb 20 2015 22:01

    erlandsona on erlandsona

    displaying potentials and makin… (compare)

  • Feb 20 2015 20:54

    erlandsona on master

    refactored like a bawhs (compare)

  • Feb 20 2015 20:54

    erlandsona on erlandsona

    refactored like a bawhs (compare)

  • Feb 20 2015 18:02

    erlandsona on master

    passing uid and image to matche… (compare)

  • Feb 20 2015 18:00

    erlandsona on erlandsona

    passing uid and image to matche… (compare)

  • Feb 20 2015 15:33

    mollytaryn on mollysbranch

    Merge remote-tracking branch 'o… Merge branch 'master' into erla… Merge branch 'master' into erla… and 2 more (compare)

  • Feb 20 2015 15:29

    erlandsona on master

    Merge remote-tracking branch 'o… Merge branch 'master' into erla… Merge branch 'master' into erla… and 1 more (compare)

Jacob Lewis
@jacobdlewis
I think that the psuedocode example above is the way to go, but it glossed over an issue
we'll need nested loops. we need to loop through each user's list of likes
Molly
@mollytaryn
nested loops makes sense
Jacob Lewis
@jacobdlewis
got it
Molly
@mollytaryn
you did?
Jacob Lewis
@jacobdlewis
 function findMyMatches (currentUserLogin, listOfUserObjects) {
    var currentUserLikes = [];
    _.forIn(listOfUserObjects, function(user) {
      _.forEach(user.likes, function(item) {
        if (item === currentUserLogin) {
          currentUserLikes.push(user);
        }
      })
    });
    return currentUserLikes;
  }
pretty sure that's it
i'm checking firebase to verity
Molly
@mollytaryn
what is listOfUserObjects defined as?
Jacob Lewis
@jacobdlewis
when I called the function in the console, it was this:
findMyMatches(usersFb.key(), userListSnapshot)
I ran it as simplelogin:53, and all of the users returned as matches check out in firebase
yay!
Molly
@mollytaryn
wooo!
That’s awesome
I’m super impressed
Jacob Lewis
@jacobdlewis
thanks :) having time away from it really helps. It's been rattling around in my brain since friday
Jacob Lewis
@jacobdlewis
I got the piece about showing matches on the profile page to work too
but we have a small issue. you can definitely like a user twice
Jacob Lewis
@jacobdlewis
OK. i pushed those changes to master. Going to walk the dog and cook dinner, and then I'll try to do some more work. I think there are two main things left:
1 - styling the profile page. the form should hide when you already have profile info, and the list of your matches should look better than it currently does (requires a lot of scrolling now)
2 - you shouldn't be able to match a user twice.
Luke Lancaster
@luketlancaster
Hey all, just jumped on this for the first time this weekend. Didn’t do any work yesterday, thought a break was needed. I’ll take a look at y’alls work and see if there’s something I can jump in. Are the relevent changes pushed up to master? Sorry I haven’t been much of a help on this, I’m just over it and not handling doing the same thing for a week and some change. Let me know what I can do to chip in
Jacob Lewis
@jacobdlewis
hey luke. you still on/up to work?
Luke Lancaster
@luketlancaster
@jacobdlewis Back on and ready to get cracking. What’s the status?
Jacob Lewis
@jacobdlewis
sweet. I'm pretty much in your camp, insofar as I'm tired of working on this damned spooky app, but there are a handful of things we should knock out if we can
from my vantage point, I see one big thing and a handful of small things
Luke Lancaster
@luketlancaster
What’s at the top of that list?
Jacob Lewis
@jacobdlewis
the big thing is that the list of users generated for you to match agains isn't filtered by people you've already liked or disliked, so you can double like people
I think there should be a relatively simple fix, but I can't quite put my hands on it right now
maybe using the method scott was trying in one of his functions to diff userLikes, userDislikes and userListSnapshot?
Luke Lancaster
@luketlancaster
Have you started on that? Or what are your current thoughts on it, at least?
Jacob Lewis
@jacobdlewis
I haven't really started. I was breaking and working on some easy stuff like touching up styling.
are you game to try and tackle the double-matching piece for a little while?
Luke Lancaster
@luketlancaster
Beautiful. So, if I understand it correctly, we just need to create a “undecided” list (taking out the liked, unliked, and self user objects) and display the rest.
Jacob Lewis
@jacobdlewis
you got it
Luke Lancaster
@luketlancaster
Yeah, I’ll take a look at it. Your changes all pushed up to master?
I also may try to write a few tests just to bump the numbers up a bit
Jacob Lewis
@jacobdlewis
I think that using the _.difference method on profileInfo.likes, profileInfo.dislikes, and userListSnapshot might be the ticket
my changes should be up. if you pull master and build, you should be able to click a "see/find my matches" button on your profile and see your users' matches
Luke Lancaster
@luketlancaster
100% with you there.
Perfect, doing that now
Jacob Lewis
@jacobdlewis
sweet. let me know if you don't see that stuff, and I'll push again
Luke Lancaster
@luketlancaster
Yup. They are there. You taking a break or are you going to work on some styling stuff?
Jacob Lewis
@jacobdlewis
I'm trying to finish up some minor js tweaks (hiding your profile form when your profile is complete) so that we can avoid gross merge conflicts. otherwise, I'm just working on css styling.
Luke Lancaster
@luketlancaster
Perfect. I have that silly css shake stuff on my branch. We can decide what of that to use and what to throw out tomorrow morning
Jacob Lewis
@jacobdlewis
fwiw, I'm a fan of the silly shake stuff. my vote is to keep
Luke Lancaster
@luketlancaster
Awesome. I didn’t want to come down too strong on that side of the fence, but I’m 100% there as well..
Jacob Lewis
@jacobdlewis
just pushed some more (relatively minor) style changes to master
The hiding/showing profile form piece meant I had to touch the js file, but any merge conflicts you get when you push should be pretty easy to work through
any luck with eliminating duplicates?
Luke Lancaster
@luketlancaster
Sorry, I’ve been tending to go dark (do not disturb) when I work so I can focus. Messed with a few things, but didn’t make any real headway. Have to admit: my heart isn’t in it. I’m gonna call it a night and hit it again when I get to crema tomorrow morning.
Luke Lancaster
@luketlancaster