Where communities thrive

Join over 1.5M+ people
Join over 100K+ communities
Free without limits
Create your own community

Explore more communities

eslint/eslint

A fully pluggable tool for identifying and reporting on patterns in JavaScript.

People

Repo info

Activity

13:51

bidoubiwa closed #14151
13:51

bidoubiwa commented #14151
12:54

mdjermanovic commented #14151
12:32

mdjermanovic labeled #14151
12:32

mdjermanovic unlabeled #14151
12:16

mdjermanovic commented #14142
11:31

bidoubiwa opened #14151
11:31

bidoubiwa labeled #14151
11:31

bidoubiwa labeled #14151
11:24

bidoubiwa commented #13615
10:35

mdjermanovic commented #14149
10:15

mdjermanovic labeled #14149
10:15

mdjermanovic unlabeled #14149
05:34

valtlai commented #13481
03:18

amiller-gh commented #14149
03:16

amiller-gh commented #14148
03:08

amiller-gh synchronize #14148
03:05

eslint-github-bot[bot] commented #14148
03:05

amiller-gh edited #14148
03:04

eslint-github-bot[bot] commented #14148

rouxfeur

@rouxfeur

Hi, I wanted to use “prettier-eslint”, but the eslint part doesn’t work. So I want to try doing it myself. What they seem to do is that they suppress all un-fixable rules and then run eslint. The closest command I could find was eslint —fix —quiet, which I think just suppresses (some) messages, not actual checking?

What do I do if all I want is for eslint to format my code?

What I am trying to do, is to run prettier on save and eslint —fix right after, to apply some styling that diverges from prettier.

Roy Sutton

@webOS101

I don’t use prettier myself, but can’t you just change prettier to apply the styling you want and just use eslint for non-stylistic warnings?

Having two tools fight over the formatting seems like a bad idea.

Kai Cataldo

@kaicataldo

Prettier has some excellent documentation around using Prettier and ESLint here https://prettier.io/docs/en/integrating-with-linters.html

rouxfeur

@rouxfeur

@ Roy: no, prettier is opinionated and they favor less configuration.

Roy Sutton

@webOS101

Bummer, I’m opinionated, too, and was hoping to use prettier at some point. ;P

Jordan Harband

@ljharb

if you want to run prettier (you don't have to, of course), then you should only run it via eslint, using eslint-config-prettier to disable conflicting rules, and eslint-plugin-prettier to format

Kai Cataldo

@kaicataldo

I think there's a misunderstanding here - what @webOS101 suggested is really the only way to use Prettier and ESLint simultaneously

Jordan Harband

@ljharb

i don't think prettier-eslint is even maintained anymore

rouxfeur

@rouxfeur

@ Kai: The actually is about how to suppress other eslint rules and in favor of prettier.

Jordan Harband

@ljharb

@rouxfeur you do that by extending eslint-config-prettier

Kai Cataldo

@kaicataldo

Yes, please see the link above. There's an eslint config for that

rouxfeur

@rouxfeur

Yes, I know about eslint-config-prettier, which suppresses eslint rules in favor of prettier. What I’m looking for is what prettier-eslint is doing.

It’s the opposite - override some prettier styles.

Jordan Harband

@ljharb

@rouxfeur i've tried it, and it doesn't work well, and prettier-eslint is unmaintained. so i'd suggest either accepting prettier's limited configuration, or abandoning prettier entirely and pursuing regular eslint rules for the things you're missing

Kai Cataldo

@kaicataldo

Sounds like you don't want to use Prettier :P

FWIW, you can use ESLint's autofixing feature for more flexibility

The beauty of Prettier is its opinionated nature. I like using it because it eliminates most discussions around style :)

Jordan Harband

@ljharb

meh, "beauty"

using a shared eslint config like airbnb's or similar achieves the same goal

Kai Cataldo

@kaicataldo

For sure

To each their own

rouxfeur

@rouxfeur

Ok, but no matter if I use prettier && eslint or just eslint, I think my original questions is still relevant: What do I do if all I want is for eslint to format my code? As fast as possible, without it having to check all the rules that it cant automatically fix.

Kai Cataldo

@kaicataldo

ESLint has autofixing built in - you can run eslint --fix and it will autofix for you

Jordan Harband

@ljharb

there's not currently a way to do like eslint --only-fix

so if all you want is to lint autofixable rules, i think you have to just "not enable" rules that aren't autofixable

rouxfeur

@rouxfeur

Oh ok. And does —quiet makes any difference or it is just about logging?

Jordan Harband

@ljharb

--quiet suppresses things set to "warn"

rouxfeur

@rouxfeur

I see. Thank you!

Jordan Harband

@ljharb

(but warnings don't fail the build, so it's not really a viable approach to set all non-autofixable to warn, in case that's what you're thinking)

rouxfeur

@rouxfeur

I was actually thinking about it haha 😄 but yeah, I agree. I think I’ll just run prettier —write && eslint —fix on save for a few days and will see.

Roy Sutton

@webOS101

You can always force a failure on build with --max-warnings 0. I don’t know whether that will also fail on fixable warnings or only unfixable ones, though.

(If you also wanted to be fixing at build time)

Kevin Partington

@platinumazure

@webOS101 --max-warnings only takes into account warnings left after autofix.

In practice this means non-autofixable warnings, although it could also happen if one rule's autofix causes a violation in another rule, and that rule's autofix causes a violation in another rule, etc. (in such a way that there is a cycle/loop). ESLint bails out after 10 autofix attempts, so in that degenerate case, an autofixable rule could fix and still leave a warning (on the 10th pass).

Roy Sutton

@webOS101

That’s what I suspected.

ku64

@Jaku6Rojek

Do you know how can I solve the this kind of problem:
ESLint couldn't find the config "eslint-config-airbnb-es5" to extend from. Please check that the name of the config is correct.

Kai Cataldo

@kaicataldo

ESLint v6.8.0 has been released: https://eslint.org/blog/2019/12/eslint-v6.8.0-released

Kevin Partington

@platinumazure

@Jaku6Rojek Did you intentionally extend from that config in your ESLint configuration? If not-- sounds like you are linting node_modules, which you shouldn't do.

Dimitri KOPRIWA

@kopax

I am having issue with eslint --fix and lint-stagef

ESLint couldn't find the config "@ljharb" to extend from. Please check that the name of the config is correct.

The config "@ljharb" was referenced from the config file in "/home/dka/workspace/project1/server/node_modules/qs/.eslintrc".

Kai Cataldo

@kaicataldo

It sounds like you might be linting a nested node_modules directory. Best to ignore those using .eslintignore files.

tidel999

@tidel999_gitlab

I'm using the eslint extension with vscode. Do i have to configure anything special for the linter to work with mocha .test.js files?

does anyone know?

tidel999

@tidel999_gitlab

I created another .eslintrc.json file in my test folder and set the "root" to true. Is this the proper way to set up eslint for the test file

ku64

@Jaku6Rojek

@platinumazure I installed this npm install -g eslint-config-airbnb-es5 and wanted lint to use this schema to check the syntax.

@platinumazure Do you know how I can fix it?

Chat via Matrix