Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 06:47
    Alhadis commented #12778
  • 06:33
    kaicataldo commented #12778
  • 06:31
    kaicataldo commented #12778
  • 06:23
    Alhadis commented #12778
  • 06:22
    kaicataldo commented #12780
  • 05:48
    not-an-aardvark commented #12778
  • 02:27
    Alhadis commented #12778
  • 01:50
    not-an-aardvark commented #12778
  • 00:25
    mdjermanovic commented #12780
  • Jan 28 23:10
    MarcusCemes commented #3458
  • Jan 28 22:43
    eslint[bot] labeled #12022
  • Jan 28 22:43
    eslint[bot] locked #12022
  • Jan 28 22:43
    eslint[bot] labeled #12028
  • Jan 28 22:43
    eslint[bot] locked #12028
  • Jan 28 22:43
    eslint[bot] labeled #12037
  • Jan 28 22:43
    eslint[bot] locked #12037
  • Jan 28 22:43
    eslint[bot] labeled #12038
  • Jan 28 22:43
    eslint[bot] locked #12038
  • Jan 28 22:43
    eslint[bot] labeled #12040
  • Jan 28 22:43
    eslint[bot] locked #12040
Jordan Harband
@ljharb
it's far better to copy-paste code for tests
that kind of abstraction is overdoing it, and in my experience makes it harder to maintain your code and tests.
voloszad
@voloszad
Thanks, well you've got a point. I know it's offtopic, but something like this should be fine on the long run even with repeating?
describe('Grid component', () => {
  describe('Have gutter', () => {
    const component = shallow(<Grid showGutter />);

    it('should render a <div /> with gutter', () => {
      const wrapper = component.find('div');
      expect(wrapper.hasClass('grid__gutter')).toEqual(true);
    });
  });

  describe('No gutter', () => {
    const component = shallow(<Grid showGutter={false} />);

    it('should render a <div /> without gutter', () => {
      const wrapper = component.find('div');
      expect(wrapper.hasClass('grid__gutter')).toEqual(false);
    });
  });
});
Jordan Harband
@ljharb
@voloszad yes that's totally fine
if you DRY up your tests too much, you'll die of thirst :-p
voloszad
@voloszad
Thank again! 👍
Mojtaba Javan
@mrmowji
Hi, I'm new here and to ESLint. I have an issue with how no-param-reassign works. eslint/website#686
Can anyone help me understand what I'm missing?
Jordan Harband
@ljharb
commented
Mojtaba Javan
@mrmowji
@ljharb Appreciated.
Yasser Beyer
@yas46
help im getting this error when i try to run eslint on vs code
Michael Stelly
@mjstelly
What error?
Roy Sutton
@webOS101
That one.
¯\_(ツ)_/¯
Michael Stelly
@mjstelly
Ooohhh. Never saw one like that. jk 😛
Roy Sutton
@webOS101
“I just the whole thing"
Daniel Madalitso Phiri
@malgamves
image.png
Hey, I can't get passed this ESLint couldn't find the config "prettier" to extend from. Please check that the name of the config is correct. Anyone got passed it?
Would appreciate any help
Jordan Harband
@ljharb
you have to have eslint-config-prettier installed (everything locally, nothing globally, ofc)
Daniel Madalitso Phiri
@malgamves
Ooh, global install messed it up for me. Thanks, its working now
Roy Sutton
@webOS101
Not sure why the error messages for v6 don't specifically say 'make sure you have it installed locally'
kbirger
@kbirger
Hi folks. Quick question... is there any sort of functionality in the CLI to tell you which config a certain rule is coming from? The use case is that I have a configuration that doesn't define rules of its own, but imports a number of other configurations. I know I can find my answers by going through the files, but it's pretty time-consuming
Kai Cataldo
@kaicataldo
I’m currently not in front of a computer (so I can’t confirm at the moment, sorry!), but I don’t think this is a feature we support at the moment. Have you tried the --print-config option?
Agreed that this would be a nice feature to have though
kbirger
@kbirger
Yes, I saw print-config. That one shows you the final configuration, but not the sources of each rule.
Kai Cataldo
@kaicataldo
Right, that’s what I thought
Jordan Harband
@ljharb
can eslint/eslint#11486 be unlocked and opened (or properly closed with a link to the right place)? import() is stage 4 and eslint needs to support it.
aha, or maybe i need 2020 instead of 2019 as my ecmaversion :-) it'd be great to add the appropriate comment to those issues
Andrea Giurgola
@TheLifeGamingYT
when someone can help me
just mention me
the problem is this one
ESLint couldn't find the config "airbnb-base" to extend from. Please check that the name of the config is correct.
got it straight from ci
@ljharb
Jordan Harband
@ljharb
@thelifegamingyt make sure all eslint things are installed only locally, not globally.
and in this case that includes eslint-config-airbnb-base and its peer deps
Andrea Giurgola
@TheLifeGamingYT
Hi
Thank you for your Nasser
So now it workshop
I didnt do anything g an
And it just worked
I don't m ow
Sorry for all the typos
But I'm on mobile right now
Kranthi1214
@Kranthi1214
ESLint: TypeError: this.cliEngine is not a constructor
How do I solve this
And How can I add auto-formatting for eslint errors in Intellij
Kranthi1214
@Kranthi1214
Screen Shot 2020-01-27 at 4.20.59 PM.png