by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Kevin Partington
    @platinumazure

    The lack of comments on the RFC or PR since May suggest that this isn't really a high priority issue from the community. I think we should look at the PR and see if there's any way the use case could move forward (maybe with a different API).

    Should we close the PR just for housekeeping, and note that it could be reopened if the RFC is accepted? (And we would try to review the RFC as soon as we can.)

    Ilya Volodin
    @ilyavolodin
    I'm not sure I would want to accept this RFC anyways. It seems to disable primary feature of ESLint. I understand the need (not really), but I feel like this should be achieved through other means (wrapper around pre-commit hook)
    Brandon Mills
    @btmills
    I'm with @ilyavolodin. I'd rather document the workarounds, e.g. || exit 0
    Kevin Partington
    @platinumazure

    I agree with that as well. I was just trying to provide a proposal to handle the PR without committing to accepting or rejecting the RFC...

    I guess I'll ask this: Does anyone here want to champion the idea of the RFC (even if the eventual implementation is different)?

    :+1: from me to documenting workarounds
    Ilya Volodin
    @ilyavolodin
    :-1: on championing this idea. And :+1: on documentation
    Toru Nagashima
    @mysticatea
    :+1: for documentation
    Kevin Partington
    @platinumazure
    Okay, so should we close the PR and also close the RFC, saying we discussing in TSC meeting and the team came to consensus that this is something we don't want to do (and we'll instead accept PRs for documenting the workarounds)?
    Ilya Volodin
    @ilyavolodin
    :+1:
    Brandon Mills
    @btmills
    :+1:
    Toru Nagashima
    @mysticatea
    :+1:
    Ilya Volodin
    @ilyavolodin
    Ok, so let's close both with the comment to document a work-around solution
    I think that's all the time we have for today
    We didn't get to the RFC issue that @platinumazure mentioned though:-(
    Brandon Mills
    @btmills
    Do we need to assign someone to do the release with @kaicataldo?
    Ilya Volodin
    @ilyavolodin
    Yes
    We need one more person to do the release with @kaicataldo
    Since he is full-time now, I assume his timing is flexible
    Unfortunately, I will not be able to do it tomorrow or this weekend:-(
    Brandon Mills
    @btmills
    I can do around lunchtime tomorrow - I just need to be done by 1:30
    Kevin Partington
    @platinumazure
    Well, the PRs (and RFC) we looked at were older than the RFC blocked by my issue, so it's okay. I'll just queue it for next meeting again
    Brandon Mills
    @btmills
    Hopefully @kaicataldo checks here and confirms one
    Kevin Partington
    @platinumazure
    I can do Friday evening or possibly Saturday sometime
    Ilya Volodin
    @ilyavolodin
    @btmills @platinumazure can you check with @kaicataldo offline to see who's time is lining up?
    Brandon Mills
    @btmills
    I'll re-post in the TSC channel so he sees it
    Ilya Volodin
    @ilyavolodin
    Awesome. In that case, I think we are done for tonight. Thanks everyone!
    Kevin Partington
    @platinumazure
    Thanks! :wave:
    Toru Nagashima
    @mysticatea
    Thank you :wave:
    Brandon Mills
    @btmills
    :wave: thanks!
    Kevin Partington
    @platinumazure
    :wave:
    Brandon Mills
    @btmills
    :wave:
    Toru Nagashima
    @mysticatea
    Hello
    Kai Cataldo
    @kaicataldo
    :wave:
    Kevin Partington
    @platinumazure
    I think that gives us quorum? (I count 7 total TSC members, 2 of whom are absent AND on Non-Attending TSC, so 5 total people who could attend. 4 out of 5 is quorum)
    Kai Cataldo
    @kaicataldo
    :+1:
    Kevin Partington
    @platinumazure
    (I was also on Non-Attending but that's been wrong for a while, and Toru is on that team as well but he is here today)
    (I've removed myself from Non-Attending to avoid confusion)
    Brandon Mills
    @btmills
    I can take notes
    Kai Cataldo
    @kaicataldo
    Who wants to run the meeting/take notes?
    I'm happy to run the meeting
    Kevin Partington
    @platinumazure
    :+1:
    Kai Cataldo
    @kaicataldo
    Pulling up the list of issues, one sec
    Kevin Partington
    @platinumazure
    There's a (hopefully fairly simple) issue on ESLint Core-- then I would recommend going through the TSC Meetings issue as we have like 4 items there
    Kai Cataldo
    @kaicataldo
    Sounds good
    First item:

    TSC Summary

    This PR proposes to include the Node version when hashing the cache key, ensuring that the cache is busted when consecutive linting runs are executed with different Node versions.

    TSC Question

    Should we accept this?

    Kevin Partington
    @platinumazure
    (As a note, Ilya and I have :+1:ed that comment)
    Toru Nagashima
    @mysticatea
    :+1:
    Kai Cataldo
    @kaicataldo
    :+1: