by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Ilya Volodin
    @ilyavolodin
    :+1:
    Brandon Mills
    @btmills
    :+1:
    Toru Nagashima
    @mysticatea
    :+1:
    Ilya Volodin
    @ilyavolodin
    Ok, so let's close both with the comment to document a work-around solution
    I think that's all the time we have for today
    We didn't get to the RFC issue that @platinumazure mentioned though:-(
    Brandon Mills
    @btmills
    Do we need to assign someone to do the release with @kaicataldo?
    Ilya Volodin
    @ilyavolodin
    Yes
    We need one more person to do the release with @kaicataldo
    Since he is full-time now, I assume his timing is flexible
    Unfortunately, I will not be able to do it tomorrow or this weekend:-(
    Brandon Mills
    @btmills
    I can do around lunchtime tomorrow - I just need to be done by 1:30
    Kevin Partington
    @platinumazure
    Well, the PRs (and RFC) we looked at were older than the RFC blocked by my issue, so it's okay. I'll just queue it for next meeting again
    Brandon Mills
    @btmills
    Hopefully @kaicataldo checks here and confirms one
    Kevin Partington
    @platinumazure
    I can do Friday evening or possibly Saturday sometime
    Ilya Volodin
    @ilyavolodin
    @btmills @platinumazure can you check with @kaicataldo offline to see who's time is lining up?
    Brandon Mills
    @btmills
    I'll re-post in the TSC channel so he sees it
    Ilya Volodin
    @ilyavolodin
    Awesome. In that case, I think we are done for tonight. Thanks everyone!
    Kevin Partington
    @platinumazure
    Thanks! :wave:
    Toru Nagashima
    @mysticatea
    Thank you :wave:
    Brandon Mills
    @btmills
    :wave: thanks!
    Kevin Partington
    @platinumazure
    :wave:
    Brandon Mills
    @btmills
    :wave:
    Toru Nagashima
    @mysticatea
    Hello
    Kai Cataldo
    @kaicataldo
    :wave:
    Kevin Partington
    @platinumazure
    I think that gives us quorum? (I count 7 total TSC members, 2 of whom are absent AND on Non-Attending TSC, so 5 total people who could attend. 4 out of 5 is quorum)
    Kai Cataldo
    @kaicataldo
    :+1:
    Kevin Partington
    @platinumazure
    (I was also on Non-Attending but that's been wrong for a while, and Toru is on that team as well but he is here today)
    (I've removed myself from Non-Attending to avoid confusion)
    Brandon Mills
    @btmills
    I can take notes
    Kai Cataldo
    @kaicataldo
    Who wants to run the meeting/take notes?
    I'm happy to run the meeting
    Kevin Partington
    @platinumazure
    :+1:
    Kai Cataldo
    @kaicataldo
    Pulling up the list of issues, one sec
    Kevin Partington
    @platinumazure
    There's a (hopefully fairly simple) issue on ESLint Core-- then I would recommend going through the TSC Meetings issue as we have like 4 items there
    Kai Cataldo
    @kaicataldo
    Sounds good
    First item:

    TSC Summary

    This PR proposes to include the Node version when hashing the cache key, ensuring that the cache is busted when consecutive linting runs are executed with different Node versions.

    TSC Question

    Should we accept this?

    Kevin Partington
    @platinumazure
    (As a note, Ilya and I have :+1:ed that comment)
    Toru Nagashima
    @mysticatea
    :+1:
    Kai Cataldo
    @kaicataldo
    :+1:
    Brandon Mills
    @btmills
    :+1:
    Kai Cataldo
    @kaicataldo
    Great! Resolution is to accept this proposal.
    Next item:

    TSC Summary

    In this comment, I noted that it is currently considered a breaking change to add warnings for any reason (including outside of lint rules), because of eslint --max-warnings=0.

    Our semver policy currently states that causing build errors on any enhancement should always be treated as semver-major (and this is correct and sensible). When someone is using --max-warnings, any new warnings can cause a build error.

    At the same time, warnings are currently our best way of reporting non-fatal errors from core (e.g., if there are minor issues with disable comments, deprecated rules, etc.). Errors and warnings are fundamentally different: Errors change the exit code of CLI processes and generally represent issues that users must resolve, but warnings do not change the exit code of CLI processes and generally represent minor issues that users could ignore. Warnings only become issues that users must resolve if they use --max-warnings in the CLI, and that is an opt-in decision.

    TSC Question

    Can we consider adding new warnings in semver-minor enhancements, as long as they are only warnings? As part of this, can we consider --max-warnings and any CLIEngine equivalent as the user bypassing our semver policy, similar to eslint:all?

    If not, could we design a new way to communicate to users, in such a way that RFCs which add information for users could do so without semver risks? For example:

    • New message severity that can never trigger nonzero exit code even with --max-warnings
    • A new report section for informational messages unrelated to per-file linting
    Kevin Partington
    @platinumazure
    This discussion is semi-blocking eslint/rfcs#34 right now, as a note. So it would be wonderful to have a direction
    Kai Cataldo
    @kaicataldo
    I think the biggest issue here is that we conflate linting warnings with other warnings at the moment
    Seems like introducing more linting warnings in rules should be treated the same way we do changes that increase errors reported in rules, but I agree that console warnings around feature deprecation or tool usage can be useful and should not have to be treated as a breaking change.