by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jun 15 11:21

    sirinsidiator on master

    6.0.7 (compare)

  • Jun 03 10:50

    sirinsidiator on master

    6.0.6 (compare)

  • May 26 09:26

    sirinsidiator on pts6.0

    6.0.5 (live) (compare)

  • May 26 09:26

    sirinsidiator on master

    6.0.5 (compare)

  • May 18 14:55

    sirinsidiator on pts6.0

    6.0.4 (compare)

  • May 11 18:13

    sirinsidiator on pts6.0

    6.0.3 (compare)

  • May 04 15:09

    sirinsidiator on pts6.0

    6.0.2 (compare)

  • Apr 27 14:18

    sirinsidiator on pts6.0

    6.0.1 (compare)

  • Apr 20 22:57

    sirinsidiator on pts6.0

    6.0.0 (compare)

  • Apr 13 09:07

    sirinsidiator on master

    5.3.9 (compare)

  • Mar 23 12:52

    sirinsidiator on master

    5.3.7 (compare)

  • Mar 16 13:53

    sirinsidiator on master

    5.3.6 (compare)

  • Mar 02 11:59

    sirinsidiator on master

    5.3.5 (compare)

  • Feb 24 18:44

    sirinsidiator on master

    5.3.4 (compare)

  • Feb 24 12:54

    sirinsidiator on pts5.3

    5.3.4 (compare)

  • Feb 10 16:00

    sirinsidiator on pts5.3

    5.3.3 (compare)

  • Feb 03 20:53

    sirinsidiator on pts5.3

    5.3.2 (compare)

  • Jan 27 17:02

    sirinsidiator on pts5.3

    5.3.1 (compare)

  • Jan 27 15:53

    sirinsidiator on master

    5.2.13 (compare)

  • Jan 21 22:58

    sirinsidiator on pts5.3

    5.3.0 (compare)

Sharlikran
@Sharlikran
Old has that
manavortex
@manavortex
Why don't you debug the problem instead of the saved variables? :P
sirinsidiator
@sirinsidiator
we already solved it @manavortex . the addon is buggy :P
Sharlikran
@Sharlikran
image.png
The new one has Never
manavortex
@manavortex
guess so siri
well, RIP :D
sirinsidiator
@sirinsidiator
tbh I don't think it's a good idea to use moc() to determine if you should show the tooltip anyway xD
the mouse can be anywhere when it shows up
in the error stacktrace you can see that it got called by a mouse up handler, so a user could click down, move the mouse somewhere else and then release the button
Sharlikran
@Sharlikran

The steps to reproduce is to simply open the

  1. Guild Store
  2. Switch to sell tab in Guild Store
  3. Choose an item
  4. Double click item to add it to sell

POOF error

manavortex
@manavortex
just change the line to if moc() and moc():GetParent() and
and see if that fixes it
Sharlikran
@Sharlikran
Okay let me type that up
kyoma
@kyoma
Hmm, error in guild store.....surely that means its siri's fault :D
Sharlikran
@Sharlikran
if IIfA:GetSettings().showToolTipWhen == "Never" or
    (IIfA:GetSettings().showToolTipWhen == "IIfA" and moc():GetParent():GetName() ~= "IIFA_GUI_ListHolder") then
    return
end
kyoma
@kyoma
He messed with that so much even the base UI is now utterly broken
manavortex
@manavortex
yearh @sirinsidiator guess it's broken
Sharlikran
@Sharlikran
to
sirinsidiator
@sirinsidiator
I guess you should just check if the tooltip is the IIFA tooltip directly?
instead of trying to compare it by name
you do create the tooltip somewhere, right?
Sharlikran
@Sharlikran
if moc() and moc():GetParent() and IIfA:GetSettings().showToolTipWhen == "Never" or
    (IIfA:GetSettings().showToolTipWhen == "IIfA" and moc():GetParent():GetName() ~= "IIFA_GUI_ListHolder") then
    return
end
manavortex
@manavortex
no, wait
Sharlikran
@Sharlikran
There is already a lot of "and" in there to begin with
manavortex
@manavortex
or (IIfA:GetSettings().showToolTipWhen == "IIfA" and moc() and moc():GetParent() and moc():GetParent():GetName() ~= "IIFA_GUI_ListHolder"
yes, there is
kyoma
@kyoma
It isnt checking for the tooltip's name, its checking if the thing being mouseover'd is a child of IIFA_GUI_ListHolder, aka one of IIfA's item elements
sirinsidiator
@sirinsidiator
ah
kyoma
@kyoma
The tooltip used for that is just the builtin one with SetLink
sirinsidiator
@sirinsidiator
ok. in that case it would likely make more sense to set a flag in the click handler for the iifa elements?
something like
function iifaonmouseup()
iifa.hasclickedownelement = true
-- do the stuff you do in there
iifa.hasclickedownelement = false
end
or otherwise mark where the tooltip is shown from
kyoma
@kyoma
It did that in the distant past (maybe even before it rose from the ashes) but back then it also had different code for grabbing item data for a selected item.
manavortex
@manavortex
absolutely, yes.
kyoma
@kyoma
https://github.com/manavortex/InventoryInsight/blob/master/IIfA/IIfATooltip.lua#L334
manavortex
@manavortex
looks like partial refactoring there
sirinsidiator
@sirinsidiator
more like defactoring :P
manavortex
@manavortex
getMouseoverLink works, the other doesn't
Sharlikran
@Sharlikran
I'm gonna add LibDebugLogger and see what is really nil there
sirinsidiator
@sirinsidiator
likely the parent
Sharlikran
@Sharlikran
Yep you are right, it's GetParent
When GetParent is not nil the value I am showing is ZO_PlayerInventoryListContents
@sirinsidiator and darnet I went and reinstalled all my mods and forget to make a backup of my keybind to toggle the quick log viewer, that was hard for me to figure out darnet
kyoma
@kyoma
Darn those parents!!?
Sharlikran
@Sharlikran
if IIfA:GetSettings().showToolTipWhen == "Never" or
    (IIfA:GetSettings().showToolTipWhen == "IIfA" and moc():GetParent() and moc():GetParent():GetName() ~= "IIFA_GUI_ListHolder") then
    return
end
Okay had to clean out all the LibDebugLogger stuff, but yes doing that seems to address the issue for now
Sharlikran
@Sharlikran
@sirinsidiator thanks for directing me to the proper possible location. Sifting through the saved vars was going to be a pain but I didn't know where else to start since that is what I deleted to resolve the issue.
Now I have to figure out how I did that Keybind for the quick log viewer!!!!!!
arrrrrggg