Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Aug 08 18:53

    sirinsidiator on pts8.1

    8.1.4 (compare)

  • Aug 01 14:57

    sirinsidiator on pts8.1

    8.1.3 (compare)

  • Jul 25 18:14

    sirinsidiator on pts8.1

    8.1.2 (compare)

  • Jul 18 16:11

    sirinsidiator on pts8.1

    8.1.1 (compare)

  • Jul 18 16:03

    sirinsidiator on master

    8.0.8 (compare)

  • Jul 11 18:52

    sirinsidiator on pts8.1

    8.1.0 (compare)

  • Jul 06 19:46

    sirinsidiator on master

    8.0.7 (compare)

  • Jun 20 11:36

    sirinsidiator on master

    8.0.6 (compare)

  • Jun 06 15:36

    sirinsidiator on master

    8.0.5 (compare)

  • Jun 06 15:32

    sirinsidiator on pts8.0

    8.0.5 (compare)

  • May 16 21:13

    sirinsidiator on pts8.0

    8.0.4 (compare)

  • May 09 20:34

    sirinsidiator on pts8.0

    8.0.3 (compare)

  • May 09 20:09

    sirinsidiator on master

    7.3.9 (compare)

  • May 02 18:08

    sirinsidiator on pts8.0

    8.0.2 (compare)

  • Apr 25 15:46

    sirinsidiator on pts8.0

    8.0.1 (compare)

  • Apr 25 10:57

    sirinsidiator on master

    7.3.8 (compare)

  • Apr 19 20:12

    sirinsidiator on pts8.0

    8.0.0 (compare)

  • Apr 18 15:10

    sirinsidiator on master

    updated ESOUIDocumentation.txt (compare)

  • Apr 11 15:45

    sirinsidiator on master

    7.3.7 (compare)

  • Mar 28 10:48

    sirinsidiator on master

    7.3.6 (compare)

Sharlikran
@Sharlikran
So it's like don't do that
manavortex
@manavortex
Hmm? :D
Sharlikran
@Sharlikran
because the recipe should return false for IsItemLinkPlaceableFurniture, but it returned true for the loooonnnggggg way you asked me to do it
manavortex
@manavortex
Yea, but I've checked on the result…
Sharlikran
@Sharlikran
d(IsItemLinkPlaceableFurniture(GetItemLinkRecipeResultItemLink("|H1:item:182997:4:1:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0|h|h", LINK_STYLE_BRACKETS)))
that returned true
but it's a recipie
manavortex
@manavortex
Yeah, because it asks for the result first
Sharlikran
@Sharlikran
but if I just use IsItemLinkPlaceableFurniture("|H1:item:182997:4:1:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0|h|h") it will be false
manavortex
@manavortex
yeah, 997 is the recipe
that's not placeable furniture :D
Sharlikran
@Sharlikran
right so it appears that when coupled with GetItemLinkRecipeResultItemLink something breaks
manavortex
@manavortex
yeah. I'l patch and investigate, thank you so much <3
Sharlikran
@Sharlikran
Okay
And you can not run the game at all I take it?
manavortex
@manavortex
Nope, 40GB away from that still
I'll leave it running over night
Sharlikran
@Sharlikran
okay I'll look at something else and post again
manavortex
@manavortex
No, wait
It was a 10t
I forgot how my own fucking utility function works
FurC gobbles up every single item or recipe it sees
and the function to check if anything needs to be added checks if the data already exists, and skips in that case…
So that's probably what happened.
Sharlikran
@Sharlikran
Okay well if you get it working sweet otherwise let me know because I was noticing ShouldBeInFurC(link) uses link = FurC.GetItemLink(link) which is fine but if you don't get it working then I was going to try to use something more like if the link contains H1 or H0 then it's a valid link just use it and if not then go out and use FurC.GetItemLink(link) since that seems to generate a link using zo_strformat("|H1:item:<<1>>:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0|h|h", itemId) when you just have the item ID.
manavortex
@manavortex
That's what FurC.GetItemLink should do
if it's not numerical, just return it
(null-proofing it so there are no exceptions)
It's why I kept the function, to make sure there were no nullpointer exceptions lmao
Sharlikran
@Sharlikran
local function getItemLink(itemId)
    if nil == itemId then return end
    itemId = tostring(itemId)
    if #itemId > 55 then return itemId end
    if #itemId < 4 then return end
    return zo_strformat("|H1:item:<<1>>:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0|h|h", itemId)
end
Well I'm not expert so looking at that, it's like if the length is longer than or less than then do something. I tend to do things the long way and because an Item ID can now be so long and since a real item link can also contain so much more then it did before I wanted to rewrite that to do it different
manavortex
@manavortex
If it ain't broke, don't fix it :joy:
The function is so fucked-up because that throws zero exceptions
Sharlikran
@Sharlikran
That's up to you
if it were up to me I would be more like
manavortex
@manavortex
If I touch that, then I'll get some user "BUT MANA, I TOUCHED THAT STATUE OF MOLAG BAL'S DICK, AND FURC THREW AN EXCEPTION"
Trust me, it's happened before :joy:
Sharlikran
@Sharlikran
local function getItemLink(itemId)
  if nil == itemId then return end
  local isItemId = itemId == 'number'
  local isValidLink = string.match(itemId, "H0") or string.match(itemId, "H1")
  if isValidLink return itemId end
  if isItemId then return zo_strformat("|H1:item:<<1>>:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0|h|h", itemId) end
  -- otherwise shit hit the fan
end
No worries, I know users do that but still. Everyone here including you always offers help when possible. Even if I chose to do it different. So naturally you don't have to do anything you don't want but that's what I was going for.
manavortex
@manavortex
<3 thank you
Sharlikran
@Sharlikran
Since you are not obligated to use that function I'm still curious. May I please ask when is ShouldBeInFurC() used? There is a comment at the end about getting information? Specifically data mining.
manavortex
@manavortex
Yeah, it's a utility function for my helper tool that uses SidTools
ShouldBeInFurc() deliberately does not add shit to the database :joy:
Sharlikran
@Sharlikran
Weird
function ShouldBeInFurC(link)
    link = FurC.GetItemLink(link)
  local itemId = GetItemLinkItemId(link)

    if IsItemLinkPlaceableFurniture(link) then                 
        return nil == FurnitureCatalogue.settings.data[itemId]
    end

    if not IsItemLinkFurnitureRecipe(link) then    return false end 

    for _, versionData in pairs(FurC.Recipes) do
        for _, id in ipairs(versionData) do
            if id == itemId then return false end
        end
    end
    for _, versionData in pairs(FurC.FaustinaRecipes) do
        if versionData[itemId] then return false end
    end        
    for _, versionData in pairs(FurC.RolisRecipes) do
        if versionData[itemId] then return false end
    end

    -- yeah okay, it should actually return false, but this is a util function for datamining
    return nil == FurnitureCatalogue.settings.data[itemId]
end
manavortex
@manavortex
Look at _SidTools_Custom.lua
Sharlikran
@Sharlikran
Because I thought about using that for my personal copy since I know that link will always be a itemLink with what I had chosen to use
just for fun
manavortex
@manavortex
Go ahead :D
I switched to the ZOS function to convert IDs and links at some point, but that led to downstream exceptions
and at that point I wasn't really into it anymore
Sharlikran
@Sharlikran
yeah, but if I look at _SidTools_Custom.lua you are saying there should be some kind of utility function?