that returned true
but it's a recipie
that's not placeable furniture :D
And you can not run the game at all I take it?
I'll leave it running over night
It was a 10t
I forgot how my own fucking utility function works
FurC gobbles up every single item or recipe it sees
and the function to check if anything needs to be added checks if the data already exists, and skips in that case…
So that's probably what happened.
Okay well if you get it working sweet otherwise let me know because I was noticing
ShouldBeInFurC(link) uses link = FurC.GetItemLink(link) which is fine but if you don't get it working then I was going to try to use something more like if the link contains H1 or H0 then it's a valid link just use it and if not then go out and use FurC.GetItemLink(link) since that seems to generate a link using zo_strformat("|H1:item:<<1>>:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0|h|h", itemId) when you just have the item ID.
if it's not numerical, just return it
(null-proofing it so there are no exceptions)
It's why I kept the function, to make sure there were no nullpointer exceptions lmao
local function getItemLink(itemId)
if nil == itemId then return end
itemId = tostring(itemId)
if #itemId > 55 then return itemId end
if #itemId < 4 then return end
return zo_strformat("|H1:item:<<1>>:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0|h|h", itemId)
end
The function is so fucked-up because that throws zero exceptions
if it were up to me I would be more like
Trust me, it's happened before :joy:
local function getItemLink(itemId)
if nil == itemId then return end
local isItemId = itemId == 'number'
local isValidLink = string.match(itemId, "H0") or string.match(itemId, "H1")
if isValidLink return itemId end
if isItemId then return zo_strformat("|H1:item:<<1>>:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0|h|h", itemId) end
-- otherwise shit hit the fan
end
ShouldBeInFurc() deliberately does not add shit to the database :joy:
function ShouldBeInFurC(link)
link = FurC.GetItemLink(link)
local itemId = GetItemLinkItemId(link)
if IsItemLinkPlaceableFurniture(link) then
return nil == FurnitureCatalogue.settings.data[itemId]
end
if not IsItemLinkFurnitureRecipe(link) then return false end
for _, versionData in pairs(FurC.Recipes) do
for _, id in ipairs(versionData) do
if id == itemId then return false end
end
end
for _, versionData in pairs(FurC.FaustinaRecipes) do
if versionData[itemId] then return false end
end
for _, versionData in pairs(FurC.RolisRecipes) do
if versionData[itemId] then return false end
end
-- yeah okay, it should actually return false, but this is a util function for datamining
return nil == FurnitureCatalogue.settings.data[itemId]
end
just for fun
I switched to the ZOS function to convert IDs and links at some point, but that led to downstream exceptions
and at that point I wasn't really into it anymore