Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jun 20 11:36

    sirinsidiator on master

    8.0.6 (compare)

  • Jun 06 15:36

    sirinsidiator on master

    8.0.5 (compare)

  • Jun 06 15:32

    sirinsidiator on pts8.0

    8.0.5 (compare)

  • May 16 21:13

    sirinsidiator on pts8.0

    8.0.4 (compare)

  • May 09 20:34

    sirinsidiator on pts8.0

    8.0.3 (compare)

  • May 09 20:09

    sirinsidiator on master

    7.3.9 (compare)

  • May 02 18:08

    sirinsidiator on pts8.0

    8.0.2 (compare)

  • Apr 25 15:46

    sirinsidiator on pts8.0

    8.0.1 (compare)

  • Apr 25 10:57

    sirinsidiator on master

    7.3.8 (compare)

  • Apr 19 20:12

    sirinsidiator on pts8.0

    8.0.0 (compare)

  • Apr 18 15:10

    sirinsidiator on master

    updated ESOUIDocumentation.txt (compare)

  • Apr 11 15:45

    sirinsidiator on master

    7.3.7 (compare)

  • Mar 28 10:48

    sirinsidiator on master

    7.3.6 (compare)

  • Mar 18 11:50

    sirinsidiator on master

    updated ESOUIDocumentation.txt (compare)

  • Mar 14 22:39

    sirinsidiator on master

    7.3.5 (compare)

  • Mar 14 11:56

    sirinsidiator on pts7.3

    7.3.5 (compare)

  • Feb 28 17:57

    sirinsidiator on pts7.3

    7.3.4 (compare)

  • Feb 21 17:30

    sirinsidiator on pts7.3

    7.3.3 (compare)

  • Feb 14 18:23

    sirinsidiator on pts7.3

    7.3.2 (compare)

  • Feb 14 17:41

    sirinsidiator on master

    7.2.10 (compare)

manavortex
@manavortex
if it's not numerical, just return it
(null-proofing it so there are no exceptions)
It's why I kept the function, to make sure there were no nullpointer exceptions lmao
Sharlikran
@Sharlikran
local function getItemLink(itemId)
    if nil == itemId then return end
    itemId = tostring(itemId)
    if #itemId > 55 then return itemId end
    if #itemId < 4 then return end
    return zo_strformat("|H1:item:<<1>>:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0|h|h", itemId)
end
Well I'm not expert so looking at that, it's like if the length is longer than or less than then do something. I tend to do things the long way and because an Item ID can now be so long and since a real item link can also contain so much more then it did before I wanted to rewrite that to do it different
manavortex
@manavortex
If it ain't broke, don't fix it :joy:
The function is so fucked-up because that throws zero exceptions
Sharlikran
@Sharlikran
That's up to you
if it were up to me I would be more like
manavortex
@manavortex
If I touch that, then I'll get some user "BUT MANA, I TOUCHED THAT STATUE OF MOLAG BAL'S DICK, AND FURC THREW AN EXCEPTION"
Trust me, it's happened before :joy:
Sharlikran
@Sharlikran
local function getItemLink(itemId)
  if nil == itemId then return end
  local isItemId = itemId == 'number'
  local isValidLink = string.match(itemId, "H0") or string.match(itemId, "H1")
  if isValidLink return itemId end
  if isItemId then return zo_strformat("|H1:item:<<1>>:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0|h|h", itemId) end
  -- otherwise shit hit the fan
end
No worries, I know users do that but still. Everyone here including you always offers help when possible. Even if I chose to do it different. So naturally you don't have to do anything you don't want but that's what I was going for.
manavortex
@manavortex
<3 thank you
Sharlikran
@Sharlikran
Since you are not obligated to use that function I'm still curious. May I please ask when is ShouldBeInFurC() used? There is a comment at the end about getting information? Specifically data mining.
manavortex
@manavortex
Yeah, it's a utility function for my helper tool that uses SidTools
ShouldBeInFurc() deliberately does not add shit to the database :joy:
Sharlikran
@Sharlikran
Weird
function ShouldBeInFurC(link)
    link = FurC.GetItemLink(link)
  local itemId = GetItemLinkItemId(link)

    if IsItemLinkPlaceableFurniture(link) then                 
        return nil == FurnitureCatalogue.settings.data[itemId]
    end

    if not IsItemLinkFurnitureRecipe(link) then    return false end 

    for _, versionData in pairs(FurC.Recipes) do
        for _, id in ipairs(versionData) do
            if id == itemId then return false end
        end
    end
    for _, versionData in pairs(FurC.FaustinaRecipes) do
        if versionData[itemId] then return false end
    end        
    for _, versionData in pairs(FurC.RolisRecipes) do
        if versionData[itemId] then return false end
    end

    -- yeah okay, it should actually return false, but this is a util function for datamining
    return nil == FurnitureCatalogue.settings.data[itemId]
end
manavortex
@manavortex
Look at _SidTools_Custom.lua
Sharlikran
@Sharlikran
Because I thought about using that for my personal copy since I know that link will always be a itemLink with what I had chosen to use
just for fun
manavortex
@manavortex
Go ahead :D
I switched to the ZOS function to convert IDs and links at some point, but that led to downstream exceptions
and at that point I wasn't really into it anymore
Sharlikran
@Sharlikran
yeah, but if I look at _SidTools_Custom.lua you are saying there should be some kind of utility function?
manavortex
@manavortex
That is calling it
that thing is loaded by sidTools, then adds a hook to the item viewer to dump the data into its saved variables
Sharlikran
@Sharlikran
Well now I feel bad I'm asking too much but I didn't think this is what it did sorry
manavortex
@manavortex
That's not what it did, right. Hence the added function. :D
Sharlikran
@Sharlikran
from the description page, which slash command would I use?
manavortex
@manavortex
itemviewer, then populate it, then run /dumpfurniture and reload ui
then there'll be a list of strings that just needs a little bit of search and replace until it's directly ready for FurC's data files
Sharlikran
@Sharlikran
Darnet I don't know what the itemviewer is or how to populate it
I have furC but I kinda just let it show the tooltip
manavortex
@manavortex
sidtools is the other addon
image.png
Sharlikran
@Sharlikran
I think I used it once to search for something
manavortex
@manavortex
siri's
Sharlikran
@Sharlikran
Oh okay that screen shot helps, I'm gonna eat then and then come back to this
looks like I will be playing with it for a bit, thanks so far
manavortex
@manavortex
I use siri's addon to generate string entries in the saved variables of siri's addon that I can then copy and paste into FurC's data files
Sharlikran
@Sharlikran
ahhh
manavortex
@manavortex
I am a very, very lazy dev. :D And the volunteer fixed it by now and is currently in the "fuck around and find out" phase
Good night everyone :) <waves>
manavortex
@manavortex
Pull from github, there's a readme thingy in the data folder
shehi
@shehi
Sorry for waking up this necro topic, but a RU guildie of mine who is using EN client, is getting DATETIME format of DD.MM.YY. His Windows system is in RU.
That format I am getting with DE game client, my OS being in EN locale. I am totally confused. Isn't internal DATETIME format fixed for certain game client language?
When I run the client in RU, my DATETIME format is exactly like in EN: MM/DD/YY.
Sharlikran
@Sharlikran

@shehi Are you still trying to basically parse the string information from the guild date string and convert it to Epoch time?

German is probably YY//MM//DD and I would not be surprised if the date and time are different that is OS controlled under region settings.

Sharlikran
@Sharlikran
image.png
shehi
@shehi
No @Sharlikran , OS locale doesn't consistently affect game client DATETIME format. A Czech guildie using EN client has en-us locale, whereas Russian guildie with EN client has European DATETIME format we see in DE client. It's completely unreliable. And client's locale is affected by launcher. E.g.: in Launcher set it to a different locale, then start the game via eso.exe bypassing Launcher's PLAY button. Game won't start with new locale you chose, it will start with old one. I did a lot of testing yesterday discovering these. My guess is, when game is installed and started via Launcher the first time, it feeds locale from OS to the game, and that sticks there as locale of that chosen client language. After that whenever you come back to that client language, that "memorized" locale setting used again. That's how these two guys, one having RU and the other having CZ locales in their OS, using EN game client get different DATETIME formats.