by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jul 22 00:23

    carver on master

    Call a new hook when a transact… Merge pull request #1950 from c… (compare)

  • Jul 22 00:23
    carver closed #1950
  • Jul 22 00:16
    carver edited #1950
  • Jul 22 00:16
    carver synchronize #1950
  • Jul 22 00:16
    carver edited #1950
  • Jul 21 23:36
    carver review_requested #1950
  • Jul 21 23:32
    carver opened #1950
  • Jul 12 16:53
    Peppece synchronize #1937
  • Jul 12 16:28
    Peppece synchronize #1937
  • Jul 12 16:26
    Peppece synchronize #1937
  • Jul 12 16:19
    Peppece synchronize #1937
  • Jul 11 15:32
    Peppece synchronize #1937
  • Jul 11 14:08
    Peppece edited #1937
  • Jul 09 11:52

    cburgdorf on master

    Remove unused add_uncle API (compare)

  • Jul 09 11:52
    cburgdorf closed #1949
  • Jul 09 09:07
    cburgdorf synchronize #1949
  • Jul 08 07:46
    cburgdorf commented #1949
  • Jul 07 15:52
    carver commented #1949
  • Jul 07 08:39
    cburgdorf commented #1949
  • Jul 07 08:37
    cburgdorf review_requested #1949
Peilin Zheng
@tczpl
then
oh i want 2 fuck myself
Maybe the most error is that I dont have a Mac
I have destroy my server. My operation is totally bullshit.
sorry for all, bye
image.png
Peilin Zheng
@tczpl
nobody cares about my fault, mayebe it's just my fault
i am sorry
Peilin Zheng
@tczpl
image.png
anybody hear me please...i follow the wiki (build your first app), but this erro shows...what can I do ...thankyou!
Peilin Zheng
@tczpl
i m fine. Thank you!
Jason Carver
@carver
cool, glad you got it working. next time you get stuck, you can try ethereum.stackexchange.com , which may have answers for you already. Whether you post in this room or on there, you'll get more help if you use a reproducible example. These are great guidelines: https://stackoverflow.com/help/minimal-reproducible-example
Tommy
@hyperevo
I seem to have found a pruning bug in py-trie. Was hoping I might be able to get some help with it from you guys.
On the 129th iteration of that loop, it gives an exception that says one of the nodes is missing
It actually came up when I was creating the trie root and nodes for a list of transactions in a block. But this example isolates the problem I believe.
Jason Carver
@carver
Cool, thanks for reporting. Have you filed an issue yet? If you tag me on it, I'll be sure to take a look today
Voith Mascarenhas
@voith
@fubuloubu @carver Why is the istanbul fork inheriting everything from Constantinople and not Peterburg? IIUC, Petersberg is the fixed version of Constantinople. So shouldn’t Istanbul inherit from Peterburg? Am I missing something?
Nick Savers
@nicksavers
Agreed
Voith Mascarenhas
@voith
*Petersburg (lol, I have some really bad typos there)
Jason Carver
@carver
Yup, that's a bug
Bryant Eisenbach
@fubuloubu
I think I made it before Petersburg
Jason Carver
@carver
We should update it, but I don't think it changes anything in practice, since sstore gets redefined, and that was the only change in Petersburg, iirc
Voith Mascarenhas
@voith
@carver I just checked. Tests are failing. Looks likes sstore changes were to Constantinople rather than Petersburg.
Voith Mascarenhas
@voith
Oops, I spoke too fast. EIP1283 was removed in Petersburg. So the tests are broken IMO. Lets see
Voith Mascarenhas
@voith
Tests are correct. I had to re-enable allow_negative_refund_strategy for Istanbul
Voith Mascarenhas
@voith
Voith Mascarenhas
@voith
I got py-evm to pass all ethereum/tests for Istanbul locally. However, tests are crashing on CircleCI. Details for the test failure are here: https://github.com/ethereum/py-evm/pull/1852#issuecomment-533900250
Noel Maersk
@veox
@voith Sorry I can't help better with PR #1852 ATM. I made some bad choices y-day, and ended up with a hangover.
But from the failing test names, it looks like the same bunch as already in INCORRECT_UPSTREAM_TESTS.
There's still the disconnect between py-evm and all other implementations - including parity-ethereum, which caved in and did it like go-ethereum does.
The particular issue is not covered in any EIP, and is about a "synthetic" state of a contract that can't be arrived to by regular EVM operation.
Noel Maersk
@veox
So, perhaps add the _Istanbulvariants of InitCollision et. al. to INCORRECT_UPSTREAM_TESTS, and see what actual issues remain.
Voith Mascarenhas
@voith

I made some bad choices y-day, and ended up with a hangover.

Haha, hope it was good :D

@veox Thank you for your help
I have some free time now and I will dig into the tests just to double check that these tests are in fact incorrect.
irenemae
@irenemae
@cburgdorf hi everyone!!!newbie here:)
Dimitri Saingre
@Prygan
Hi everyone :) does anyone knows here if it is possible to read the leveldb chain data generated by geth from python with py-evm ?
Jason Carver
@carver
I know it's possible to read state data out of the geth leveldb store, but can't natively read out chain data. It would be reasonable to write an adapter, if you're interested in a project :)
Jason Carver
@carver
eth-tester with istanbul support is out: v0.2.0-beta.3 @/all
Noel Maersk
@veox
@voith I'm taking a look at PR #1852, if you don't mind. Not even past the "run successfully locally" step yet: the fixtures take too long, SLOWEST_TESTS is unpopulated with static_Call50000 (and family) for Istanbul, and on some test (don't know the name yet, because I first ran it in tox) it just hangs... Might be GeneralStateTests/stTimeConsuming/CALLBlake2f_MaxRounds.json, will see.
Voith Mascarenhas
@voith
@veox Please feel free to take it over. I won’t be able to look at it before Devcon
Noel Maersk
@veox
(Plus, Python 3.6 (as in PR) is slow IIRC.)
Voith Mascarenhas
@voith
Blake2f implementation in python is not very efficient and its expected to be slow. But need to find out which tests needed to be marked as slow
Noel Maersk
@veox
Yup, that's what I'll be doing first. I'm assuming stTimeConsuming will all be there.
Voith Mascarenhas
@voith
yeah seems reasonable. There’s a test called CALLBlake2f_MaxRounds_d0g0v0_Istanbul which has high possibility of running extremely slow.
Just learnt that the old blake2b library has been replaced by a better performing one:
ethereum/py-evm#1854.
But the tests will still need to be marked slow
Jason Carver
@carver
@veox that faster blake2b implementation is in a newer release of py-evm. I highly recommend upgrading to that as part of the branch
Noel Maersk
@veox
@carver Thanks, didn't notice.