ethereum/remix-dev-plugin

yann300

@yann300

The thing I wanted to ask is if Remix team is ok with adding a cross-blockchain integration or not?

yes there's no restriction around that and there's already a plugin for quorum @vasa-develop

vasa

@vasa-develop

:thumbsup:

Loredana Cirstea

@loredanacirstea

@yann300 , I was trying out compileWithParameters for the Yul+ plugin on Remix-alpha:

const contract = {
          "storage.sol": {content :  simpleContract }
      }
const compiled = await remixclient.call('solidity', 'compileWithParameters', contract, {
        evmVersion: null,
        optimize: true,
        language: 'Yul',
        version: '0.5.7+commit.6da8b019',
      });

And it returns undefined. Also, what kind of magic is: \`${simpleContract}\` from https://github.com/ethereum/remix-ide/commit/c2c8c76952d7e37396b4de38788609d2c16c4d45#diff-926d0d0ed0d5905d03ef743fa69c4977R72?

yann300

@yann300

did you try in remix or remix-alpha (this is soon to be deployed to remix live)
${simpleContract}\ is just https://github.com/ethereum/remix-ide/blob/master/test-browser/tests/compiler_api.test.js#L39

Loredana Cirstea

@loredanacirstea

Ii tried in remix-alpha

I was talking about the \` and \` enclosing. I get a parsing error if I copy that code exactly - from the first slash.

yann300

@yann300

can you send me the simple contract you are trying to compile (is this the same as in the test?)

Loredana Cirstea

@loredanacirstea

same as in the test

Loredana Cirstea

@loredanacirstea

@yann300 , sorry, Solidity compilation works. Yul compilation didn’t - I am probably missing something. The correct coompiler version is loaded on demand:

Screen Shot 2020-07-08 at 12.30.39 PM.png

yann300

@yann300

we are going to update remix-alpha in a few minutes, will tell you when it's updated

Loredana Cirstea

@loredanacirstea

@yann300 , it works. I had a bug in the code and no compiling errors were returned, hence the confusion.

yann300

@yann300

we've updated it so you'll get the error back

@step21_gitlab

@yann300 do you think about the syntax highlighting thing, does it make sense to post in ethereum stackexchange, or on stack overflow?

I’m really stuck

yann300

@yann300

you already tried to base your syntax highlighting lib from https://github.com/ethereum/remix-ide/blob/master/src/app/editor/editor.js#L18 right?

@step21_gitlab

Yeah. that is why it is so weird. except for the rules, my code is pretty much the same (last time I checked… maybe I should do a diff again) but one works and the other doesn't

(or actually maybe I only compared manually, not sure anymore)

yann300

@yann300

did you publish it to npm?

@step21_gitlab

yes https://www.npmjs.com/package/ace-mode-lexon

diff is here https://www.pastery.net/xhncdb/

yann300

@yann300

is this correctly defined in the remix-ide deps?

Loredana Cirstea

@loredanacirstea

@yann300 , I can confirm that now I receive the compilation errors on remix-alpha. So the wierd thing was Yul+ has an output like function Calldata.sig.position(_pos) -> _offset { Notice the function name separated by .. With the npm solc package (web wrapper), I could compile this. But not with the solc-bin loaded solc compiler - I had to replace all . with _. But this is a solc issue, not a Remix one.

@step21_gitlab

@yann300 I think so. https://github.com/step21/remix-ide/blob/ace-mode-lexon/src/app/editor/editor.js#L19 and https://github.com/step21/remix-ide/blob/ace-mode-lexon/src/app/editor/editor.js#L88

(and with outputting exentsion, I verified that the extension is detected. only then mode is not loaded.

yann300

@yann300

where do you get the error?

@step21_gitlab

in the browser console and prob also on terminal

Liana Husikyan

@LianaHus

what is the issue with highlight?

@step21_gitlab

one sec I’ll pull up the log

@step21_gitlab

https://www.pastery.net/aphzjf/ (this is console log)

browser console is

 extension is  zok app.js:261876:15
extension is  lex app.js:261876:15
GEThttp://localhost:8080/mode-lexon.js
[HTTP/1.1 404 Not Found 14ms]

Laden fehlgeschlagen für das <script> mit der Quelle "http://localhost:8080/mode-lexon.js". localhost:8080:1:1

(this is after loading and then first clicking/loading zok file and then clicking/loading lex file)

(no plugins loaded but afaik that shouldn’t matter)

I search in ace/brace github issues / stackoverflow but nothing quite applied or worked sor far, so like I am a bit stuck unfortunately

yann300

@yann300

@loredanacirstea that's indeed weird.. is this the same compiler version?
would be nice to get feedback from solidity team about this

Loredana Cirstea

@loredanacirstea

same compiler version: 0.5.7 (loredanacirstea/remix-yulp-plugin@f32c95e) - maybe this is not a problem anymore in the latest versions, but Yul+ only works on 0.5.7 now.

Liana Husikyan

@LianaHus

@yann300 I think so. https://github.com/step21/remix-ide/blob/ace-mode-lexon/src/app/editor/editor.js#L19 and https://github.com/step21/remix-ide/blob/ace-mode-lexon/src/app/editor/editor.js#L88

do you have it in your package-lock file?

yann300

@yann300

@edisinovcic would you be able to help on this? @step21_gitlab try to add ace-mode-lexon.js in remix editor but that doesn't work..
any tricky things you needed to do for ace-mode-zokrates ?
thanks for helping

Liana Husikyan

@LianaHus

Yann in the PR -lock file should be also updated/pushed

@step21_gitlab

@LianaHus in package-lock it is

"ace-mode-lexon": {
      "resolved": "https://registry.npmjs.org/ace-mode-lexon/-/ace-mode-lexon-1.0.4.tgz",

Darko Macesic

@dark64

@step21_gitlab just noticed you define the callback as function(require, exports, module) but you require with acequire in the function body, so it should be function(acequire, exports, module)

@step21_gitlab

Thanks!

will check it

Edi Sinovcic

@edisinovcic

@dark64 can you take a look?

@step21_gitlab

@dark64 thanks a bunch. that was it.

@edisinovcic thanks to you too.

and @yann300 and @LianaHus of course too.

you’re the best

Liana Husikyan

@LianaHus

great!

thanks you

Where communities thrive

People

Repo info

Activity