Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 23:02
    matheusaaguiar synchronize #13177
  • 23:02

    matheusaaguiar on check-overflow-after-mul-operation

    Improved check for int256 speci… (compare)

  • 21:49
    matheusaaguiar synchronize #13177
  • 21:49

    matheusaaguiar on check-overflow-after-mul-operation

    Added formal tests of cleanup f… Fix uint and int formal tests. Improved check for int256 speci… (compare)

  • 21:29
    ekpyron closed #12556
  • 21:29
    ekpyron commented #12556
  • 21:26
    leonardoalt commented #12556
  • 21:25
    leonardoalt commented #11192
  • 21:20
    leonardoalt commented #13287
  • 21:19
    leonardoalt commented #13370
  • 21:17
    leonardoalt commented #12568
  • 21:14
    leonardoalt closed #13033
  • 21:14
    leonardoalt commented #13033
  • 21:12
    leonardoalt closed #12890
  • 21:12
    leonardoalt commented #12890
  • 21:04
    leonardoalt commented #12132
  • 21:02
    leonardoalt closed #9259
  • 21:02
    leonardoalt commented #9259
  • 20:59
    leonardoalt closed #12095
  • 20:59
    leonardoalt commented #12095
ekpyron
@daniel:ekpyron.org
[m]
At one point that was intentional (and we even specifically had the experimental warning in there and everything)... but it's true, nowadays, it's primarily annoying :-).
1 reply
Marenz
@m4renz:matrix.org
[m]
Though it is a repeating pattern as well
Marenz
@m4renz:matrix.org
[m]
hmm I mean.. that would be a super easy solution: Just make it a comment :D
cameel
@cameel:matrix.org
[m]
Haha, well that would work. but then it would look as a part of the file (it's not).
ekpyron
@daniel:ekpyron.org
[m]
I mean, similarly to the error thing: the CLI is generally not primarily meant to be what produces machine-readable output anyways... look at what --bin and --bin-runtime (especially taken together) do...
1 reply
Machine-consumption is expected to use standard-json.
Of course a bit annoying for classic piping :-).
ekpyron
@daniel:ekpyron.org
[m]
cameel: my initial reaction to those python assert PRs would have been the same as yours, but https://github.com/ethereum/solidity/pull/13383#issue-1335799140 I actually wasn't aware of and it does in fact seem a bit weird :-D.
(that's why I assigned you, since based on that I wasn't sure about it :-))
Not that python optimization stuff is something that is relevant for those CI scripts.
Ah, ok, now you closed both, then it's fine :-).
cameel
@cameel:matrix.org
[m]
Yeah, both are basically the same thing, just in different scripts.
In Python you can technically disable asserts, just like in C++. It's just that in Python there's no binary so you have to select that optimized mode when you run the script.
And it's not the default.
So in practice they're always there.
ekpyron
@daniel:ekpyron.org
[m]
Yeah, sure, what I meant is that I actually found it surprising that those assertions can vanish :-). But yeah, https://github.com/ethereum/solidity/pull/13383#issuecomment-1212160463 is a good point and even if it wasn't there's no call to ever "compile" those scripts anyways.
cameel
@cameel:matrix.org
[m]
Well, you could compile them to bytecode and run that without having the source.
I think that this would then persist.
But no one does that. At least not with open source stuff.
ekpyron
@daniel:ekpyron.org
[m]
At least not with CI scripts :-).
cameel
@cameel:matrix.org
[m]
I know that Arch includes compiled bytecode in packages along with sources.
ekpyron
@daniel:ekpyron.org
[m]
Yeah, I've seen packages shipping sources and bytecode.
cameel
@cameel:matrix.org
[m]
But that's only because source dirs are not writable so Python would not be able to generate it on the fly.
So you'd get bytecode compilation on every run.
I'm done for today and because of all the small stuff didn't manage to get to the labels yet. I'm going to work on that tomorrow morning so that we can have a call in the afternoon.
Actually, I do have a very crude initial idea. Maybe I'll just paste that into a note so that you can have a look now. It's still incomplete and will change.
ekpyron
@daniel:ekpyron.org
[m]
Sounds good!
cameel
@cameel:matrix.org
[m]
I still don't know how to make these notes owned by the org public though :)
Can you read it?
ekpyron
@daniel:ekpyron.org
[m]
I actually have a dedicated browser to keep logged into the org account solely for reading these things :-D. So yeah, I can read it :-).
cameel
@cameel:matrix.org
[m]
ok. good.
ekpyron
@daniel:ekpyron.org
[m]
And at a first glance, it does look nice - but I'll have a closer look and we can chat tomorrow :-).
cameel
@cameel:matrix.org
[m]
Sure.
Just one note: it gets hairy when you try to go into details but my overall impression after thinking about it was that maybe even just having the effort+impact combo would improve filtering a lot :) Maybe with a help of some controversial label to filter out proposals we have mixed feeling about and are unlikely to implement.
ekpyron
@daniel:ekpyron.org
[m]
Yeah, may be... Unfortunately, Effort is often the hardest thing to judge in advance :-).
We may need "Effort: unknown" :-D.
cameel
@cameel:matrix.org
[m]
That's why it can't be very precise but it's still useful to know if this is a multi-stage feature or a one-line change.
We could have unknown but I suspect that a lot of the time it will be just a code for high :)
I'll try to think of some ways to describe it other than low and high. Maybe that will make it easier to assign.
ekpyron
@daniel:ekpyron.org
[m]
Yeah, the problem is often that once you actually know how much effort it is, you're also basically done :-D. But yeah, let's talk tomorrow, don't want to keep you here, if you wanted to finish up for today ;-).
Marenz
@m4renz:matrix.org
[m]
"need" is such a strong word
ekpyron
@daniel:ekpyron.org
[m]
For the quotes :-)?
I mean, one may think about that what one wants, but there are people with spaces in their paths :-).
Marenz
@m4renz:matrix.org
[m]
yah
ekpyron
@daniel:ekpyron.org
[m]
Not sure if such theoretical people should run a release script, though :-D.
Marenz
@m4renz:matrix.org
[m]
you think spaces woudl break it already?
ekpyron
@daniel:ekpyron.org
[m]
I'd guess so.
Marenz
@m4renz:matrix.org
[m]
hmm yeah, probably
abc=test this
zsh: command not found: this
ekpyron
@daniel:ekpyron.org
[m]
Yeah... or
$ source "a b/test"
$ source a b/test
bash: a: No such file or directory
$ export TEST="a b/test"
$ source "$TEST"
$ source $TEST
bash: a: No such file or directory