Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 02:37
    aarlt synchronize #11110
  • 02:37

    aarlt on issue_10475_isoltest_external_sources

    [isoltest] Add support for exte… (compare)

  • Apr 22 21:29
    christianparpart commented #11273
  • Apr 22 21:25
    christianparpart commented #11273
  • Apr 22 20:38
    axic commented #11273
  • Apr 22 20:24
    aarlt synchronize #11110
  • Apr 22 20:24

    aarlt on issue_10475_isoltest_external_sources

    [isoltest] Add support for exte… (compare)

  • Apr 22 20:00
    cameel labeled #11297
  • Apr 22 20:00
    cameel labeled #11297
  • Apr 22 20:00
    cameel commented #11297
  • Apr 22 19:59
    cameel assigned #11298
  • Apr 22 19:59
    cameel opened #11298
  • Apr 22 19:57

    cameel on docs-no-external-constructors

    0.7.0 breaking changes: There w… (compare)

  • Apr 22 19:51
    cameel commented #11273
  • Apr 22 19:21

    axic on returnVariableZeroReplacementAddendum

    (compare)

  • Apr 22 19:13
    barakman opened #11297
  • Apr 22 18:38
    cameel commented #10286
  • Apr 22 18:37
    cameel commented #10286
  • Apr 22 18:16
    cameel synchronize #10286
  • Apr 22 18:16

    cameel on yul-evmasm-optim

    Improve Yul object test to avoi… Move optimiser settings transla… Add sstore to linker tests to p… and 4 more (compare)

chriseth
@chriseth:matrix.org
[m]
Use let
axic
@axic:matrix.org
[m]
Don't use JS but use TS
chriseth
@chriseth:matrix.org
[m]
var is just like var in sol
leo
@leonardoalt:matrix.org
[m]
just lost an hour of my life because of this
ffs
axic
@axic:matrix.org
[m]
lol
chriseth
@chriseth:matrix.org
[m]
Why don't you just ask?
leo
@leonardoalt:matrix.org
[m]
it didn't cross my mind that this would be the problem
I was looking for the issue in other places
chriseth
@chriseth:matrix.org
[m]
Or learn the verye elementary basics of js before you start working with it?
1 reply
axic
@axic:matrix.org
[m]
Would be nice if instead of making mistakes, the person could anticipate an upcoming mistake and ask for directions before it happens.
2 replies
chriseth
@chriseth:matrix.org
[m]
Yes, it's always the others!
axic
@axic:matrix.org
[m]
Are you writing production code in JS now?
leo
@leonardoalt:matrix.org
[m]
well, blaming JS's scope is a very fair thing always
do you consider solc-js production?
I did anticipate the issue was "something about JS I didn't know about", and was looking for things in that direction, like async etc
was caught by surprise
leo
@leonardoalt:matrix.org
[m]
axic: https://github.com/uuverifiers/eldarica
this Horn solver recently added the missing logics that the SMTChecker needs, so I'm trying it out on our test suite
it doesn't have a c++ api, so I'm running it via the callback
Works quite nicely.
in some examples it performs better than Spacer
chriseth
@chriseth:matrix.org
[m]
Cool!
Alexander Arlt
@aarlt
@cameel:matrix.org are you still here?
if we have something like this:
==== ExternalSource: _non_normalized_paths/a.sol ====
==== ExternalSource: _non_normalized_paths//b.sol ====
==== ExternalSource: C/////c.sol=_non_normalized_paths/c.sol ====
==== ExternalSource: C/../////D/d.sol=_non_normalized_paths///d.sol ====
import "_non_normalized_paths/a.sol";
import "_non_normalized_paths/b.sol";
import "C/c.sol";
import "D/d.sol”;
the imports only work, because i normalized them in TestCaseReader
they need to be exactly as defined by the remapping, if we dont normalize
e.g.
==== ExternalSource: _non_normalized_paths/a.sol ====
==== ExternalSource: _non_normalized_paths//b.sol ====
==== ExternalSource: C/////c.sol=_non_normalized_paths/c.sol ====
==== ExternalSource: C/../////D/d.sol=_non_normalized_paths///d.sol ====
import "_non_normalized_paths/a.sol";
import "_non_normalized_paths//b.sol";
import "C/////c.sol";
import "C/../////D/d.sol";
but I’m not sure whether this is the behaviour we expected to have
cameel
@cameel:matrix.org
[m]
Yes, this is the expected behavior.
For better or worse.
Alexander Arlt
@aarlt
ah ok
cameel
@cameel:matrix.org
[m]
It might be different when I'm done with paths. But even then adding normalization would be a breaking change.
So we would only introduce it in 0.9.0 I think.
Alexander Arlt
@aarlt
somehow i thought that the compilerstack is also normalizing..
cameel
@cameel:matrix.org
[m]
For now, you should just assume that there is no normalization.
Alexander Arlt
@aarlt
ah ok, so you add the normalization later?
cameel
@cameel:matrix.org
[m]
Yeah, it's a natural assumption in my opinion :) Part of the reason why I want to change it.
Alexander Arlt
@aarlt
makes sense :)
cameel
@cameel:matrix.org
[m]
Basically, if you do import "C/../////D/d.sol"; then the compiler expects to find exactly C/../////D/d.sol in its VFS.
So if you use Standard JSON, you have to use that name.
But if it's not in the VFS, the compiler will invoke the file loader.
Alexander Arlt
@aarlt
i was also trying to find the problem for the windows test.. but i guess its related to the normalization.. so i will just remove that and then lets see what is the case in windows
cameel
@cameel:matrix.org
[m]
And the file loader will only then normalize the path.
Alexander Arlt
@aarlt
ah k, great
cameel
@cameel:matrix.org
[m]
But only for filesystem lookup.
Once it finds D/d.sol on disk it will give the content to CompilerStack and CompilerStack will put it under C/../////D/d.sol, not D/d.sol.
Yeah, I would guess normalization.
I took a look but the output was a jumbled mess. I think it's easier to fix normalization first and only then try to figure it out. Maybe it will go away so you will not have to :)
Alexander Arlt
@aarlt
yeah i thought the same
StackenBotten
@stackenbotten
✅ Nightly job t_ems_test_ext_colony succeeded on develop. Please see https://circleci.com/gh/ethereum/solidity/695454 for details.
StackenBotten
@stackenbotten
❌ Nightly job t_ubu_ossfuzz failed on develop. Please see https://circleci.com/gh/ethereum/solidity/695459 for details.