Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 15:17
    ekpyron commented #7878
  • 15:12
    MicahZoltu commented #7455
  • 15:11
    christianparpart commented #2296
  • 15:07
    chriseth commented #7455
  • 15:00
    christianparpart commented #7738
  • 14:21
    MicahZoltu commented #7455
  • 13:10
    erak synchronize #7914
  • 13:10

    erak on solidity-upgrade-basic

    Implements the basic version of… (compare)

  • 13:06
    saarshah opened #423
  • 13:05
    leonardoalt commented #7878
  • 13:05
    leonardoalt commented #7878
  • 12:04
    axic edited #2100
  • 12:02
    axic commented #7913
  • 11:54
    christianparpart commented #7916
  • 11:53
    christianparpart synchronize #7916
  • 11:53

    christianparpart on fix-testcase-invalid-evmversion-handling

    test: Improve handling invalid … (compare)

  • 11:51
    christianparpart edited #7916
  • 11:50
    christianparpart edited #7916
  • 11:36
    christianparpart review_requested #7916
  • 11:36
    christianparpart edited #7916
Alex Beregszaszi
@axic
actually think the real lines of code is a better metric as it means that much needs to be processed by the eye
chriseth
@chriseth
@axic yul has many small files, so tons of license comments
@ekpyron isn't it a problem if there are multiple cut vertices?
chriseth
@chriseth
argh, modifier override checks are almost not implemented ::rage::
checking the override set is not done, ambiguous overrides are not done
Daniel Kirchner
@ekpyron
Haven't looked into modifiers or state variables yet... but no - multiple cut vertices are exactly not a problem, if I just remove all "above" them - only the "lowest" cut vertex is relevant anyways, so removing stuff above "higher" ones doesn't matter and I'm always left with the correct stuff "below the lowest" cut vertex.
Daniel Kirchner
@ekpyron
But yeah - you're change using inheritedFunctions is almost right - it's almost the same as the nonOverridenBaseFunctions I had.
But it contains constructors, so you have to exclude them.
But otherwise it's exactly the same set...
chriseth
@chriseth
Adding modifiers should also be no big deal because they have a shared base
Hm, we should probably exclude costructors in the inheritedfunctions function already
Ah i see! I was thinking about parallel cut vertices, actually
Shouldnt we exclude that casex
?
Daniel Kirchner
@ekpyron
What's a "parallel cut vertex" :-)?
If there's more than one parallel one, then it's not a cut vertex...
chriseth
@chriseth
Ok, good!
chriseth
@chriseth
Ready for review: ethereum/solidity#7878
Leonardo
@leonardoalt
I'll review in 1h if no one has done it yet
Also want to review the latest inheritance stuff in general
Alex Beregszaszi
@axic
Q: are we adding solidity@0.5 to homebrew when 0.6 is released?
Chris Chinchilla
@ChrisChinchilla
Seems like a good idea, and depreciate 4? Or keep it?
Alex Beregszaszi
@axic
I don’t see a reason to drop it
@christianparpart you could review and leave your opinion on #2136, #1687 and #7738
Chris Chinchilla
@ChrisChinchilla
@axic It’s not hard to maintain, I just wasn’t sure what our policy was on version maintenance
Alex Beregszaszi
@axic
Created an issue to track ethereum/solidity#7915
Leonardo
@leonardoalt
@chriseth are you working today?
Leonardo
@leonardoalt
@erak you there?
Erik K
@erak
@leonardoalt Yes. Sorry, had a long night with solidity-upgrade (which is working now) and started pretty late...
Leonardo
@leonardoalt
no worries, just wanted to ask if it would be hard to make solidity-upgrade fix one specific error we're seeing in the external tests
which is: unimplemented functions outside interfaces should be explicitly marked virtual
Erik K
@erak
@leonardoalt Should be there already. Let me check
Erik K
@erak
I found Functions without implementation must be marked virtual. and that one can be fixed automatically. Which external test is it?
Leonardo
@leonardoalt
I think Colony has tons of those
I fixed Gnosis manually, but Colony has way too many
Erik K
@erak
Haha, ok. I just ran with Gnosis and it couldn't find any upgrades. That's why ;-)
Leonardo
@leonardoalt
yea I think there were just 2 or 3 there
Erik K
@erak
Well, Colony can be fixed automatically!
Leonardo
@leonardoalt
Yes!
Erik K
@erak
Done :)
I'll push them
Leonardo
@leonardoalt
Thanks
Also, if you have some time to review ethereum/solidity#7894
It might look large, but each commit is easy to review separately
Erik K
@erak
I'll review it now.
Ah, I've also pushed some more virtual keywords to the zeppelin repository.
chriseth
@chriseth
@leonardoalt no
Leonardo
@leonardoalt
ok
chriseth
@chriseth
@leonardoalt about https://github.com/ethereum/solidity/pull/7878#pullrequestreview-328194443 - two diamonds on top of each other?
Leonardo
@leonardoalt
what about the two diamonds?