by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 19:59
    chriseth synchronize #9465
  • 19:59

    chriseth on unchecked

    Var is also reserved. (compare)

  • 19:18
    leonardoalt synchronize #9885
  • 19:18

    leonardoalt on smt_array_slices

    Support array slices (compare)

  • 19:17
    leonardoalt review_requested #9885
  • 19:15

    chriseth on develop

    EVMHost: keep precompile balanc… Add more semantic tests for bal… Merge pull request #9887 from e… (compare)

  • 19:15

    chriseth on evmhost

    (compare)

  • 19:15
    chriseth closed #9887
  • 19:14
    leonardoalt commented #9885
  • 19:13
    leonardoalt ready_for_review #9885
  • 19:13
    leonardoalt commented #9885
  • 19:13
    leonardoalt synchronize #9885
  • 19:13

    leonardoalt on smt_array_slices

    Support array slices (compare)

  • 19:11
    chriseth edited #9465
  • 19:11
    chriseth synchronize #9465
  • 19:11

    chriseth on unchecked

    Checked arithmetic by default. Grammar for unchecked. Wrapping arithmetics for Yul IR. and 1 more (compare)

  • 18:53
    lidiia-eld commented #9875
  • 18:42
    chriseth synchronize #9465
  • 18:42

    chriseth on unchecked

    Update existing tests. (compare)

  • 18:35
    axic commented #9888
chriseth
@chriseth
there are error recovery tests, maybe we should just include them in the scan
Daniel Kirchner
@ekpyron

There are quite a few moving parts and decisions so I have written down a summary of what we discussed today for my own reference: https://github.com/ethereum/solidity/issues/9258#issuecomment-651220312

@ekpyron This might be of interest to you. Sorry that it's a bit long. I tried to organize and trim it a little but it's still based on a live discussion so not very organized overall.

:+1:

chriseth
@chriseth
@cameel updated a detail in the Hosting binaries on IPFS section
Kamil Śliwak
@cameel
@chriseth Thanks. That reminds me that we actually didn't discuss one important detail: what about the GH pages size limit?
chriseth
@chriseth
@cameel that will hopefully be solved by ignoring old nightly builds and replacing them by redirects to ipfs
Kamil Śliwak
@cameel
So we'll be manually deleting old nightlies once the repo fills up (still keeping them in history of course)?
Or should that be automated?
chriseth
@chriseth
no, the jekyll site renderer should do this
gh pages is the result of jekyll running on the gh-pages branch
Kamil Śliwak
@cameel
Ah, I see. So don't delete them, just don't render them?
chriseth
@chriseth
exactly
Kamil Śliwak
@cameel
Sounds good. I'll add it to the summary.
chriseth
@chriseth
one problem we should also check if the .js files are maybe too large for the ipfs gateway...
Kamil Śliwak
@cameel
Right.
Alex Beregszaszi
@axic
The new eth2 testent (altona) uses the solidity deposit contract 🎉
chriseth
@chriseth
nice!
Alex Beregszaszi
@axic
It is verified on goerli.etherscan.io, I tried verifying the Vyper weeks ago but it just never worked.
I’ll try to verify it on source-verify later today, for dogfooding
chriseth
@chriseth
@axic just push the medatata and sources to ipfs - it "should" just work
(depending on how long ago the deployment was)
Alex Beregszaszi
@axic
is it checking goerli?
chriseth
@chriseth
sure
Alex Beregszaszi
@axic
still compiling 0.6.8 as i deleted it
a3d4
@a3d4

@chriseth

do you need that for an error id?

Yes.

there are error recovery tests, maybe we should just include them in the scan

OK, makes sense to add recovery tests to the scan. What about command line tests?

chriseth
@chriseth
@a3d4 yes, add them, too
@leonardoalt is it true that with regards to the information about storage I can gather right after the statement, the following statements are equivalent: sstore(a, b) and b := sload(a)
chriseth
@chriseth
ah, I think literal content currently does not yet work :(
Alex Beregszaszi
@axic
too bad! it has been compiled with that
tried the manual tool:
Could not match on-chain deployed bytecode to recompiled bytecode for: { "deposit_contract.sol": "DepositContract" }
chriseth
@chriseth
ping edi to implement it :)
Alex Beregszaszi
@axic
the contract has 1684 transactions and most of them cost 60k gas
chriseth
@chriseth
nice: sol->yul optimizes function f(uint[] storage x) returns (uint sum) { for (uint i = 0; i < x.length; i ++) sum += i[x]; } into a single sload for the length that is moved in front of the loop, even though the original code contains 2 sloads per iteration!
ah, computing the slot is not pulled out of the loop yet :(
ah, and pulling out the computation of the slot would need memory objects, because if the loop is not executed at all, we do not write a zero to zero in memory, otherwise we do
Alex Beregszaszi
@axic
Solidity preprocessor: https://github.com/Lamarkaz/psol
Alex Beregszaszi
@axic
Leonardo
@leonardoalt
@chriseth that sounds correct to me. But what context are you talking about?
chriseth
@chriseth
@leonardoalt the optimizer. It is currently optimizign sstore(a, b) x := sload(a) -> sstore(a, b) x := b but not b := sload(a) c := sload(a) -> b := sload(a) c := b
and I think it can be done in exactly the same component
chriseth
@chriseth
@cameel it turns out that the ipfs gateway actually does use text/plain for our .js files :(
but I heard there might be a workaround, let me try that
chriseth
@chriseth
ah ok weird
the content-type is properly reported, but remix stil fails because the file is truncated. Maybe I uploaded the wrong truncated version :)
yes, it is the truncated version :)
StackenBotten
@stackenbotten
❌ Nightly job t_ubu_ossfuzz failed on develop. Please see https://circleci.com/gh/ethereum/solidity/369327 for details.
Leonardo
@leonardoalt
@chriseth yea sounds like it. I'll take a look
Leonardo
@leonardoalt
ah wait, you already wrote it