Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 02:48
    wberr opened #10469
  • 02:20
    cameel commented #10446
  • 02:13
    cameel commented #10409
  • 02:12
    cameel commented #10409
  • 01:34
    cameel commented #10429
  • 01:18
    cameel synchronize #10429
  • 01:18

    cameel on fix-and-enable-external-tests

    fixup! Update Gnosis external t… (compare)

  • 00:48
    cameel edited #10465
  • 00:47
    cameel edited #10429
  • 00:45
    cameel edited #10464
  • 00:45
    cameel edited #10464
  • 00:44
    cameel edited #10466
  • 00:43
    cameel commented #10468
  • 00:42
    cameel edited #10468
  • 00:42
    cameel edited #10468
  • 00:42

    cameel on force-latest-truffle-for-ens

    (compare)

  • 00:42

    cameel on run-external-tests-nightly

    Run external tests only nightly… Switch the external tests back … (compare)

  • 00:42
    cameel synchronize #10468
  • 00:42
    cameel synchronize #10466
  • 00:42

    cameel on update-external-tests-for-0.8.0

    Don't run Gnosis external tests… Update to 0.8.0 versions of sol… (compare)

Leonardo
@leonardoalt
@christianparpart I'm not sure, but maybe in Yul that's done by an optimizer?
Christian Parpart
@christianparpart
:D - thx @leonardoalt :)
Leonardo
@leonardoalt
just guessing though, I have no evidence
Harikrishnan Mulackal
@hrkrshnn
@christianparpart what check? Can you give an example?
Christian Parpart
@christianparpart
https://github.com/ethereum/solidity/blob/develop/test/libsolidity/InlineAssembly.cpp#L198 this gives actually a warning in inline assembly block in solidity but when using in bare yul syntax test, there's no warning.
chriseth
@chriseth
@christianparpart control flow graph - matthias is currently working in that area, he might be able to help you
Christian Parpart
@christianparpart
ok, thx.
Kamil Śliwak
@cameel
I finally managed to post in the AMA. I tried messaging the mods a few times since yesterday and got no response. Apparently my account is shadowbanned and that requires an intervention from admins and is generally not an easy situation to get out of.
So I ended up just abandoning the account and creating a new one. Looks like my comments are showing up now: https://www.reddit.com/r/ethdev/comments/jigz5o/ask_the_solidity_team_anything_1/galbnk3/
I'll be reposting all my comments from this one but new accounts seem to be limited to one comment per 15 min so it'll take an hour or two until everything is there.
Alex Beregszaszi
@axic
Man, “shadowban” seems evil: https://redditban.com/
Christian Parpart
@christianparpart
I don't quite see what is wrong in this CI job, which is exiting 1, for some reason: https://app.circleci.com/pipelines/github/ethereum/solidity/9696/workflows/6c70e729-11a9-47af-a61c-8ccce60badf7/jobs/484069/steps
the bottom failing test is said to be ignored though.
Đorđe Mijović
@mijovic
@leonardoalt did you took over #10149? I see you marked it as ready for review
Kamil Śliwak
@cameel
@axic Yeah, I've seen users claiming they've been posting for months not being aware of the shadowban and wondering why no one replies to their posts.
This along with all the fuzziness around vote counts seems to be a part of their secret sauce to stop spam . But i'm not really buying it. I think it's too heavy-handed and harms too many legit users even if it helps with spam a little.
Leonardo
@leonardoalt
@mijovic I didn't, I'm still reviewing it only.
Đorđe Mijović
@mijovic
OK, cool, just checking if you are waiting for review there
Kamil Śliwak
@cameel
@franzihei All my comments are finally in. I saw that have added a few more answers today. Are we done with the AMA now (since it's Friday already) or do you think that there is anything left that still needs an answer?
Gabriele Rigo
@gabririgo
hey @axic not sure if this is the right channel to ask, but it looks like the ethereum versions list https://ethereum.github.io/solc-bin/bin/list.json is not updated to latest solc releases. Can you please advise where I should ask if not right channel, and if there's an ETA on list update?
Harikrishnan Mulackal
@hrkrshnn
@gabririgo Can you try it with the domain https://solc-bin.ethereum.org/. The link https://solc-bin.ethereum.org/bin/list.json seems to be updated.
@gabririgo :point_up: October 12, 2020 10:51 AM
Also @cameel maybe able to answer this better.
Kamil Śliwak
@cameel
@gabririgo Just like @hrkrshnn said, you should switch to https://solc-bin.ethereum.org. It serves binaries from an S3 bucket and has no rate limiting.
ethereum.github.io is served by Github Pages but we've hit the 10GB size limit there and it no longer updates. We're keeping it up mostly not to break people's old tools but we no longer support it. New binaries won't be appearing there.
It also does not serve the newly added Linux/Windows/Mac builds of older versions of the compiler.
Harikrishnan Mulackal
@hrkrshnn
@cameel Was info about the switch published somewhere?
Gabriele Rigo
@gabririgo
ok @cameel thank you for your help
Kamil Śliwak
@cameel
And the biggest problem with it was really that it's not our domain and we can't really switch it to something else. That's why we're recommending https://solc-bin.ethereum.org instead. It used to point at GH pages too but we've been able to seamlessly switch to S3 so everyone using it didn't even notice anything. If you use it, you will avoid this kinds of problems if we need to switch again.
@hrkrshnn Not really because it was meant to be a seamless change and using the GH pages domain wasn't really ever recommended.
But you have a point, from time to time someone reports this so I guess we should at least post on Twitter or something.
I've been also meaning to put it in solc-bin README. I think I'll do that now.
Franziska Heintel
@franzihei
@cameel I think we're good with the AMA
thanks for posting your answers°
Harikrishnan Mulackal
@hrkrshnn
Maybe @franzihei can tweet about it.
Franziska Heintel
@franzihei
I don't think there's any important question left unanswered. :)
Kamil Śliwak
@cameel
Great!
Franziska Heintel
@franzihei
I can tweet about the solc-bin.ethereum
what is the recommendation exactly?
Kamil Śliwak
@cameel
Basically that we have changed the hosting behind https://solc-bin.ethereum.org and the transition should have been seamless for anyone who has been using it but the files were also available via https://ethereum.github.io/solc-bin/ and anyone using it should switch.
We don't control that domain so we can't do anything about it ourselves. It's serving an older snapshot of the repo, new binaries won't show up there and it does not have the older Linux/Mac/Windows builds we recently started providing.
Franziska Heintel
@franzihei
ok will communicate that just to make sure everybody switches :thumbsup:
Kamil Śliwak
@cameel
Thanks. I'll also update the README, though getting it to show up at https://ethereum.github.io/solc-bin/ will be tricky (would require temporarily removing some files to go below the limit again and get GH pages to update one last time) so the tweet will be very helpful.
Alex Beregszaszi
@axic
@cameel not sure I understood your concern on #10147 ?
Kamil Śliwak
@cameel
My concern is that your change basically ignores m_generateEvmBytecode if necessary.
Alex Beregszaszi
@axic
How come it ignores it?
Kamil Śliwak
@cameel
But that seems to be done only because CLi does not do it at a higher level
ok, sorry, to be precise it skips compileContract(*contract, otherCompilers);, i.e. ignores (disables) the evm bytecode compilation
which used to be the effect of m_generateEvmBytecode.
Alex Beregszaszi
@axic
generateEVMFromIR is the replacement for acompileContract — the whole point of the issue this implements is to change the internal pipeline to IR and compileContract is the only piece which does the old route, but both functions output the same fields
Kamil Śliwak
@cameel
I mean, it's an alternative for it.
You can call one, the other or none of them.
Alex Beregszaszi
@axic
I just don’t see how EVM bytecode generation is skipped in the PR.
Kamil Śliwak
@cameel
Maybe I'll try to explain in a different way. My primary concern is this:
https://github.com/ethereum/solidity/blob/develop/libsolidity/interface/StandardCompiler.cpp#L913
Alex Beregszaszi
@axic
What does that has to do with the IR?