I would say something above beginner but definately less than intermediate
currently reading The C++ standard library book by Nicolai M. Josuttis
So I think this project would be great opportunity to apply all these concepts in real world
This should be relatively easy, I'll post a comment in the issue about how to do it.
it*
Also see https://docs.soliditylang.org/en/latest/contributing.html#contributing for how to set up your environment.
You can ask on this channel if you run into any problems with that.
By the way, what platform are you on?
Linux, Mac, Windows?
That's the one you should have least problems with.
Or does it need more work?
We can merge it. But I was waiting to see if someone else also supports your suggestion to only run the command line tests on clang, which would make such fix unnecessary.
1 reply
Was just wondering if you forgot about it :)
Though I don't know the full context. I'm going to look at that PR a bit later but it didn't seem to have anything bad in it last time I looked so it does not necessarily have to wait form .
If Nikola Matić thinks it's fine, I'm ok with merging it now.
matheus.pit: Can you take ethereum/solidity#13908?
I think we should merge ethereum/solidity#13855 and it will be best if we can do both fixes in the same release.
We still have some decisions to make regarding #13908 (i.e whether to disallow using {L.f} for private or whether to make it work like internal) so keep that in mind but I think it should go in soon whichever way we choose.
1 reply
❌ [main] Job t_native_test_ext_gnosis (run 4/6) failed on develop. Please see build 1259218 for details.
❌ [main] Job t_native_test_ext_gnosis (run 1/6) failed on develop. Please see build 1259218 for details.
❌ [main] Job t_native_test_ext_gnosis (run 3/6) failed on develop. Please see build 1259218 for details.
❌ [main] Job t_native_test_ext_gnosis (run 2/6) failed on develop. Please see build 1259218 for details.
By the way, the gnosis failure is (almost definitely) due to the PR that was merged yesterday (in their repository) - safe-global/safe-contracts#502, however, I can't replicate it locally (again in their repository). Another thing with
gnosis is that we still use npm to build and run, whereas the project itself uses yarn. I have (and will be) trying to reproduce this so I can open an issue downstream.
1 reply
In the meantime, a temporary fix could be to checkout a commit instead of the branch, and this allows the external test to pass, however, I'm not particularly keen on this approach as we'll essentially be using a frozen snapshot of the project until the issue is properly dealt with.
Yeah, I'd rather fix these errors as they come. It's annoying but I think that fixing multiple errors in multiple tests at once when you try to update is an even bigger headache.
There should not be that much difference between
npm and yarn though.
Probably good to use whatever the project uses in their README but these projects switch between them all the time.
❌ [main] Job t_native_test_ext_gnosis (run 3/6) failed on develop. Please see build 1259577 for details.
❌ [main] Job t_native_test_ext_gnosis (run 4/6) failed on develop. Please see build 1259577 for details.
❌ [main] Job t_native_test_ext_gnosis (run 2/6) failed on develop. Please see build 1259577 for details.
❌ [main] Job t_native_test_ext_gnosis (run 1/6) failed on develop. Please see build 1259577 for details.
❌ [main] Job t_native_test_ext_gnosis (run 3/6) failed on develop. Please see build 1259643 for details.
❌ [main] Job t_native_test_ext_gnosis (run 4/6) failed on develop. Please see build 1259643 for details.
❌ [main] Job t_native_test_ext_gnosis (run 1/6) failed on develop. Please see build 1259643 for details.
❌ [main] Job t_native_test_ext_gnosis (run 2/6) failed on develop. Please see build 1259643 for details.