ethereum/solidity

Hello all, sharing the complex number library I wrote for solidity: https://github.com/partylikeits1983/num_complex_solidity

Here's an example of finding the natural log of i.

contract model {
    Num_Complex Complex;

    Num_Complex.Complex a = Complex.wrap(0, 1e18);

    function test() public returns (Num_Complex.Complex memory) {

        Num_Complex.Complex memory result = Complex.ln(a);

        return result;
    }
}

However, currently there are some limitations to the library. Currently, complex numbers are handled in a struct as elementary user defined type and do not use the user defined type functionality that was added in Solidity version 0.8.8.

I was wondering if in the future it would be possible to define a custom type in solidity as struct instead of only the built in value types. Currently it is not possible to add two data types to a user defined type, which would be useful for complex numbers.

For example, it would be useful if it was possible to define a type as:

Struct Complex {
    int re;
    int im;
}
type complex is Complex;

To get around the added abstraction of using a struct to contain two ints, I thought of splitting a int256 into two int128 parts the first 128 bits being the real part and the last 128 bits the the imaginary part of a complex number, however, I believe this would increase complexity and introduce new bugs.

Would be grateful for feedback!