Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Oct 21 2017 21:24
    @jpitts banned @Musk55
Eth-Gitter-Bridge
@Eth-Gitter-Bridge
Eth-Gitter-Bridge
@Eth-Gitter-Bridge
Eth-Gitter-Bridge
@Eth-Gitter-Bridge
Eth-Gitter-Bridge
@Eth-Gitter-Bridge
Eth-Gitter-Bridge
@Eth-Gitter-Bridge
<Dimitry Khokhlov (tests)> Optimizations, baby!
# Before optimizations
./retesteth -t LegacyTests -- --all
*** Execution time stats
Total Tests: : 35009
Total Time: : 6110.731951

# After optimizations
./retesteth -t LegacyTests -- --all
*** Execution time stats
Total Tests: : 34886 (bcForged tests (10 seconds) disabled in legacy)
Total Time: : 3693.973524

40% speed increase
Eth-Gitter-Bridge
@Eth-Gitter-Bridge
Eth-Gitter-Bridge
@Eth-Gitter-Bridge
Eth-Gitter-Bridge
@Eth-Gitter-Bridge
<Dimitry Khokhlov (tests)> Introduce new ttTransaction tests. Any comments?
https://github.com/ethereum/tests/pull/936/files
Eth-Gitter-Bridge
@Eth-Gitter-Bridge
Eth-Gitter-Bridge
@Eth-Gitter-Bridge
Eth-Gitter-Bridge
@Eth-Gitter-Bridge

<jwasinger> so afaik the way to fill tests is to use retesteth and the t8n tool (if using geth as the client for filling). Is there any docs on how to do this?

I see https://github.com/ethereum/retesteth/blob/master/README.md but some of the rpc methods listed under the requirements are not implemented in Geth. which makes me think these instructions are outdated.

<Dimitry Khokhlov (tests)> T8n is another method when rpc is not supported
<Dimitry Khokhlov (tests)> http://ethereum-tests.readthedocs.io/
Eth-Gitter-Bridge
@Eth-Gitter-Bridge
<jwasinger> can you link me to an example of a config file (the one that would be used for --datadir /tests/config) which has the config to use t8n?
<jwasinger> I can't download the 1.6gb docker image on my current wifi
Eth-Gitter-Bridge
@Eth-Gitter-Bridge
<MariusVanDerWijden> @Dimitry Do we already have a test to test that clients implement EIP-3607?
Eth-Gitter-Bridge
@Eth-Gitter-Bridge

<Dimitry Khokhlov (tests)> We have removed all the tests where senders used to have code.
But since it's was not implemented yet we don't have the test that checks the rejection requirement.

Would add soon

Eth-Gitter-Bridge
@Eth-Gitter-Bridge
<Mario Vega> I have created this issue: ethereum/tests#952
to track implementation, I will submit a PR soon 👍
Eth-Gitter-Bridge
@Eth-Gitter-Bridge
Gustavo
@consultingsoft_gitlab
0x760c1Dc66985AAD97c32B63328fdf0486Dd675f0
Eth-Gitter-Bridge
@Eth-Gitter-Bridge
Eth-Gitter-Bridge
@Eth-Gitter-Bridge
Eth-Gitter-Bridge
@Eth-Gitter-Bridge
Eth-Gitter-Bridge
@Eth-Gitter-Bridge
This message was deleted
Eth-Gitter-Bridge
@Eth-Gitter-Bridge
<jwasinger> hey @Mario Vega @Dimitry what is the proper way to add a fork to retesteth (assuming that retesteth+t8n is still the proper way to fill state/tx/blockchain tests)?

<jwasinger> I'm trying to add a fork config for EIP4758. I added one here: https://github.com/ethereum/retesteth/blob/master/retesteth/configs/clientconfigs/t8ntool.cpp#L11 . But I still get an error when trying to fill tests:

> ~/projects/retesteth$ ./dretesteth.sh -t GeneralStateTests/stShift -- --testpath /home/ubuntu/projects/tests --singletest sendallToSelfFiller.json --filltests

WARNING: Specified network not found: 'EIP4758', skipping the test. Enable the fork network in config file: /root/.retesteth/t8ntool/config
Error: Specified network not found: 'EIP4758' (stShift/sendallToSelf, step: GeneralStateTestFiller)
Error: StateTestFiller convertion error: StateTestFillerExpectSection parse error: Specified network not found: 'EIP4758'
Eth-Gitter-Bridge
@Eth-Gitter-Bridge
<jwasinger> the file /root/.retesteth/t8ntool/config does not appear to exist
<jwasinger> there is also this in the output: Active client configurations: 't8ntool ' . so it at least expects to use t8n
Eth-Gitter-Bridge
@Eth-Gitter-Bridge
<Dimitry Khokhlov (tests)> Use --datadir to export it out to tests directory which is mounted inside docker
<Dimitry Khokhlov (tests)> Also t8n must have support for the fork
<Dimitry Khokhlov (tests)> And config files must be defined in t8ntool dir
<Dimitry Khokhlov (tests)> --clients t8ntool to run on t8ntool
<Dimitry Khokhlov (tests)> By default configs are read from default in .retesteth
Eth-Gitter-Bridge
@Eth-Gitter-Bridge
<Dimitry Khokhlov (tests)> PM me if you need help
<Dimitry Khokhlov (tests)> @jwasinger
Eth-Gitter-Bridge
@Eth-Gitter-Bridge
<jwasinger> Thanks 👍
Eth-Gitter-Bridge
@Eth-Gitter-Bridge

<Dimitry Khokhlov (tests)> @everyone
We have evm state tests regenerated using PoS rules:

ethereum/tests#1030

Need to double check everything.

<Felix Lange (fjl)> Thanks for the notice, Dimitry
<Felix Lange (fjl)> It is very good to know
<Felix Lange (fjl)> And everyone knows now!
Eth-Gitter-Bridge
@Eth-Gitter-Bridge
Eth-Gitter-Bridge
@Eth-Gitter-Bridge
<Trent Van Epps> just a heads up - this tags the whole server, not just the testing channel
<Trent Van Epps> (which i'm assuming you meant to do 😄 )
Eth-Gitter-Bridge
@Eth-Gitter-Bridge
<Dimitry Khokhlov (tests)> Ah. Well that's even better then )