Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Apr 06 17:56
    willgdjones commented #2120
  • Mar 30 19:18

    carver on master

    Upgrade Ethereum tests to v8.0.… Merge pull request #2127 from c… (compare)

  • Mar 30 19:18
    carver closed #2127
  • Mar 29 18:18
    carver edited #2127
  • Mar 29 18:18
    carver edited #2127
  • Mar 29 17:10
    carver synchronize #2127
  • Mar 29 16:33
    carver opened #2127
  • Mar 25 14:40

    carver on v0.1.0-alpha.37

    (compare)

  • Mar 25 14:40

    carver on master

    Compile release notes Note: ha… Bump version: 0.1.0-alpha.36 → … (compare)

  • Mar 24 23:00

    carver on master

    RPC debug=True raises all excep… Show list of failed tests at en… Get py-evm that implements Berl… and 12 more (compare)

  • Mar 24 23:00
    carver closed #2123
  • Mar 24 23:00
    carver closed #2126
  • Mar 24 22:32
    carver synchronize #2123
  • Mar 24 22:10
    carver synchronize #2123
  • Mar 24 21:57
    carver edited #2123
  • Mar 24 21:57
    carver ready_for_review #2123
  • Mar 24 21:43
    carver synchronize #2123
  • Mar 24 20:32
    carver synchronize #2123
  • Mar 24 20:24
    carver synchronize #2123
  • Mar 24 18:32
    carver synchronize #2123
Eth-Gitter-Bridge
@Eth-Gitter-Bridge
<Guilherme Salgado> well, in the worst case, if a block import is paused because of missing data that has already been requested (by the witness downloader), as soon as the coroutine waiting for the missing data returns, the import will resume and if the witness downloader finished its job, the import will complete, no?
<Guilherme Salgado> not ideal as some trie nodes could end up being downloaded more than once, but maybe not worth worrying about if the number of trie nodes downloaded twice is small
Eth-Gitter-Bridge
@Eth-Gitter-Bridge
<Guilherme Salgado> @Christoph / @nick.ghita do any of you guys have a grafana dashboard I could use as a starting point?
Eth-Gitter-Bridge
@Eth-Gitter-Bridge
<Christoph Burgdorf (cburgdorf)> There's a hosted one that you can push data in http://trinity-bench.ethdevops.io/d/eGqVTrgMz/trinity-eth1
<Christoph Burgdorf (cburgdorf)> I'll send you more details via pn
Eth-Gitter-Bridge
@Eth-Gitter-Bridge
<Guilherme Salgado> @carver I'm getting an error when trying to sync from a checkpoint: http://sprunge.us/nIF2vQ
<carver, Jason Carver> Looks like something busted in the HeaderChainGapSyncer, you can just disable it for now
<carver, Jason Carver> (with --disable-backfill)
Eth-Gitter-Bridge
@Eth-Gitter-Bridge
<Christoph Burgdorf (cburgdorf)> @Guilherme Salgado This error can happen if a checkpoint too close to the tip was chosen. See discussions in this PR ethereum/trinity#2091
Eth-Gitter-Bridge
@Eth-Gitter-Bridge
<Guilherme Salgado> has anybody ran into ethereum/trinity#2108 as well? it seems to be specific to the metrics component, so would only happen if you run with metrics enabled
<Guilherme Salgado> it's a real PITA as it happens quite frequently
Eth-Gitter-Bridge
@Eth-Gitter-Bridge
<carver, Jason Carver> maybe those components are just trying to connect rather than waiting for the metrics endpoint to become available? I never really deep-dived on how the event-bus works
Eth-Gitter-Bridge
@Eth-Gitter-Bridge
<Guilherme Salgado> yeah, it is the initial event bus connection that happens between each component pair
<Guilherme Salgado> every time a component starts up, its eventbus endpoint is forwarded to all other components and they attempt to connect to it
Mikko Ohtamaa
@miohtama
HEllo all
I am looking to create a simple light client to verify proofs from Ethereum 1.0 main chain
Does Trinity support light client stuff or is it abandon feature?
Eth-Gitter-Bridge
@Eth-Gitter-Bridge
<carver, Jason Carver> You mean proof of the execution of a block or transaction, or a proof of state?
<carver, Jason Carver> There is a light client option, but it hasn't gotten love for a while
Mikko Ohtamaa
@miohtama
proof of transaction, or specifically event logs
alright, I might need to start brewing a love potion
Eth-Gitter-Bridge
@Eth-Gitter-Bridge
<Guilherme Salgado> @carver I've experimented with having import_block() run a witness fetch (in case the witness is not available yet) in parallel with the block import, and with that we rarely see any missing state
<Guilherme Salgado> so maybe we can go with that for now, before the aproach you suggested: wait for child blocks before importing the parent, to reduce non-canonical imports
Eth-Gitter-Bridge
@Eth-Gitter-Bridge
<Guilherme Salgado> also because in order for that to be effective we may need to wait for multiple children, as I imagine not all reorgs are only 1 block deep?
<carver, Jason Carver> Yeah, my intuition is that one block reorgs are very common, and two blocks much less, so maybe it's fine to just pivot on a two block one
Eth-Gitter-Bridge
@Eth-Gitter-Bridge
<Guilherme Salgado> @carver is ethereum/trinity#2109 ready to merge? FWIW, I've been using it in that instance from which I'm collecting metrics, so it looks like it hasn't introduced any regressions 🙂
Eth-Gitter-Bridge
@Eth-Gitter-Bridge
<carver, Jason Carver> Hah, nice. I just did some squashing, and made the requested change. I am not really working today, so if you notice it turn green, feel free to do a merge (merge commit instead of squash, please)
Eth-Gitter-Bridge
@Eth-Gitter-Bridge
<carver, Jason Carver> Nevermind, I managed to merge it 👍
Eth-Gitter-Bridge
@Eth-Gitter-Bridge
<Guilherme Salgado> @carver when you have a moment, can you review ethereum/trinity#2113 and ethereum/trinity#2114
Eth-Gitter-Bridge
@Eth-Gitter-Bridge
<carver, Jason Carver> Yeah, for sure, I'll get those out today 👌
Eth-Gitter-Bridge
@Eth-Gitter-Bridge
<Guilherme Salgado> @Piper any idea why no CI job was started for ethereum/trio-run-in-process#10
Eth-Gitter-Bridge
@Eth-Gitter-Bridge
<Piper Merriam> I'll check the ci setup
<Piper Merriam> Should start working now, it wasn't setup to build from forks
Eth-Gitter-Bridge
@Eth-Gitter-Bridge
<Guilherme Salgado> @Piper just a nudge about https://github.com/ethereum/trio-run-in-process/pull/10#discussion_r546415554 in case it flies under your radar
Eth-Gitter-Bridge
@Eth-Gitter-Bridge
<Piper Merriam> @gsalgado on mobile. I agree with your latest comment about just not exposing those apis
Eth-Gitter-Bridge
@Eth-Gitter-Bridge
<Guilherme Salgado> @Piper just wanted to draw your attention to https://github.com/ethereum/trio-run-in-process/pull/13#issuecomment-752020912
Eth-Gitter-Bridge
@Eth-Gitter-Bridge
<Piper Merriam> Interesting. It'll be good to eventually understand the "why" got the performance difference but for more I'm just happy to see it working.
Eth-Gitter-Bridge
@Eth-Gitter-Bridge
<Guilherme Salgado> and also ran into an issue when leaving the pool context while there were pending tasks to pool.run(). that was fixed in https://github.com/ethereum/trio-run-in-process/pull/13/commits/f1f5b4ec164e0cdf03d224bcaf4557c8a83c4457
<Guilherme Salgado> if you're ok with those I'll merge it
<Guilherme Salgado> oh, and there's something wrong with the CI config; the job triggered on new commits to master always fails: https://app.circleci.com/pipelines/github/ethereum/trio-run-in-process/34/workflows/694574f2-bcba-42b9-8b20-584b93ffcb15
Samuel Montgomery-Blinn
@montsamu
Question: can I run the different Trinity processes on different machines? (For example, a cluster of 2 GB raspberry pi 4 devices, none of which individually has the RAM to run all processes simultaneously.)
Eth-Gitter-Bridge
@Eth-Gitter-Bridge
<carver, Jason Carver> Splitting processes across machines is an idea we've talked about in the abstract, but haven't planned or designed for. Either way, trinity will work best if you can throw as much horsepower at it as possible, so I'd recommend something other than rpi
gbayasgalan
@gbayasgalan
hi, have a question, can I use trinity as Eth2 client with pyrmont testnet & validtor...? like Prysm, Nimbus ...?
Eth-Gitter-Bridge
@Eth-Gitter-Bridge
<carver, Jason Carver> Trinity is eth1-only, there was a project to build out a separate eth2 client in python, but it's not being maintained right now AFAIK
gbayasgalan
@gbayasgalan
ah okey, thanks for your response
gbayasgalan
@gbayasgalan
I tried trinity as eth1 on docker and it works fine, but I cannot connect my eth2(Prysm) to eth1(Trinity), so the docker-image: ethereum/trinity:0.1.0-alpha.36 and it doesn't recognize the flags <--http-listen-address> & <--http-port> which are founded here: https://trinity-client.readthedocs.io/en/latest/api/api.cli.html?highlight=port#command-line-interface-cli. how it can be connected to eth2?
Eth-Gitter-Bridge
@Eth-Gitter-Bridge
<carver, Jason Carver> Hey sorry I missed this message earlier @gbayasgalan -- Unfortunately, Trinity is not really ready for practical usage yet, it's more of a research tool at this point. That's unlikely to change for quite a while, now, because all Trinity developers are now primarily working on other projects. There will be some more explicit announcement about that sometime in the coming weeks.
<carver, Jason Carver> That being said, I did just push a new release which supports Berlin. It does not implement eth/66 yet, so it probably won't be of much practical use for a while, because it won't be able to communicate with geth peers (and probably most others). But it does help us confirm that py-evm fully supports Berlin, also. https://trinity-client.readthedocs.io/en/latest/release_notes.html#trinity-0-1-0-alpha-37-2021-03-24
Eth-Gitter-Bridge
@Eth-Gitter-Bridge
<carver, Jason Carver> docker uploads in progress...