These are chat archives for ethersphere/orange-lounge
ethersphere orange lounge is the swarm engine room- board: https://github.com/orgs/ethersphere/projects/1; doc: http://swarm-guide.readthedocs.io; PRs: https://github.com/ethersphere/go-ethereum; rountable topics: https://hackmd.io/oj9_cT2KQimMdIPe_W_ejQ#
master-legacybranch and tag. but i don’t think i have permissions to force-push go-ethereum/master on ethersphere/master so that they sync
masterbranch properly to be honest
@lmars sorry to bring this up again, but I am confused. @nolash looked through ethersphere/go-ethereum#137 and explained that the following should be omitted from the PR:
swarm/networkchanges relevant to the binary
I updated the ethereum/go-ethereum#15198 which is
You explained that
swarm-network-rewrite should get syncing implemented and then merged.
So my question - where does
p2p-simulations fit and the changes from
pss-networktest, which are independent of PSS? should these be merged in
I don’t see how
p2p-simulations are related, both seem to have a lot of changes and I am not sure which one is based on which.
p2p-simulations-fixesis an attempt at fixing the dial problem, while
p2p-simulationsis the "pure p2p simulations" branch to be merged to master
p2p-simulation-fixesis just a slight refactor and change to the server logger.
where does p2p-simulations fit and the changes from pss-networktest
We should push all current simulation fixes (i.e. any changes in
p2p/simulations which aren't on
p2p-simulation-fixes, get that merged.
We should rebase
p2p-simulation-fixes (and ultimately
go-ethereum/master once those fixes are merged), and include any changes to
swarm/network in that branch.
We should rebase
swarm-network-rewrite and include any fixes / changes (e.g. pull request
pss, or just push the changes directly to the
pss branch and drop
ethersphere/masterso we can start making incremental changes to swarm / pss / simulations without doing this dance over and over
p2p-simulationsbranch to go-ethereum/master right?
p2p-simulation-fixesis already marked for review, so anything that is not pss related could just go into a new branch once
there's always a red fail cross
and honestly guys, we all pass our relevant tests before we commit to PRs right? :)
go run build/ci.go test packages...: https://github.com/ethereum/go-ethereum/blob/master/build/ci.go#L27
gethruns from the assumption that if no config file is provided, it would load flags from the command line
EnvVarfield in the flags like I did for p2psim: https://github.com/ethereum/go-ethereum/blob/master/cmd/p2psim/main.go#L47-L52)