These are chat archives for ethersphere/orange-lounge

29th
Mar 2018
lash
@nolash
Mar 29 10:55
@janos @nonsense @gbalint @zelig @holisticode Thanks for the initial review of ethersphere/go-ethereum#337 - Another refactor was needed, which makes the PR look quite different. Could I please beg a new look-through? (let's defer comments on the how-to-handle-Params stuff, please, let's handle that later). It's pushed and ready to go.
Oh wait, hang on, I forgot to remote update before rebase..
lash
@nolash
Mar 29 11:04
Ah fuck it's a mess, of course, because of my other PR %)
Balint Gabor
@gbalint
Mar 29 11:06
@nonsense @nolash @zelig @janos I fixed my PR according to the reviews, I would like to kindly ask for another review ethersphere/go-ethereum#327
Anton Evangelatov
@nonsense
Mar 29 11:08
ok
Anton Evangelatov
@nonsense
Mar 29 11:20
@gbalint can i push a commit to your branch?
you can then force-push and remove it
if you don't like the suggestion
actually scratch that, will just create a gist
Balint Gabor
@gbalint
Mar 29 11:23
however you want
Anton Evangelatov
@nonsense
Mar 29 11:23
added a comment with a link to gist
lash
@nolash
Mar 29 12:30
It's ready now guys ethersphere/go-ethereum#327
Janoš Guljaš
@janos
Mar 29 12:37
@nolash did you mean ethersphere/go-ethereum#337 ?
lash
@nolash
Mar 29 12:43
I did indeed @janos sorry
Janoš Guljaš
@janos
Mar 29 12:43
no problem :)
lash
@nolash
Mar 29 20:38
@nonsense @zelig ethersphere/go-ethereum#354 <- pretty, please
Mistoken
@MistokenToken
Mar 29 21:18
Is swarm usable for picture storage at the moment
Anton Evangelatov
@nonsense
Mar 29 22:38
will review tomorrow
lash
@nolash
Mar 29 23:06
ty!