These are chat archives for etorreborre/specs2

26th
Apr 2018
Marko Dimjašević
@mdimjasevic
Apr 26 2018 07:12 UTC
Great! I'll take a look.
Marko Dimjašević
@mdimjasevic
Apr 26 2018 08:51 UTC
@etorreborre : I'm trying to understand your changes and I'm wondering why is there no way to tweak the seed in a trait org.specs2.scalacheck.ScalaCheckParameters
Marko Dimjašević
@mdimjasevic
Apr 26 2018 09:18 UTC
Should it be like that?
I like your decision on when to display an initial seed: display it always in problematic cases and display it in successful cases only if in the verbose mode
Marko Dimjašević
@mdimjasevic
Apr 26 2018 09:28 UTC
Overall, I went through the changes and they look good to me. One will be able to use the scalacheck.seed command line property to set an initial seed or to set it from within specs2 (e.g., in build.sbt)
Another thing I didn't get are changes in org.specs2.scalacheck.ScalaCheckPropertyCheck. In method check, why do you need to have capturedSeed as a variable?
Eric Torreborre
@etorreborre
Apr 26 2018 09:50 UTC
@mdimjasevic that’s the complicated and ugly part. It took me a while to understand. There are 2 modes: either a seed is submitted and it is used for re-running the property once. Or a seed is created on the fly and not exposed. Unless you call Prop.viewSeed which just adds a println when the property has finished executing. So the only way to grab the initialSeed used in the regular case (not when you want to reproduce a failure) is to do what viewSeed does and capture that initial seed. All my other attempts failed.
Marko Dimjašević
@mdimjasevic
Apr 26 2018 11:06 UTC
Oh, OK
I ran tests on my local machine and there was a failure related to (Scala)JS, but it was due to a linking error. I suppose build.sbt doesn't set this up on its own and I don't have it installed and configured system-wide.
Eric Torreborre
@etorreborre
Apr 26 2018 11:26 UTC
if you go to the tests module with sbt you can run the tests there (they’re all JVM ones) and you should see some failures
Marko Dimjašević
@mdimjasevic
Apr 26 2018 11:30 UTC
How do I go to the tests module?
Eric Torreborre
@etorreborre
Apr 26 2018 13:18 UTC
I’m tempted to say sbt> cd tests but that’s because I have addCommandAlias("cd", "project”) in my configuration for sbt :-). So it’s sbt> project tests
Marko Dimjašević
@mdimjasevic
Apr 26 2018 13:19 UTC
thanks
Marko Dimjašević
@mdimjasevic
Apr 26 2018 13:27 UTC
Eric, here are results of running test in the tests module:
[error] Failed: Total 1087, Failed 3, Errors 0, Passed 1084, Pending 1
[error] Failed tests:
[error]     org.specs2.scalacheck.ScalaCheckMatchersResultsSpec
[error] (tests/test:test) sbt.TestsFailedException: Tests unsuccessful
[error] Total time: 26 s, completed Apr 26, 2018 3:19:28 PM
Marko Dimjašević
@mdimjasevic
Apr 26 2018 15:11 UTC
Not sure what makes that spec fail
Eric Torreborre
@etorreborre
Apr 26 2018 15:46 UTC
If I remember correctly from yesterday it is just the fact that we now print out the seed by default when there’s a failure. We need to modify the code to not display the seed when the verbosity is set to 0 and run this spec with verbosity = 0
Unfortunately I’m doing too much firefighting to have time for this today :-(