These are chat archives for eventum/eventum

18th
Nov 2015
Bryan Alsdorf
@balsdorf
Nov 18 2015 01:59
If we move to controllers (and I like the idea and the code you emailed) I would like to get rid of most files in htdocs/. I don't see the point of a send.php file that just calls the send controller. At that point we should do url mapping, so you would have something like http://example.com/1234/send
For the code layout, I don't think we need src/Eventum/ unless we think we might include the src to other things as well
Elan Ruusamäe
@glensc
Nov 18 2015 07:30
Controller is right term? Or it should be Pages?
As for router, that can be done later of course, plan to change incrementally
Bryan Alsdorf
@balsdorf
Nov 18 2015 14:47
I think controller is the right term for that style of coding.
Elan Ruusamäe
@glensc
Nov 18 2015 21:28
ok. i have first round done for send.php
i think i will just commit to master, as you unlikely go over line by line it and comment it in pull-request... and the sooner it lands to master the sooner it gets tested (including myself).
so, what you think, create PR to have commits in one place? as otherwise it would be silly to have PR for each .php file we have... no?
Elan Ruusamäe
@glensc
Nov 18 2015 21:36
or maybe i work on it a bit, and merge when seems enough done
can still commit to branch, just PR maybe not neccessary https://github.com/glensc/eventum/tree/controller