These are chat archives for eventum/eventum

23rd
Nov 2015
Elan Ruusamäe
@glensc
Nov 23 2015 18:35
@balsdorf can customer_id be something else than 32bit integer?
Elan Ruusamäe
@glensc
Nov 23 2015 18:47
pff: this seems redundant. afaik += operator already "merges":
    $options += $this->options_override;
    $options = array_merge($options, $this->options_override);
Elan Ruusamäe
@glensc
Nov 23 2015 19:33
@balsdorf please comment about those two FIXME's: glensc/eventum@164ae74
Elan Ruusamäe
@glensc
Nov 23 2015 19:49
ok, the $releases was probably mistakenly overwritten here: https://github.com/eventum/eventum/blob/v3.0.6/htdocs/update.php#L204
Elan Ruusamäe
@glensc
Nov 23 2015 20:09
omg, there's two places that say
global $errors;
Elan Ruusamäe
@glensc
Nov 23 2015 20:16
yuck! glensc/eventum@d7c95e8
Elan Ruusamäe
@glensc
Nov 23 2015 20:21
reading that i have no clue, can i move the prePage call after permission check or not. so i will just do, don't care if it breaks
Elan Ruusamäe
@glensc
Nov 23 2015 20:32
oh, that $release thing was actually fixed in master: eventum/eventum#105
phpstorm was able to detect this after code was moved out of global scope!