These are chat archives for eventum/eventum

8th
Dec 2015
Bryan Alsdorf
@balsdorf
Dec 08 2015 02:55
Yeah that looks good
what are your thoughts on StyleCI fixes in pull requests? For my CLI change I fixed all the StyleCI issues relating to changes I made, but not in every single file that I touched. Should I go through and fix them all or leave them?
Elan Ruusamäe
@glensc
Dec 08 2015 07:40
I hate that styleci. They change rules behind our backs, as i fixed all code 100% at some point
Probably should disable it. Already did for master branch. But it may be useful for pull request that come from outside
Elan Ruusamäe
@glensc
Dec 08 2015 08:03
so, i'm perfectly fine merging with styleci failing, as fixing same code in several concurrent branches is annoying and creates merge conflicts too
Elan Ruusamäe
@glensc
Dec 08 2015 08:10
also you have those styleci errors, that are already fixed because you did not rebase against upstream/master as i told you to, you just rebased against your local master branch which was old
Elan Ruusamäe
@glensc
Dec 08 2015 08:20
yeah, seems you should redo again authtoken pr, gave same deeper thought there how it should be. thinking about security pov as well this time
Elan Ruusamäe
@glensc
Dec 08 2015 19:45