These are chat archives for exceptionless/Discuss

5th
Jun 2015
I think that should be .apply() instead of .call(), because you pass the arguments array. .call() requires all arguments to be passed individually
Blake Niemyjski
@niemyjski
Jun 05 2015 11:53
does apply work in ie9?
Sander Rijken
@srijken
Jun 05 2015 13:17
I can check that
Blake Niemyjski
@niemyjski
Jun 05 2015 13:18
ok, you can also check mozilla's mdn
I came across that section of code from another plugin..
didn't really question it and it worked
Sander Rijken
@srijken
Jun 05 2015 13:19
.call expects .call(.., arg1, arg2, arg3)
Blake Niemyjski
@niemyjski
Jun 05 2015 13:19
I think the first one is an instance
Sander Rijken
@srijken
Jun 05 2015 13:20
so when calling $log.info("foo", "bar"), when the angular integration is alive, it'll call $log.info(["foo", "bar"]) instead
Blake Niemyjski
@niemyjski
Jun 05 2015 13:21
ah
okay
yeah that would be a bug
Sander Rijken
@srijken
Jun 05 2015 13:21
it should be good:
Supported in the following document modes: Quirks, Internet Explorer 6 standards, Internet Explorer 7 standards, Internet Explorer 8 standards, Internet Explorer 9 standards, Internet Explorer 10 standards, Internet Explorer 11 standards.
Blake Niemyjski
@niemyjski
Jun 05 2015 13:21
yeah
looks good
can you make the change and test it
and then do a pull request?
Sander Rijken
@srijken
Jun 05 2015 13:21
sure
Blake Niemyjski
@niemyjski
Jun 05 2015 13:21
pretty please :D
Sander Rijken
@srijken
Jun 05 2015 13:22
is that the source btw, or is that compiled from somewhere else?
ah found the ts file
Blake Niemyjski
@niemyjski
Jun 05 2015 13:25
yeah
just gotta run gulp build from the command line
Sander Rijken
@srijken
Jun 05 2015 13:25
have both changes in the pull request I guess?
Blake Niemyjski
@niemyjski
Jun 05 2015 13:26
yeah if you could
Sander Rijken
@srijken
Jun 05 2015 13:26
are there tests in place for this?
Blake Niemyjski
@niemyjski
Jun 05 2015 13:26
could you also bump the version to 0.9.1 in the package.json and bower file
and rerun the build :)
I don't have any tests for those integrations :sa:
I have tests for everythign else
Sander Rijken
@srijken
Jun 05 2015 13:27
ok, just making sure :) seems like a good idea to call $log.info with params, and expect the decorator to pass it through
Blake Niemyjski
@niemyjski
Jun 05 2015 13:27
yeah
I agree
Sander Rijken
@srijken
Jun 05 2015 13:27
just to make sure they don't change the normal behavior
Sander Rijken
@srijken
Jun 05 2015 13:44
how do I install "tsd"? npm install fails on "tsd reinstall -s"
Blake Niemyjski
@niemyjski
Jun 05 2015 13:45
npm install tsd -g
Sander Rijken
@srijken
Jun 05 2015 13:45
check
Sander Rijken
@srijken
Jun 05 2015 13:56
one more question
Blake Niemyjski
@niemyjski
Jun 05 2015 13:56
shoot
Sander Rijken
@srijken
Jun 05 2015 13:56
create an issue, and use that, or just create a pull request? Is that even possible? :)
Also tested IE9 :)
Blake Niemyjski
@niemyjski
Jun 05 2015 14:02
yeah create an issue or just pull request
an pull request can reference an issue
:)
sweet
Sander Rijken
@srijken
Jun 05 2015 14:29
there's more...
Blake Niemyjski
@niemyjski
Jun 05 2015 14:30
?
when that's called with sourceOrMessage=null, we get empty log messages
oh that's from the fork, but anyway
Blake Niemyjski
@niemyjski
Jun 05 2015 14:31
probably happening for submit log too
Sander Rijken
@srijken
Jun 05 2015 14:31
think so yeah
we were trying to work around that by passing (arguments.callee.caller).name into submitLog, instead of null, and then we discovered that the caller can be null
Blake Niemyjski
@niemyjski
Jun 05 2015 14:32
I think it should be
if message && level
second if should just be if message
could you add a null check for caller than too?
any chance you could create a test for createlog
Blake Niemyjski
@niemyjski
Jun 05 2015 14:33
the submit just calls createlo
yeah
var caller = arguments.callee.caller
Sander Rijken
@srijken
Jun 05 2015 14:34
the thing is, if there's no source, and no caller, then what
Blake Niemyjski
@niemyjski
Jun 05 2015 14:34
then set source would be caller && caller.name
it's fine it can handle being null or undefined :)
Sander Rijken
@srijken
Jun 05 2015 14:35
setSource(null) works?
Blake Niemyjski
@niemyjski
Jun 05 2015 14:35
I just put that in there to try and be smart
yeah
so do you get what I'm saying about the if else.. If we check the last params for values it would be better than checking sourceOrMessage as that could be null and throw off the if.
Blake Niemyjski
@niemyjski
Jun 05 2015 14:39
yeah
I'd like the source to be the class name
but its really tough right now / didn't have time to look into it further
Sander Rijken
@srijken
Jun 05 2015 14:45
not really sure how to test this, how can I verify what event was created?
Blake Niemyjski
@niemyjski
Jun 05 2015 14:45
easy
Create a test for createlog in the exceptionless client..
then do
var builder = client.createlog(overloads)..
then do an asert on builder.Target(or is it called event).source == null / xyz
it's builder.target.source is what you need to assert
along with builder.target.message
and then builder.target.data['@level']
if you need any help, please let me know
Sander Rijken
@srijken
Jun 05 2015 14:48
I'll get there, thanks
Blake Niemyjski
@niemyjski
Jun 05 2015 14:48
Thanks for your help :D
@Phyxion Are you around. Could use a pair on this.
Phyxion
@Phyxion
Jun 05 2015 14:56
Hi @niemyjski
Blake Niemyjski
@niemyjski
Jun 05 2015 14:56
Is there any chance your free for a little bit?
I'm working on the .net 4.0 pcl stuff
and could use some help tracking down this issue
Phyxion
@Phyxion
Jun 05 2015 14:56
Yes, I can help.
Blake Niemyjski
@niemyjski
Jun 05 2015 14:56
does teamviewer work for you
Phyxion
@Phyxion
Jun 05 2015 14:57
I'm a bit semi-online due to the heat here at the moment.
Blake Niemyjski
@niemyjski
Jun 05 2015 14:57
ok
is there a time that works better
Phyxion
@Phyxion
Jun 05 2015 14:57
where do you need tv for?
I can help, it's fine
Blake Niemyjski
@niemyjski
Jun 05 2015 14:57
I can't commit until I get this obscure build error fixed
just wanted to share my screen
Phyxion
@Phyxion
Jun 05 2015 14:57
ah sure
don't you have RDP?
Blake Niemyjski
@niemyjski
Jun 05 2015 14:58
not to my main workstation
:)
Phyxion
@Phyxion
Jun 05 2015 14:58
or is there an online team-viewer client? I don't have it installed.
Blake Niemyjski
@niemyjski
Jun 05 2015 14:59
yeah that's what team viewer is
hehe
Phyxion
@Phyxion
Jun 05 2015 14:59
alright, what's the id?
Blake Niemyjski
@niemyjski
Jun 05 2015 14:59
sent in a private message
Phyxion
@Phyxion
Jun 05 2015 15:05
so, what's the issue?
Blake Niemyjski
@niemyjski
Jun 05 2015 15:05
you see the eroror I get when I try to build
no clue what's causing that

Copyright (C) Microsoft Corporation. All rights reserved.

C:\code\exceptionless.net\Source\Shared\Exceptionless.Portable.csproj : error MSB4057: The target "Rebuild" does not ex
ist in the project.
Finished building Exceptionless.Portable (NET40)

Phyxion
@Phyxion
Jun 05 2015 15:06
hmm neither do i
very strange error
can't say that I've had this before
Blake Niemyjski
@niemyjski
Jun 05 2015 15:08
do you remember how to output a variable
Phyxion
@Phyxion
Jun 05 2015 15:08
but I'm not that into msbuild really, I know a thing or two but this is very weird, this is the only error you have?
Blake Niemyjski
@niemyjski
Jun 05 2015 15:08
from msbuild
well I have others
I've been working through them
Phyxion
@Phyxion
Jun 05 2015 15:08
does it work through VS?
Blake Niemyjski
@niemyjski
Jun 05 2015 15:09
I could try
lets see this build first
there were errors at hte bottom
Phyxion
@Phyxion
Jun 05 2015 15:09
I think it's missing a build target
Blake Niemyjski
@niemyjski
Jun 05 2015 15:09
yeah
only thing I can think of is maybe TargetPortable property isn't set
holy crap
my last changed fixed hte log4net errors :D
Phyxion
@Phyxion
Jun 05 2015 15:10
it is done now I think?
or are these the other projects
Blake Niemyjski
@niemyjski
Jun 05 2015 15:10
this is all of them
so I wonder what that common targets warning is
Phyxion
@Phyxion
Jun 05 2015 15:11
so no more rebuild error then?
or did I just miss it
ah i see
Blake Niemyjski
@niemyjski
Jun 05 2015 15:11
yeah it's there
It's happening when pcl is targeted
Phyxion
@Phyxion
Jun 05 2015 15:11
well the conditions look OK
Blake Niemyjski
@niemyjski
Jun 05 2015 15:11
so need to figure out how to write out this variable
Phyxion
@Phyxion
Jun 05 2015 15:12
you sure you've written this OK? I don't really know PS but shouldn't it be targetPortable = 'true' instead of += ?
Blake Niemyjski
@niemyjski
Jun 05 2015 15:13
awe crap
lol
probably it
was using constants before
Phyxion
@Phyxion
Jun 05 2015 15:13
let's try it
Blake Niemyjski
@niemyjski
Jun 05 2015 15:13
dammit
lol
some stupid mistake
lol
Phyxion
@Phyxion
Jun 05 2015 15:14
ah well, I completely understand
I remember a while ago, I've spent half a day figuring out while something didn't compile, turned out there was a } instead of { (and no useful error)
some days ;)
Blake Niemyjski
@niemyjski
Jun 05 2015 15:16
lol
yeah
thanks man I think this looks good. .except for an extra folder
want to review the commit real quick to see if I'm missing something
Phyxion
@Phyxion
Jun 05 2015 15:16
what for additional folder is generated?
is this the official github client you're using?
Blake Niemyjski
@niemyjski
Jun 05 2015 15:18
guess I should see if vs builds
yeah
Phyxion
@Phyxion
Jun 05 2015 15:18
ok
Blake Niemyjski
@niemyjski
Jun 05 2015 15:18
github for windows
Phyxion
@Phyxion
Jun 05 2015 15:19
yeah, I'm currently using SourceTree, works pretty decent as well but sometimes its a bit weird with merging.
Blake Niemyjski
@niemyjski
Jun 05 2015 15:19
this does a horrible job with merging
I like using toritisegit + beyond compare for merging
Phyxion
@Phyxion
Jun 05 2015 15:19
alright then there is no need to change to GitHub for Windows :smile:
VS should build just fine with the msbuild but probably doesn't detect all configurations.
Blake Niemyjski
@niemyjski
Jun 05 2015 15:20
yeah
but github for windows does everything
it's really really nice
Phyxion
@Phyxion
Jun 05 2015 15:21
does it also do Mercurial?
Blake Niemyjski
@niemyjski
Jun 05 2015 15:21
I've had it installed on osx and windows on my new laptop.. you shouldn't need to do a merge often unless you have coworkers who like to step on your toes
idk
it's made by github and they have integrations with vs2015 so where you can do
open in vs from github.com and it will clone it or open it :)
Phyxion
@Phyxion
Jun 05 2015 15:22
It doesn't have Mercurial, we still have some projects in this format. Too bad it's not very easy to convert projects.
Blake Niemyjski
@niemyjski
Jun 05 2015 15:23
So I think we are good to push this out there for a nightly
but I'm a bit scared to push it live
could you help me test it from the myget nightly
Phyxion
@Phyxion
Jun 05 2015 15:23
btw, is it Exceptionless giving the "has encountered a problem and needs to close" message?
Blake Niemyjski
@niemyjski
Jun 05 2015 15:23
and I'll get the others who wanted this to also test it
before we push it out
just want to ensure it works on all the configurations and doesn't break people
Phyxion
@Phyxion
Jun 05 2015 15:24
yeah, I can do some testing
Blake Niemyjski
@niemyjski
Jun 05 2015 15:24
what do you mean by the has encountered a problem
Phyxion
@Phyxion
Jun 05 2015 15:24
I mean the message with Your email address (optional) when the app crashes
Blake Niemyjski
@niemyjski
Jun 05 2015 15:24
where are you seeing that
yeah
that comes from here
Phyxion
@Phyxion
Jun 05 2015 15:24
yeah I thought so
how to disable that?
Blake Niemyjski
@niemyjski
Jun 05 2015 15:25
happens when your app crashs
to not show that dialog?
Phyxion
@Phyxion
Jun 05 2015 15:25
yes, I don't want to show the dialog as I already use one myself.
(which is translated)
Blake Niemyjski
@niemyjski
Jun 05 2015 15:25
        ExceptionlessClient.Default.Register(false);
Phyxion
@Phyxion
Jun 05 2015 15:26
that's all? does the rest still work then?
Blake Niemyjski
@niemyjski
Jun 05 2015 15:26
pass false to the overload
yes
it just doesn't show the dialog
Phyxion
@Phyxion
Jun 05 2015 15:26
alright, great.
Blake Niemyjski
@niemyjski
Jun 05 2015 15:26
we got you covered
lol
Phyxion
@Phyxion
Jun 05 2015 15:27
It's very strange that I get it though, I still use 1.5xx, this didn't have it I think?
it's still .Current.Register here as well
it does accept false though, I don't remember this before at least.
btw, with the new .NET 4.0 libs, did you already verify that it's actually .NET 4.0 stuff? If the file sizes are different, it probably is.
regardless, if you have something available to test, please send it over (can be through PM as well).
I'm going for dinner but I'll be back in 30-40 mins
Blake Niemyjski
@niemyjski
Jun 05 2015 15:30
wlp that was a bug lol
it did
I'm pretty sure it did
why haven't you upgraded :D
pcl?
Phyxion
@Phyxion
Jun 05 2015 15:30
what do you mean?
Blake Niemyjski
@niemyjski
Jun 05 2015 15:30
yeah didn't you see me open the files
Phyxion
@Phyxion
Jun 05 2015 15:31
no, I didn't :smile: But dinner first, I'll be back
Blake Niemyjski
@niemyjski
Jun 05 2015 15:31
blob
Phyxion
@Phyxion
Jun 05 2015 16:29
very nice
I'm back now, you need any testing?
Phyxion
@Phyxion
Jun 05 2015 17:49
@niemyjski you still here?
Blake Niemyjski
@niemyjski
Jun 05 2015 17:49
yeah
I'm here
just yelling at the nuget team
tired of there shit
down every day is unacceptable
yeah if you could pull down the feed and do some testing
would be a huge help
need to ensure the right library is picked up
Phyxion
@Phyxion
Jun 05 2015 17:51
I will do that early next week, I don't have time for it anymore.
Blake Niemyjski
@niemyjski
Jun 05 2015 17:51
and that it works
ok
Phyxion
@Phyxion
Jun 05 2015 17:51
if you remember, you can add another message on monday to remind me about it :clap:
Blake Niemyjski
@niemyjski
Jun 05 2015 17:51
ok
@Phyxion please test :D
what are you doing this weekend
Phyxion
@Phyxion
Jun 05 2015 17:55
I'm not available this weekend unfortunately, I have other business to attend to.
Blake Niemyjski
@niemyjski
Jun 05 2015 17:55
yeah I get that
Phyxion
@Phyxion
Jun 05 2015 17:55
I will check it out monday
Blake Niemyjski
@niemyjski
Jun 05 2015 17:55
just making small talk
doing anything fun?
Phyxion
@Phyxion
Jun 05 2015 17:56
yeah, going on a motorcycle trip :smile:
what do you want tested? I don't really run any PCL stuff here so I pretty much can test 4.0 stuff.
Blake Niemyjski
@niemyjski
Jun 05 2015 17:58
test the 4.0 stuff
nice what kind of bike
:o images even attach here, that's nice.
Blake Niemyjski
@niemyjski
Jun 05 2015 17:59
I want one so bad
Phyxion
@Phyxion
Jun 05 2015 17:59
do you already have a license?
Blake Niemyjski
@niemyjski
Jun 05 2015 18:00
I've had a close friend die on one.. and I'm not scared of speed
nope
grew up riding dirt bikes
Phyxion
@Phyxion
Jun 05 2015 18:01
that's terrible :( I'm not scared of speed either, but i don't really like riding > 70 mph, too much wind
so it's not really an issue for me
Blake Niemyjski
@niemyjski
Jun 05 2015 18:01
yeah
Phyxion
@Phyxion
Jun 05 2015 18:02
i crashed once (not my fault) but never stopped riding
Blake Niemyjski
@niemyjski
Jun 05 2015 18:02
I want a viper
glad your ok
Phyxion
@Phyxion
Jun 05 2015 18:02
yeah i wasn't hurt that badly, crashed into a car at 30 mph or something
smacked on the back and fell down, but barely got a scratch, leg and arms hurt for 2 weeks but thats about it
i got lucky
bike was wrecked but got another one a month after, I still enjoy every second of it, absolutely worth it.
well recommended :)
Blake Niemyjski
@niemyjski
Jun 05 2015 18:04
yeah
are you ever worried about bad drivers
Phyxion
@Phyxion
Jun 05 2015 18:05
well, worried, no
you look out for them, absolutely
there are many terrible drivers over here so I'm always on the lookout :)
just double your distance you normally keep in the car and you should be fine. There are always idiots out there but thats also true for driving in the car.
or walking for that matter
i'm not someone that worried about things, they come as they go
safety is mostly something you have to take of yourself
Blake Niemyjski
@niemyjski
Jun 05 2015 18:07
yeah but you have a little more saftey in a car when someone trys driving you off the road
yeah
Phyxion
@Phyxion
Jun 05 2015 18:07
true, but how often does that happen?
I never really had that before
if you don't trust it when you over take someone, just wait, I don't race, I drive for fun, so it'll take a minute longer to get somewhere, it's only entertainment for me :)
Blake Niemyjski
@niemyjski
Jun 05 2015 18:09
We think that's how my friend died
also when I was living in dallas long time ago some duded hit a guy on a bike and dragged him a mile or two right in front of our work
yeah :)
that's the safe way to gto
Phyxion
@Phyxion
Jun 05 2015 18:10
that really sucks, I never had that before. I only encountered it once with a truck trying to ram my car, but in those situations I just brake to a standstill and wait for it to go over.
on a motorcycle I hardly drive on the highways, not a lot of traffic on small roads
if you think about driving motorcycles, just do it
Blake Niemyjski
@niemyjski
Jun 05 2015 18:12
yeah
I will
need to finish my other tasks first
go for my final checkride for my private piliots license tomorrow
getting married in a year
need to do those and then think about a bike
:)
Phyxion
@Phyxion
Jun 05 2015 18:13
I hesitated first too but decided to do one practice hour and was sold :)
you're doing ppl?
Blake Niemyjski
@niemyjski
Jun 05 2015 18:13
yeah
passed my written and oral part
go up tomorrow for the check
kinda scared
do you have your license?
Phyxion
@Phyxion
Jun 05 2015 18:14
very nice, I want to do that for a long time already
no unfortunately not
Blake Niemyjski
@niemyjski
Jun 05 2015 18:14
It's probably the most challenging thing I've done
the tests are hard
Phyxion
@Phyxion
Jun 05 2015 18:15
it's extremely expensive here and pretty limited (not really international like ppl)
I still want to get a license but then I'll probably go to the USA for a month or so and get it there
Blake Niemyjski
@niemyjski
Jun 05 2015 18:17
where are you from?
Phyxion
@Phyxion
Jun 05 2015 18:18
The Netherlands
Blake Niemyjski
@niemyjski
Jun 05 2015 18:18
you'll need more than a month
maybe 2
takes like 40 hours
but you can't do it 8-5..
the first two weeks will drain you after an hour a day
Phyxion
@Phyxion
Jun 05 2015 18:18
I looked it up a while ago, it's possible within a month (3 weeks or so), you basically do half a day for 5 days each week
Blake Niemyjski
@niemyjski
Jun 05 2015 18:18
so much mental and physical load
Phyxion
@Phyxion
Jun 05 2015 18:18
yeah I suspected as much
they advertised with that though. I might do some intro lessons here and then continue in the US
Blake Niemyjski
@niemyjski
Jun 05 2015 18:19
yeah
don't do a flight sim until after you get some lessions in
otherwise you'll learn some bad practices
Phyxion
@Phyxion
Jun 05 2015 18:19
here in NL they just hop you straight in an air plane
Blake Niemyjski
@niemyjski
Jun 05 2015 18:20
idk you could probably do it in a month but you'd be pretty rough the first week or two..
The biggest thing is ground school.
i didn't do it I just studied by myself but if you took all the book work / ground work a head of time it's def possible in a month
Phyxion
@Phyxion
Jun 05 2015 18:21
i talked to someone a while ago about it, but it costs too much here (around 40k)
Blake Niemyjski
@niemyjski
Jun 05 2015 18:21
dam
I go to a very small town and a club
Phyxion
@Phyxion
Jun 05 2015 18:21
and it's a useless license as its only valid within a couple of countries
Blake Niemyjski
@niemyjski
Jun 05 2015 18:21
costs me about 75-80$ an hour for plane and instructor and fuel.. then 20$ a month for club dues that also includes insurance for a 172m..
if I go to a bigger town or fbo.. they want like 130$ withour insurance or an instructor
yeah
but it's fun :D
Phyxion
@Phyxion
Jun 05 2015 18:22
that's very cheap, it costs 300 here to fly for an hour
Blake Niemyjski
@niemyjski
Jun 05 2015 18:22
dam
come here.. you can stay at my place :)
Phyxion
@Phyxion
Jun 05 2015 18:23
yeah way too expensive (they have very high fees for airports), one landing already sets you back 50 (same for a take off)
Blake Niemyjski
@niemyjski
Jun 05 2015 18:23
wow
that's insane
Phyxion
@Phyxion
Jun 05 2015 18:23
yeah not a lot of flyers out here, many go to US for a license
Blake Niemyjski
@niemyjski
Jun 05 2015 18:23
why do they do that?
Phyxion
@Phyxion
Jun 05 2015 18:23
for money? :P
Blake Niemyjski
@niemyjski
Jun 05 2015 18:24
they can get money for other things..
build your own community airport :)
Phyxion
@Phyxion
Jun 05 2015 18:24
all airports have that here (smaller ones are cheaper but still 30-40 for each action or something)
nearly impossible
nobody wants an airport around their houses here
too many people complaining here for like a plane once in an hour
Blake Niemyjski
@niemyjski
Jun 05 2015 18:25
that's kind of bs
people need to relax
Phyxion
@Phyxion
Jun 05 2015 18:25
its basically really terrible. I still wouldn't have done it here even if the price was OK because the license is only valid in The Netherlands / Belgium / DE I think
very limited, completely rubbish
Blake Niemyjski
@niemyjski
Jun 05 2015 18:25
If you got it in the us would it transfer?
they say you would just need to get a radio license for me to go into canada or mexico
Phyxion
@Phyxion
Jun 05 2015 18:26
i might never fly over these borders, but who knows, why limit yourself to it. US PPL works pretty much everywhere in the world and you can even renew it here.
Blake Niemyjski
@niemyjski
Jun 05 2015 18:26
very nice
ours never expires but you have a biennial review.. they are also working on getting rid of the medical requirement :D
Phyxion
@Phyxion
Jun 05 2015 18:27
we need to renew once every 10 years
its just a medical check pretty much
Blake Niemyjski
@niemyjski
Jun 05 2015 18:27
gotcha
yeah.. if you ever want to come over.. I'll help you get it..
I'd recommend taking the studying for regulations / ground school there first.
Phyxion
@Phyxion
Jun 05 2015 18:27
sounds great :)
Blake Niemyjski
@niemyjski
Jun 05 2015 18:27
cause that's a large part of it where you can do anywhere
Phyxion
@Phyxion
Jun 05 2015 18:28
yeah
that said, the weather is turning worse here, I'll go close up, see ya around :)
Blake Niemyjski
@niemyjski
Jun 05 2015 18:29
see you
:)