These are chat archives for exceptionless/Discuss

9th
Jun 2015
Sander Rijken
@srijken
Jun 09 2015 07:31
that fixes the IE11 problem
Blake Niemyjski
@niemyjski
Jun 09 2015 12:30
sweet
Phyxion
@Phyxion
Jun 09 2015 12:52
hi @niemyjski , currently doing some testing with the new client
Blake Niemyjski
@niemyjski
Jun 09 2015 12:52
how's it working?
Phyxion
@Phyxion
Jun 09 2015 12:53
I encountered some problems but I doubt they are related to the .NET 4.0 build (which works fine).
I already reported some issues
currently testing a bit more
Gitter here doesn't list the stuff from .Net project I think?
exceptionless/Exceptionless.Net#24 exceptionless/Exceptionless.Net#25 exceptionless/Exceptionless#108
those I've reported
Blake Niemyjski
@niemyjski
Jun 09 2015 12:56
I don't think so
yeah I'll take a look in those
lots of tabs open :)
Phyxion
@Phyxion
Jun 09 2015 12:57
count me in :P
Blake Niemyjski
@niemyjski
Jun 09 2015 12:57
Enable SSL Should be enabled by default no?
Phyxion
@Phyxion
Jun 09 2015 12:58
No, if you have a URL that has https in it, you can use SSL automatically. With http you don't, there should be no need for that property?
Blake Niemyjski
@niemyjski
Jun 09 2015 12:59
we change it from https to http if it's false
and I think we might append it if it's not defined
Phyxion
@Phyxion
Jun 09 2015 12:59
yeah but you have to set the url
another thing I'd like to ask, I noticed that it takes quite some time between an unhandled exception and when the SubmittingEvent is fired. With 1.5.x this was almost immediately?
Blake Niemyjski
@niemyjski
Jun 09 2015 12:59
@ejsmith we should probably look into removing it.. it could be detected
like how long?
Phyxion
@Phyxion
Jun 09 2015 13:00
well 4-5s?
Blake Niemyjski
@niemyjski
Jun 09 2015 13:00
should be immediate or close to
hmm
any chance you could profile it
Phyxion
@Phyxion
Jun 09 2015 13:00
yeah sure
Blake Niemyjski
@niemyjski
Jun 09 2015 13:00
not sure what would be keeping it from running right away
not related question.. but do park and rides cost money?
Phyxion
@Phyxion
Jun 09 2015 13:00
let me fire up ANTS
pretty much 3200 methods without source
Blake Niemyjski
@niemyjski
Jun 09 2015 13:04
dang
lol
might have to debug with the source
hehe
Phyxion
@Phyxion
Jun 09 2015 13:06
Why does this: var builder = new EventBuilder(e.Event); builder.Submit(); not fire the SubmittingEvent again, but does var builder = new EventBuilder(e.Event, e.Client, e.PluginContextData); builder.Submit() fire it again? I got a stackoverflowexception.
Blake Niemyjski
@niemyjski
Jun 09 2015 13:07
hmm
can you create a test for it
sounds like a bug
Phyxion
@Phyxion
Jun 09 2015 13:07
it's just those few lines
Blake Niemyjski
@niemyjski
Jun 09 2015 13:08
if (!OnSubmittingEvent(ev, pluginContextData)) {
_log.Value.FormattedInfo(typeof(ExceptionlessClient), "Event submission cancelled by event handler: id={0} type={1}", ev.ReferenceId, ev.Type);
return;
}
Phyxion
@Phyxion
Jun 09 2015 13:08
alright, time between exception and submittingevent firing is 8s in ANTS (but it's at least 50% slower so I'd say 3-4s)
Blake Niemyjski
@niemyjski
Jun 09 2015 13:08
dang
Phyxion
@Phyxion
Jun 09 2015 13:09
I originally just had new EventBuilder(e.Event) but noticed that there were more available now and thought I'd just set everything
var builder = new EventBuilder(e.Event, e.Client, e.PluginContextData);
e.Cancel = true; and then builder.Submit() doesn't work either.
Blake Niemyjski
@niemyjski
Jun 09 2015 13:11
let me look
Phyxion
@Phyxion
Jun 09 2015 13:13
It's , e.PluginContextData, if I just add e.Event and e.Client it works
Blake Niemyjski
@niemyjski
Jun 09 2015 13:14
so
Phyxion
@Phyxion
Jun 09 2015 13:15
exceptionless/Exceptionless.Net#26
there
Blake Niemyjski
@niemyjski
Jun 09 2015 13:16
because if you cancel it, it will bail as fast as possible because you canceled event submission
Phyxion
@Phyxion
Jun 09 2015 13:16
with or without e.Cancel, it doesn't matter, it generates a StackOverflow exception on the .Submit()
Blake Niemyjski
@niemyjski
Jun 09 2015 13:17
yeah
that will submit a stack overflow lol
submitting event is called when you call Submit
Phyxion
@Phyxion
Jun 09 2015 13:17
no, it won't submit anything, just crash completely :P
Blake Niemyjski
@niemyjski
Jun 09 2015 13:17
so you are calling submit during submission
on the same event
Phyxion
@Phyxion
Jun 09 2015 13:18
yes I always did so and it works fine without the e.PluginContextData
Blake Niemyjski
@niemyjski
Jun 09 2015 13:18
i guess since you are calling cancel it should work.. but
Phyxion
@Phyxion
Jun 09 2015 13:18
I don't want Exceptionless to submit data, I want to add several data to the event before it's submitted.
Blake Niemyjski
@niemyjski
Jun 09 2015 13:18
then just add data to the event and don't cancel it
:)
Phyxion
@Phyxion
Jun 09 2015 13:19
yeah but you don't have an EventBuilder anymore
not that it's that bad
Blake Niemyjski
@niemyjski
Jun 09 2015 13:20
no, that's because the event is already constructed
you still have extension methods off of the event
as well as the original context data
Phyxion
@Phyxion
Jun 09 2015 13:21
yeah I think I can work around this
it's not such a big issue as I wanted to rewrite some of it anyway.
it's still an issue though
Blake Niemyjski
@niemyjski
Jun 09 2015 13:24
I'm wiriting a test for these
Phyxion
@Phyxion
Jun 09 2015 13:24
k
I'll just rewrite what I have now (its only a few LOC anyway) and see if I can wire it all together
the boolean issue is the one I dislike the most as I now have to add .ToString() to a lot of data :D
Phyxion
@Phyxion
Jun 09 2015 13:33
new one: exceptionless/Exceptionless.UI#39
Blake Niemyjski
@niemyjski
Jun 09 2015 13:33
i wouldn't do that
just use the boolean and we'll get it resolved
btw..
trying to create a unit test for this event handler stuff
Phyxion
@Phyxion
Jun 09 2015 13:34
yeah but its one page only so I can replace all ToStrings on the page with nothing, no big issue :)
this way I can at least check if the rest is working
Blake Niemyjski
@niemyjski
Jun 09 2015 13:34
yeah.. just kind of sucks
Phyxion
@Phyxion
Jun 09 2015 13:34
boolean one is very strange as it's only with False, all True's work fine
is there any way I can add data to the Environment tab myself?
Blake Niemyjski
@niemyjski
Jun 09 2015 13:36
not without forking the code
what's missing
extended data?
Phyxion
@Phyxion
Jun 09 2015 13:36
well I'm missing the operating system language mostly
Blake Niemyjski
@niemyjski
Jun 09 2015 13:37
en-us?
is there a good way to populate that
Phyxion
@Phyxion
Jun 09 2015 13:37
yes
CultureInfo.InstalledUICulture
I also added the screen resolutions but that's not as easy as that one :P
CultureInfo.InstalledUICulture.EnglishName for a more human friendly one
Blake Niemyjski
@niemyjski
Jun 09 2015 13:38
    [Fact]
    public void CanFireOnSubmittingEvent() {
        var client = CreateClient();
        var ev = new Event { Message = "Unit Test" };
        var list = new List<EventSubmittingEventArgs>();

        client.SubmittingEvent += (sender, e) => {
            list.Add(e);
        }; 

        new EventBuilder(ev, client).Submit();
        Assert.Equal(1, list.Count);

        new EventBuilder(ev, client, new ContextData()).Submit();
        Assert.Equal(2, list.Count);  
    }
passes
ok
I'd add it as extended data and add a card for the ui project
we have a directive there already
you could create a pull request if you wanted :D
3 lines of html
Phyxion
@Phyxion
Jun 09 2015 13:39
yeah I already have data added to the extended data
please check my code from the reported issue
it's different than what you have
back in 15 mins or so, coffee break :)
Blake Niemyjski
@niemyjski
Jun 09 2015 13:41
so yeah..
the reason that throws a stack overflow is because plugincontext data is being reused and that has items for the original error as well as marking that error as an unhandled exception
so you get into a constant loop
question is.. can we do something to detect it
Phyxion
@Phyxion
Jun 09 2015 14:07
and back
Blake Niemyjski
@niemyjski
Jun 09 2015 14:08
sweet
Phyxion
@Phyxion
Jun 09 2015 14:08
why not copy everything from the original object?
if you do a new EventBuilder, that is.
Blake Niemyjski
@niemyjski
Jun 09 2015 14:10
because it's passed in context data and that's overhead
on millions of events
what is your end goal
just to add or change data on the event
you can do anything to it
Phyxion
@Phyxion
Jun 09 2015 14:11
yeah I already have it working
as I said, it's not a problem to workaround it
it's still a bug though
Blake Niemyjski
@niemyjski
Jun 09 2015 14:14
not 100% sure your causing it
should we bail out yes
but that will cause the client to become slower
I'm not sure how to fix it
Phyxion
@Phyxion
Jun 09 2015 14:15
what would normally be the usecase for adding the plugin context?
Blake Niemyjski
@niemyjski
Jun 09 2015 14:15
other than adding a marker that it's already been ran on the plugincontext data
but then you can never reuse the plugin context data
we never really intended it to be used like that
@ejsmith thoughts?
Phyxion
@Phyxion
Jun 09 2015 14:15
if you use e.Cancel = true before the Submit, why would it still go through then?
It seems to me that if it should be cancelled it should no longer submit another event
Blake Niemyjski
@niemyjski
Jun 09 2015 14:16
and that isn't passed through
your canceling the event arg
the issue is your plugin context data
new EventBuilder(e.Event, e.Client, e.PluginContextData);
has a property called "@@_IsUnhandledError"
which is set to true
Phyxion
@Phyxion
Jun 09 2015 14:17
ah yeah nevermind, I was thinking about the context of the event, not the arguments.
Blake Niemyjski
@niemyjski
Jun 09 2015 14:17
so your if logic to submit a new event and cancel the previous one causes an endless loop
I don't think we should cause a stack overflow
but not sure how to fix it..
because your expllicitely calling submit on it
Phyxion
@Phyxion
Jun 09 2015 14:18
but what is the plugin context doing so special then? can't you override something when you pass it to the constructor?
Blake Niemyjski
@niemyjski
Jun 09 2015 14:18
it's just a stupid key value pair
Phyxion
@Phyxion
Jun 09 2015 14:19
but why is the event called again when you pass along the plugin context and not without?
i mean, the plugin context must do something special i assume
Blake Niemyjski
@niemyjski
Jun 09 2015 14:20
nope
let me look
so yeah
...
as before... your context data contains the original exception and the property that marks it as an unhandled error
so your logic says to call it again only when it's an unhandled error
Phyxion
@Phyxion
Jun 09 2015 14:25
ah well, it's not that important as you can now easily add it directly to the event anyway
this was more the code I had originally
Blake Niemyjski
@niemyjski
Jun 09 2015 14:25
yeah
really
what did you have before
Phyxion
@Phyxion
Jun 09 2015 14:25
with 1.5.x I had UnhandledException and then basically that
but everything was somewhat different
current way makes more sense so I already changed it
Sander Rijken
@srijken
Jun 09 2015 14:27
hmm I call ExceptionlessClient.Default.Configuration.UseReferenceIds();, but when an exception occurs, there's no last reference ID known..
this is with <customErrors defaultRedirect="~/ErrorMessage.aspx" redirectMode="ResponseRewrite" />, in case that matters..
Blake Niemyjski
@niemyjski
Jun 09 2015 14:30
hmmm
there should be
it adds a plugin and it will be set after submit is called @srijken
could it be that it's still submitting
Sander Rijken
@srijken
Jun 09 2015 14:31
hmm
Blake Niemyjski
@niemyjski
Jun 09 2015 14:31
@Phyxion I closed that issue but added a test for it so we know about it...
Phyxion
@Phyxion
Jun 09 2015 14:31
yes I saw in email
now all the other issues I've reported @niemyjski :P
Blake Niemyjski
@niemyjski
Jun 09 2015 14:31
        _lastReferenceIdManager.Value.SetLast(ev.ReferenceId); is called at the very last line of Submit()
Sander Rijken
@srijken
Jun 09 2015 14:32
that's inserting into the queue?
Blake Niemyjski
@niemyjski
Jun 09 2015 14:32
we run all the plugins on it and then insert it into the queue
it should be set.
Sander Rijken
@srijken
Jun 09 2015 14:33
hmm wait a minute
Blake Niemyjski
@niemyjski
Jun 09 2015 14:33
guess I should add a unit test for that..
Sander Rijken
@srijken
Jun 09 2015 14:33
it's also not submitting to you guys, so there's another problem here
Blake Niemyjski
@niemyjski
Jun 09 2015 14:33
yeah.. that would be a huge problem
I just added a unit test on our end to verify that reference ids are used
Blake Niemyjski
@niemyjski
Jun 09 2015 14:38
exceptionless/Exceptionless.Net@4060404
@srijken, let me know.. I can debug it with you.
@Phyxion, were you able to figure out why that was taking so long to fire submitting event?
was it just due to the recursive nature of the previous code?
Phyxion
@Phyxion
Jun 09 2015 14:41
I doubt it as i was having a breakpoint immediately after the event.
but not figured it out yet, no
Blake Niemyjski
@niemyjski
Jun 09 2015 14:41
If you could create a unit test to repo, I'll pull it down and get to the bottom of it
Phyxion
@Phyxion
Jun 09 2015 14:41
will check in a few minutes, need to write a few more lines first.
Blake Niemyjski
@niemyjski
Jun 09 2015 14:41
I have not seen that before
ok
Phyxion
@Phyxion
Jun 09 2015 14:46
is there a way to determine if everything has been submitted @niemyjski ?
Sander Rijken
@srijken
Jun 09 2015 14:47
Exceptionless.Web is a http module right?
Blake Niemyjski
@niemyjski
Jun 09 2015 14:48
@Phyxion view the logs
/ check your dashboard
Phyxion
@Phyxion
Jun 09 2015 14:48
i mean more like in a method
Blake Niemyjski
@niemyjski
Jun 09 2015 14:48
@srijken that's a namespace but there is an http module in that lib
Phyxion
@Phyxion
Jun 09 2015 14:48
when an unhandled exception occurs, I close the app but nothing is submitted yet
Blake Niemyjski
@niemyjski
Jun 09 2015 14:48
Call process queue
but I wouldn't recommend calling it ( as we call it in a background for you automatically)
if your debugging / call it
if not, don't :)
Sander Rijken
@srijken
Jun 09 2015 14:49
right, something removed it from the <modules> section.. that's another way to reach "exceptionless" :)
Blake Niemyjski
@niemyjski
Jun 09 2015 14:49
wonder what removed it
should always be there
Phyxion
@Phyxion
Jun 09 2015 14:50
but I wouldn't recommend calling it ( as we call it in a background for you automatically)
if your debugging / call it
Sander Rijken
@srijken
Jun 09 2015 14:50
probably some failed nuget package update
Blake Niemyjski
@niemyjski
Jun 09 2015 14:50
when you upgrade a package it will be removed but will be readded unless that failed
Phyxion
@Phyxion
Jun 09 2015 14:50
yeah but I need to know if everything is submitted
regardless if its debug or not
Blake Niemyjski
@niemyjski
Jun 09 2015 14:50
@Phyxion we call it in a background timer as well as ensure everything is processed when the process is closing /exiting
Sander Rijken
@srijken
Jun 09 2015 14:50
we use Web and WebApi together.. now I did Update-Package -reinstall Exceptionless.Web.. And now .WebApi is missing from the project file?
Phyxion
@Phyxion
Jun 09 2015 14:51
it doesn't work with Environment.Exit(0) :)
Blake Niemyjski
@niemyjski
Jun 09 2015 14:51
yeah well.
lol
we try
in that case call process queue
we wire up to the process exiting event and call submit
Who do you guys use for dns
one of our main sites is offline due to dns issues with dnsimple
Phyxion
@Phyxion
Jun 09 2015 14:52
opendns
always
Blake Niemyjski
@niemyjski
Jun 09 2015 14:52
for domains?
Phyxion
@Phyxion
Jun 09 2015 14:52
oh for domains, i thought @ home
no, just the one from the provider
it 'works'
Blake Niemyjski
@niemyjski
Jun 09 2015 14:53
hmm
ok
Sander Rijken
@srijken
Jun 09 2015 14:53
you mean what registrar?
Blake Niemyjski
@niemyjski
Jun 09 2015 14:53
no what dns provider for domains
but what registrar do you use
Sander Rijken
@srijken
Jun 09 2015 14:53
our own domains?
Blake Niemyjski
@niemyjski
Jun 09 2015 14:53
I recently moved some of my domains to google domains
they better not close that service down
Sander Rijken
@srijken
Jun 09 2015 14:54
transip.nl; we have a lot there
Phyxion
@Phyxion
Jun 09 2015 14:54
knowing Google, they will
Sander Rijken
@srijken
Jun 09 2015 14:54
also colocation
Blake Niemyjski
@niemyjski
Jun 09 2015 14:56
yeah
we are all in azure
i can't wait to get rid of our colo boxes
Sander Rijken
@srijken
Jun 09 2015 14:56
for some things azure is way way more expensive
they have this RemoteApp service..
we did a test with that, 2 users, 1 app
$300+ in a month
Phyxion
@Phyxion
Jun 09 2015 14:57
yeah we don't use Azure because of the costs.
Sander Rijken
@srijken
Jun 09 2015 14:57
for webapp hosting they're ok
Phyxion
@Phyxion
Jun 09 2015 14:57
storage is way too expensive
Sander Rijken
@srijken
Jun 09 2015 14:57
really?
Phyxion
@Phyxion
Jun 09 2015 14:58
yeah last time I checked :)
Blake Niemyjski
@niemyjski
Jun 09 2015 14:58
hehe
Sander Rijken
@srijken
Jun 09 2015 14:59
well it's worth something when you can stop replacing broken or almost broken disks :)
Blake Niemyjski
@niemyjski
Jun 09 2015 14:59
I have a personal blog and I'm going to do github pages cause I never blog
lol
been paying 100$ for ever on a vps
need to get rid of it
yeah
Phyxion
@Phyxion
Jun 09 2015 14:59
a month???
Blake Niemyjski
@niemyjski
Jun 09 2015 15:00
yeah
Sander Rijken
@srijken
Jun 09 2015 15:00
for a VPS? wtf
Blake Niemyjski
@niemyjski
Jun 09 2015 15:00
:(
Phyxion
@Phyxion
Jun 09 2015 15:00
what kind of doomsday machine is that :P
Blake Niemyjski
@niemyjski
Jun 09 2015 15:00
I have a friend going in on half every month but still
we need to get rid of it
I wish I could pay 10$ a month for a site on azure
but it seems like it's just way more than that
Phyxion
@Phyxion
Jun 09 2015 15:00
I pay that for a dedicated server
Blake Niemyjski
@niemyjski
Jun 09 2015 15:00
where is your dedicated? I could just paypal you :D
lol
Sander Rijken
@srijken
Jun 09 2015 15:01
I pay 5 per month for a VPS :)
Blake Niemyjski
@niemyjski
Jun 09 2015 15:01
is it any good
Sander Rijken
@srijken
Jun 09 2015 15:01
no maybe not
Blake Niemyjski
@niemyjski
Jun 09 2015 15:01
@Phyxion you created so many issue
I'm not sure where to start
Phyxion
@Phyxion
Jun 09 2015 15:01
yeah you can thank me later @niemyjski :P
maybe start with the boolean bug
it's the most annoying
Blake Niemyjski
@niemyjski
Jun 09 2015 15:02
I think I need to test the .net 4.0 changes and get those out first
@srijken our marketing guy is working on the 1.0 release email for js
you think it's ready
Sander Rijken
@srijken
Jun 09 2015 15:02
cool
I have 1 core, 1024MB, 50G SSD and 1TB data for 5/month
Blake Niemyjski
@niemyjski
Jun 09 2015 15:03
@Phyxion Yeah, I have a beast vps box when I bought it years ago
still running 2008r2 :D
Sander Rijken
@srijken
Jun 09 2015 15:03
or 2 core and 4G, 150G and 5T for 10/month
Blake Niemyjski
@niemyjski
Jun 09 2015 15:03
dang.. link
Sander Rijken
@srijken
Jun 09 2015 15:03
you probably also pay them monthly for the windows license then
Phyxion
@Phyxion
Jun 09 2015 15:04
xeon 4 cores / 16GB RAM / 2TB disk / 20TB data for 100$ or something here
Phyxion
@Phyxion
Jun 09 2015 15:04
includes Windows
2012 R2 (which I like a lot more than 2008 R2)
Sander Rijken
@srijken
Jun 09 2015 15:05
windows is 7,50/m there
Blake Niemyjski
@niemyjski
Jun 09 2015 15:05
so like 10usd
lol
Sander Rijken
@srijken
Jun 09 2015 15:05
that's on top of the other price
Phyxion
@Phyxion
Jun 09 2015 15:06
yeah windows licenses aren't that expensive unless you want the datacenter edition
Blake Niemyjski
@niemyjski
Jun 09 2015 15:06
blob
Sander Rijken
@srijken
Jun 09 2015 15:06
we used to have 3 of those in our MS partner deal, now it's down to 1.. wtf
Blake Niemyjski
@niemyjski
Jun 09 2015 15:06
@srijken 15,13 != 5
Sander Rijken
@srijken
Jun 09 2015 15:06
I'm not running windows on my VPS
Phyxion
@Phyxion
Jun 09 2015 15:07
it does include VAT @niemyjski you can get it back from your tax agency :D
Blake Niemyjski
@niemyjski
Jun 09 2015 15:07
eh it's all good
I just got my private pilot license over the weekend
Phyxion
@Phyxion
Jun 09 2015 15:07
regardless, your VPS is very overpriced :P
Blake Niemyjski
@niemyjski
Jun 09 2015 15:07
now I'll have some free time to move my site to github :D
Sander Rijken
@srijken
Jun 09 2015 15:07
congrats :)
Phyxion
@Phyxion
Jun 09 2015 15:07
congrats :+1:
Blake Niemyjski
@niemyjski
Jun 09 2015 15:08
thanks
so I'll have time to convert to markdown for $$ profit
Phyxion
@Phyxion
Jun 09 2015 15:08
are you planning on buying a plane or will you rent it?
Sander Rijken
@srijken
Jun 09 2015 15:08
@niemyjski installing .WebApi removes .Web from the modules..
to repro, install both in a site, and then update-package -reinstall the WebApi one
Phyxion
@Phyxion
Jun 09 2015 15:13
6/9/2015 5:12:34 PM -> Throw exception...
9-6-2015 17:12:38 -> Received... so 4s delay
i'll check if I can find something useful
Blake Niemyjski
@niemyjski
Jun 09 2015 15:14
rent it for now
I want an rv
vans rv :D
hmm. it shouldn't
Phyxion
@Phyxion
Jun 09 2015 15:14
very nice plane
Blake Niemyjski
@niemyjski
Jun 09 2015 15:14
guess we can check
yeah
Phyxion
@Phyxion
Jun 09 2015 15:14
how much does something like that cost?
Blake Niemyjski
@niemyjski
Jun 09 2015 15:14
35-80 depending on what one you get
only downside is it's a 2 person and when I get a family it will be an issue
Phyxion
@Phyxion
Jun 09 2015 15:15
you can hook them up on top :P
Blake Niemyjski
@niemyjski
Jun 09 2015 15:18
yeah
lol
idk, I'd love to have that
but I'm getting really anticonsumerist
even though my wedding is off the charts lol
Phyxion
@Phyxion
Jun 09 2015 15:19
ah you got to have some fun too, life's too short to save up everything
i can't say that I see any obvious reason why the delay is so long
it just doesn't do anything for 4-5 seconds and then fires the event
profiling in ANTS isn't that useful either at least
Blake Niemyjski
@niemyjski
Jun 09 2015 15:20
yeah
that's odd
if you can add a test for it
I can check it over here
Sander Rijken
@srijken
Jun 09 2015 15:21
ok, now I have the stuff working, ie it's posting exceptions again
but no last reference id
Blake Niemyjski
@niemyjski
Jun 09 2015 15:22
what was the issue with it not posting
what type of event is it? I'm assuming an error
Sander Rijken
@srijken
Jun 09 2015 15:22
missing module in <modules> section
Blake Niemyjski
@niemyjski
Jun 09 2015 15:22
if it's not an error it won't get a reference id
Sander Rijken
@srijken
Jun 09 2015 15:22
it's an error yeah
Blake Niemyjski
@niemyjski
Jun 09 2015 15:22
sigh, what module is missing
Sander Rijken
@srijken
Jun 09 2015 15:22
the exceptionless module got removed because of reinstalling Exceptionless.WebApi
but it's back now.. but still no referenceids
the module is working though
Blake Niemyjski
@niemyjski
Jun 09 2015 15:25
can you try pulling down the symbol source or source and seeing..
Sander Rijken
@srijken
Jun 09 2015 15:25
yeah
Blake Niemyjski
@niemyjski
Jun 09 2015 15:25
I added a unit test on our side to verify
wonder what is happening
maybe it's the same issue that @Phyxion is seeing where unhandled exceptions are taking a really long time to be queued/processed
what a sweet build error
1900 commits
or somewhere else?
found it
Phyxion
@Phyxion
Jun 09 2015 15:33
@niemyjski it's a lot faster in release mode, acceptable levels at least
1s or so
Blake Niemyjski
@niemyjski
Jun 09 2015 15:33
yeah
should be immediate
Sander Rijken
@srijken
Jun 09 2015 15:34
accordign to the debugger it's not enabled
Blake Niemyjski
@niemyjski
Jun 09 2015 15:34
source maps are a pain :(
source debugging*
Sander Rijken
@srijken
Jun 09 2015 15:35
nah it works fine
this is interesting
I hit SubmitEvent twice
Blake Niemyjski
@niemyjski
Jun 09 2015 15:37
for the exact same event or what?
Sander Rijken
@srijken
Jun 09 2015 15:37
hard to say
optimized code
I'm remote debugging right now
Blake Niemyjski
@niemyjski
Jun 09 2015 15:48
let me know what you find
I need to finish testing this so we can get it out there
and then I can do micro fixes like this
@srijken can you log an issue on the .net issue tracker for upgrading web package removes the web api one
seems really odd
@Phyxion what feed did you end up adding for myget
Sander Rijken
@srijken
Jun 09 2015 15:53
@niemyjski in ReferenceIdPlugin, context.Event.Type is null
Blake Niemyjski
@niemyjski
Jun 09 2015 15:53
hmm
Sander Rijken
@srijken
Jun 09 2015 15:53
the error plugin that sets it runs after the reference plugin
Blake Niemyjski
@niemyjski
Jun 09 2015 15:54
yeah shit
that priority should be after 30
nice find
Sander Rijken
@srijken
Jun 09 2015 15:56
:)
I'll change the error page so that it only shows the thing when there actually is a reference id
because that can still happen
I love how much easier debugging has become the last few years
Blake Niemyjski
@niemyjski
Jun 09 2015 15:58
yeah
:)
@srijken I also just fixed the issue you just hit
fix has been committed
nice find
Sander Rijken
@srijken
Jun 09 2015 15:58
ah the ID issue
I'll submit the other one as well
Blake Niemyjski
@niemyjski
Jun 09 2015 15:59
ok
Blake Niemyjski
@niemyjski
Jun 09 2015 16:10
@Phyxion @srijken think it's safe to push a new build withth e.net 4.0 changes
it looks good to me
picked up the references correctly
only thing I thought I noticed is if you call ToExceptionless() from a pcl lib then the pcl method is used..
I kinda would have thought that the fuller implementation would have been used
but it's due to the specific extension method that is being called
Phyxion
@Phyxion
Jun 09 2015 16:18
@Phyxion what feed did you end up adding for myget
ehm the one you linked to in the .NET 4.0 thread
i think that was the one?
Blake Niemyjski
@niemyjski
Jun 09 2015 16:19
yeah
it looks good to me
if you have no objections I'm going to push it
Phyxion
@Phyxion
Jun 09 2015 16:19
@Phyxion @srijken think it's safe to push a new build withth e.net 4.0 changes
it looks good to me
Blake Niemyjski
@niemyjski
Jun 09 2015 16:19
@srijken, if you have no objections I'm going to push a 1.0 release of the js client out
Phyxion
@Phyxion
Jun 09 2015 16:19
I agree
it's fine
Blake Niemyjski
@niemyjski
Jun 09 2015 16:19
ok
@Phyxion wonder if I should bump the version to 3.1 for the .net client
as it's a pretty big fix
or do you think this is good
Phyxion
@Phyxion
Jun 09 2015 16:21
I'm not really one that cares much about versions as long as it's working
I don't really look at NuGet packages' version numbers
Sander Rijken
@srijken
Jun 09 2015 16:22
semver.org :)
Blake Niemyjski
@niemyjski
Jun 09 2015 16:22
yes
been a while since we did a release there tho
guess I could call it 3.0.1
Phyxion
@Phyxion
Jun 09 2015 16:22
technically it could fall under x.x.THIS :)
Blake Niemyjski
@niemyjski
Jun 09 2015 16:23
even though our rev is 3.0.1348
Sander Rijken
@srijken
Jun 09 2015 16:23
that's what we do
Phyxion
@Phyxion
Jun 09 2015 16:23
just go with what you feel is right
Blake Niemyjski
@niemyjski
Jun 09 2015 16:23
hate creating a release called that lol
Phyxion
@Phyxion
Jun 09 2015 16:23
i don't care :)
3.0.1, 3.1, 4.0, either way will do :P
Sander Rijken
@srijken
Jun 09 2015 16:24
4.0 sounds like omg I'm gonna have to change things because they broke the API
Blake Niemyjski
@niemyjski
Jun 09 2015 16:24
yeah
I'm just going to do a 3.0.1
I think even tho the rev is really high
just stinks you don't know which version is what
lol
Sander Rijken
@srijken
Jun 09 2015 16:25
3.0.1 or 3.1 are both good, I wouldn't go for 3.0.1438 though
mixed that up, but well :)
Blake Niemyjski
@niemyjski
Jun 09 2015 16:25
if I do 3.1 then your going to know which release notes go with the nuget pckage
Phyxion
@Phyxion
Jun 09 2015 16:26
random.org/coins -> use todds decision maker coin and ask yourself: should I go with 3.1?
that one is better :P
Blake Niemyjski
@niemyjski
Jun 09 2015 16:27
lol
Sander Rijken
@srijken
Jun 09 2015 16:29
wow those images are slow
also the second and third time
Blake Niemyjski
@niemyjski
Jun 09 2015 16:32
lol
Sander Rijken
@srijken
Jun 09 2015 16:36
exceptionless/Exceptionless.Net#27
there's a powershell challenge for you :)
oh and regarding the versioning thing.. I just noticed the nuget build numbers.. and watching that I'm pro v3.1
Blake Niemyjski
@niemyjski
Jun 09 2015 16:48
hehe
they are deploying
redeploying due to one package failed
hate nuget
:D
Blake Niemyjski
@niemyjski
Jun 09 2015 16:57
Thanks section should stay or go? :D
Phyxion
@Phyxion
Jun 09 2015 16:57
can stay, fine by me :)
are they on NuGet already?
(so that I can remove the myget source)
Blake Niemyjski
@niemyjski
Jun 09 2015 16:57
blob
some of them are
others are pushing
I'd give it half hour to fully sync to all of nuget.
Phyxion
@Phyxion
Jun 09 2015 16:58
alright, let me know when they are there so I can update ;)
Blake Niemyjski
@niemyjski
Jun 09 2015 16:59
awe sweeeeeeet
my favorite time of the month!!
windows updates just released
lol
<-- craves the latest
Phyxion
@Phyxion
Jun 09 2015 16:59
ah nooo not again
Blake Niemyjski
@niemyjski
Jun 09 2015 17:00
lol
only 97mb
all but two of the packages are on nuget
only the windows one isn't pushed yet
Phyxion
@Phyxion
Jun 09 2015 17:01
alright
Blake Niemyjski
@niemyjski
Jun 09 2015 17:01
100% now
Phyxion
@Phyxion
Jun 09 2015 17:01
thanks ill check it in a few minutes
Phyxion
@Phyxion
Jun 09 2015 17:08
updated
lets see if its still working
btw @niemyjski Occurred On Jun 9, 2015 7:11:06 PM ( a few seconds ago ) , this isn't using my regional format
nor the one from the server for that matter
Blake Niemyjski
@niemyjski
Jun 09 2015 17:13
we do it for your browsers local time zone in one format
ours
we don't really do localized strings yet.
so many resources you can only do so much unfortantely and localization is last on the list :(
it's something we can take a look into
Phyxion
@Phyxion
Jun 09 2015 17:14
i agree about localization
was just curious as this looks like its forced to us culture
Blake Niemyjski
@niemyjski
Jun 09 2015 17:14
I think there already might be an issue for 24hour format.
yeah. it's the angular library we are using.. thing is I wonder if there is an angular localization thing we can pull down to change the filters
Phyxion
@Phyxion
Jun 09 2015 17:15
I don't want it in my own language, but I'd rather see it 19:11:06
Blake Niemyjski
@niemyjski
Jun 09 2015 17:15
yeah
Phyxion
@Phyxion
Jun 09 2015 17:15
AM / PM, never liked the notation :P
Blake Niemyjski
@niemyjski
Jun 09 2015 17:16
yeah
+1 the 24 hour format then :D
Blake Niemyjski
@niemyjski
Jun 09 2015 17:36
@srijken releasing a 1.0 js client unless you have an issue with it
Sander Rijken
@srijken
Jun 09 2015 17:40
it's good for me :)
Blake Niemyjski
@niemyjski
Jun 09 2015 17:40
:)
no turning back now
Blake Niemyjski
@niemyjski
Jun 09 2015 18:22
@srijken, that pull request you did for the .net client for aggregate exception
we'll get that taken care of
need to sit down and pair with someone on that :D
Sander Rijken
@srijken
Jun 09 2015 18:26
right
what's with JSON API?
Blake Niemyjski
@niemyjski
Jun 09 2015 18:31
looks kinda like odata
never heard of it before but i guess a standard way to tell the server what json properties you want / will use
like a filter
Sander Rijken
@srijken
Jun 09 2015 18:31
I wonder what makes this better than odata..
yeah, like odata
odata with breeze.js is great
Blake Niemyjski
@niemyjski
Jun 09 2015 18:36
I hate odata
Sander Rijken
@srijken
Jun 09 2015 18:36
why?
Blake Niemyjski
@niemyjski
Jun 09 2015 18:36
used it 3 years ago
and hated it
big clunky api
with tons of configuration
Sander Rijken
@srijken
Jun 09 2015 18:36
the urls are ugly, but I don't really care
Blake Niemyjski
@niemyjski
Jun 09 2015 18:36
yeah
tried writing a universial easy to use translator
Sander Rijken
@srijken
Jun 09 2015 18:37
Exceptionless.UI uses something similar?
Blake Niemyjski
@niemyjski
Jun 09 2015 18:37
that worked with telerik grid
nope
straight rest
we could do some optimization for sure ui side
but we want to use the same api anyone else would use
we mave "modes"
Sander Rijken
@srijken
Jun 09 2015 18:38
taking a break, brb
Blake Niemyjski
@niemyjski
Jun 09 2015 18:38
kk
Sander Rijken
@srijken
Jun 09 2015 19:21
Are there any changes between v0.9.1 and v1.0.0? (And there's no v1.0.0 tag on github yet..)
the latter is the reason I couldn't check for myself ;)
Blake Niemyjski
@niemyjski
Jun 09 2015 19:29
there is
Sander Rijken
@srijken
Jun 09 2015 19:30
oh right
Blake Niemyjski
@niemyjski
Jun 09 2015 19:30
no only changed the version :)
Sander Rijken
@srijken
Jun 09 2015 19:30
the others start with 'v' and sort above it
Blake Niemyjski
@niemyjski
Jun 09 2015 19:30
oh shit
:(
Sander Rijken
@srijken
Jun 09 2015 19:30
heh
Blake Niemyjski
@niemyjski
Jun 09 2015 19:32
fixed
Blake Niemyjski
@niemyjski
Jun 09 2015 19:38
thanks for pointing that out
can't believe I missed it