These are chat archives for exceptionless/Discuss

25th
Sep 2015
Sander Rijken
@srijken
Sep 25 2015 17:02
I'm planning to do some testcases in .javascript tonight, maybe more when that goes well
Sander Rijken
@srijken
Sep 25 2015 17:07
the oversized one is probably the first one. I'm not quite sure yet how to test for that, but I'll start by verifying that exclusion works as it should
why is passwordResetToken still expected to be in there?
Frank Ebersoll
@frankebersoll
Sep 25 2015 17:47
Hey sijken! Are you there?
Sander Rijken
@srijken
Sep 25 2015 17:48
hi
Frank Ebersoll
@frankebersoll
Sep 25 2015 17:49
Hi! I'm also looking into .javascript currently
Do you test in the browser or are you using Node.js?
Sander Rijken
@srijken
Sep 25 2015 17:49
Node.js at the moment
Frank Ebersoll
@frankebersoll
Sep 25 2015 17:50
Ok! Did you ever get unhandled exceptions working?
Sander Rijken
@srijken
Sep 25 2015 17:51
uhm, I'm testing using the test framework, are you doing that, or trying to write something in Node.js and use Exceptionless in that project?
Frank Ebersoll
@frankebersoll
Sep 25 2015 17:51
Test case as follows: empty app.js, require exceptionless as in the docs, set apiKey. Then throw new Error("test")
As I understand it, the error should be logged. But it doesnt.
Sander Rijken
@srijken
Sep 25 2015 17:52
never tried that
Frank Ebersoll
@frankebersoll
Sep 25 2015 17:53
Manually submitting stuff works. Unhandled exceptions dont.
So you are using node only for build and testing?
Sander Rijken
@srijken
Sep 25 2015 17:56
I'm using it in websites
uh exceptionless
the build is npm/gulp based, I'm using that for build and testing
need to run for a moment, for more help, probably hang around here until @niemyjski is back
Frank Ebersoll
@frankebersoll
Sep 25 2015 17:56
Okay. Alright, thanks
Sander Rijken
@srijken
Sep 25 2015 17:57
see you
Frank Ebersoll
@frankebersoll
Sep 25 2015 17:57
Bye
Blake Niemyjski
@niemyjski
Sep 25 2015 20:41
@srijken passwordResetToken shouldn’t be there
Sander Rijken
@srijken
Sep 25 2015 20:41
so the test is wrong in that case?
Blake Niemyjski
@niemyjski
Sep 25 2015 20:42
yeah I think so
it shouldn’t be included
Sander Rijken
@srijken
Sep 25 2015 20:42
I tried excluded "$template" in the real world, to see if it would work, and it didn't. But in the testcase it does
Blake Niemyjski
@niemyjski
Sep 25 2015 20:42
password matches anything starting with password
Sander Rijken
@srijken
Sep 25 2015 20:42
no
Blake Niemyjski
@niemyjski
Sep 25 2015 20:42
so might be the same use case that’s broken
Sander Rijken
@srijken
Sep 25 2015 20:42
password matches the word, password* is the startswith
Blake Niemyjski
@niemyjski
Sep 25 2015 20:43
yeah
password* should match password and passwords and passwordResetToken
Sander Rijken
@srijken
Sep 25 2015 20:43
so the real world thing. I also check if the settings came in, and they do. So I really wonder why it doesn't get filtered out
Blake Niemyjski
@niemyjski
Sep 25 2015 20:43
@frankebersoll want to update our sample to throw and I’ll take a look. I though you did a pull request for the unhandled event name in node.
might be a bug in the utils logic to check for that
guess we should dive into that
man I spent a whole dang day waiting in lines for the 6s+
Sander Rijken
@srijken
Sep 25 2015 20:44
heh
Blake Niemyjski
@niemyjski
Sep 25 2015 20:44
but I got it
:D
lol
should use a vacation day for today
@ejsmith :D
Sander Rijken
@srijken
Sep 25 2015 20:45
my 6 showed a scratch yesterday, didn't drop it, no keys in pocket etc, really don't understand it
Blake Niemyjski
@niemyjski
Sep 25 2015 20:45
@srijken any chance you can look into the exclusion logic for me?
Sander Rijken
@srijken
Sep 25 2015 20:45
but the conclusion is I need a new one now :P
sure
Blake Niemyjski
@niemyjski
Sep 25 2015 20:45
hahah yeah :D
Sander Rijken
@srijken
Sep 25 2015 20:46
first I have to test one last thing
Blake Niemyjski
@niemyjski
Sep 25 2015 20:47
ok
Sander Rijken
@srijken
Sep 25 2015 20:47
I just wanted to make sure the test tested the wrong thing before I started hacking my way into it :)
Blake Niemyjski
@niemyjski
Sep 25 2015 20:48
haha
yeah
Sander Rijken
@srijken
Sep 25 2015 20:55
oh, I had to npm install phantomjs locally
shouldn't that be a dev dependency?
Blake Niemyjski
@niemyjski
Sep 25 2015 21:03
yes it should
Sander Rijken
@srijken
Sep 25 2015 21:03
how can I debug the tests? Karma starts a webserver, but before the page loads, gulp quits
Blake Niemyjski
@niemyjski
Sep 25 2015 21:04
want to add it to dev
I use webstorm
which sets it up automatically
I reformatted since I last debugged those tests but I just set it up with webstorm and hit debug
Sander Rijken
@srijken
Sep 25 2015 21:06
hm
Blake Niemyjski
@niemyjski
Sep 25 2015 21:07
do you use webstorm
it’s the only thing this nub uses
Sander Rijken
@srijken
Sep 25 2015 21:07
not yet, I'm using brackets
Blake Niemyjski
@niemyjski
Sep 25 2015 21:07
oh
google: brackets -> debug karma/jasmine
I oculd imagine it’s as simple as setting a break point in chrome
Sander Rijken
@srijken
Sep 25 2015 21:13
probably very easy if you know how to do it lol
Blake Niemyjski
@niemyjski
Sep 25 2015 21:17
yeah
I watched lots of youtube videos
lol
I need to finish this up and then I can help
or I can pair with you