These are chat archives for exceptionless/Discuss

9th
Oct 2015
Blake Niemyjski
@niemyjski
Oct 09 2015 01:33
hehe I’ll start it up eveyr day if I remember
Blake Niemyjski
@niemyjski
Oct 09 2015 08:54
@frankebersoll everything ok
I just saw you deleted your branch
and closed the pull request
Frank Ebersoll
@frankebersoll
Oct 09 2015 09:14
hi @niemyjski
i reopened it. I renamed the branch from Tower and that f'd everything up-
I just made an update to TypeScript 1.6.2 on my local branch and fixed some things... unfortunately, that depends on my other commits
should I also push that to master?
I found out that all those /dist-files add clutter to the commits. why exactly are they version controlled?
Blake Niemyjski
@niemyjski
Oct 09 2015 15:44
yeah
push it
they are versioned so people can link to github as a cdn
also its nice to just grab a script from github and use it
basically usability
it’sa little more noise but if you change it in your same commit or in the commit after you are all done all is good
theit8514
@theit8514
Oct 09 2015 15:49
^ plus for bower it's good to have compiled js code instead of typescript for those of us who haven't made the transition :)
Blake Niemyjski
@niemyjski
Oct 09 2015 15:54
looks like your pull request was merged @frankebersoll
we could get rid of that node def now :)
@theit8514 that too :)
was up till 4am
I am a bit tired
think I may have to go make a pound of bacon and some eggs
Frank Ebersoll
@frankebersoll
Oct 09 2015 17:53
@niemyjski I already got rid of it, but the new typings require TypeScript 1.6
so I upgraded it.
Frank Ebersoll
@frankebersoll
Oct 09 2015 18:08
see 8b628286144799f92137f8446f44310ef8e79419
huh? SHA: 8b628286144799f92137f8446f44310ef8e79419
no auto linking here.
exceptionless/Exceptionless.JavaScript@8b62828
Eric J. Smith
@ejsmith
Oct 09 2015 18:34
here
Frank Ebersoll
@frankebersoll
Oct 09 2015 18:34
hey there
problem: my current pull request breaks logging of unhandled exceptions to the console. as soon as you add a handler, node does nothing about it any more.
example. without handler:
/volume1/homes/Frank/PhotoDedup/hash-generator.js:15
throw new Error("Test!");
^
Error: Test!
at ReadStream.<anonymous> (/volume1/homes/Frank/PhotoDedup/hash-generator.js:15:10)
at ReadStream.emit (events.js:107:17)
at fs.js:1618:12
at FSReqWrap.oncomplete (fs.js:95:15)
/volume1/homes/Frank/PhotoDedup/hash-generator.js:15
            throw new Error("Test!");
                  ^
Error: Test!
    at ReadStream.<anonymous> (/volume1/homes/Frank/PhotoDedup/hash-generator.js:15:10)
    at ReadStream.emit (events.js:107:17)
    at fs.js:1618:12
    at FSReqWrap.oncomplete (fs.js:95:15)
like that.
as soon as we add a handler, there is nothing. we can log the stack trace of course, but we don't get the source code (first two lines)
Blake Niemyjski
@niemyjski
Oct 09 2015 18:37
that’s not good
Frank Ebersoll
@frankebersoll
Oct 09 2015 18:37
Blake Niemyjski
@niemyjski
Oct 09 2015 18:37
is there anything on stack overflow about this
the library we use already does source maps for node
take a look at the parser
Frank Ebersoll
@frankebersoll
Oct 09 2015 18:38
ah! what, where?
I'm still getting familiar with the code base :-)
Eric J. Smith
@ejsmith
Oct 09 2015 18:39
yeah, Blake is the one who wrote this… he would know more.
which lib are we using blake?
Frank Ebersoll
@frankebersoll
Oct 09 2015 18:48
okay, I got it. DefaultErrorParser uses TraceKit
Blake Niemyjski
@niemyjski
Oct 09 2015 18:48
yeah
tracekit doesn’t support source maps
but
we use the nodestacktrace
which does source maps
it can be found in services/nodeerrorparser
Frank Ebersoll
@frankebersoll
Oct 09 2015 18:50
okay, but do we get the actual source code there?
I want to display the source code, not only the signature with line and column
Blake Niemyjski
@niemyjski
Oct 09 2015 18:52
I don’t think it captures context
and generally you might not want to
because most of the time it would be minified
Frank Ebersoll
@frankebersoll
Oct 09 2015 18:52
better idea. we don't register an uncaught-handler at all.
Blake Niemyjski
@niemyjski
Oct 09 2015 18:52
and or adds more memory to the browser /app
no?
how would we report them
Frank Ebersoll
@frankebersoll
Oct 09 2015 18:52
we use a shim.
Eric J. Smith
@ejsmith
Oct 09 2015 18:53
it wouldn’t be minified on the server.
Frank Ebersoll
@frankebersoll
Oct 09 2015 18:53
process.emit = ourProcessEmit
Blake Niemyjski
@niemyjski
Oct 09 2015 18:53
there has to be a way to register a handler but keep the existing behavior
Frank Ebersoll
@frankebersoll
Oct 09 2015 18:53
ourProcessEmit checks if event-type == uncaught. then, we don't have to register an own.
:-)
i'll try that.
Blake Niemyjski
@niemyjski
Oct 09 2015 18:54
okay :)
yeah that would probably work
with emit you just listen in on the event message loop right
Frank Ebersoll
@frankebersoll
Oct 09 2015 18:55
yes. we hijack the event raising method
Frank Ebersoll
@frankebersoll
Oct 09 2015 19:25
works. no need for another library.
Blake Niemyjski
@niemyjski
Oct 09 2015 19:29
sweet!
awesome work man
Frank Ebersoll
@frankebersoll
Oct 09 2015 19:31
what about SIGINT?
SIGINT usually exits, but doesn't call our exit-handler
we could fix this the same way, so if somebody calls submitEvent("asdf") and then hits Ctrl+C, we would still get it. i think.
Eric J. Smith
@ejsmith
Oct 09 2015 19:39
that would be really cool
we do that on windows console apps.
force the queue to process before the app exits.
Frank Ebersoll
@frankebersoll
Oct 09 2015 19:40
okay, we're gonna do that in node too
Blake Niemyjski
@niemyjski
Oct 09 2015 19:52
yeah
that would be sick
!!
theit8514
@theit8514
Oct 09 2015 21:17
So I just set up exceptionless's redis connection string as localhost:7777 and run redis on that port and that's it, right?
theit8514
@theit8514
Oct 09 2015 21:29
I'm just getting two warnings and no trace info in the log of Job.exe.
Blake Niemyjski
@niemyjski
Oct 09 2015 21:46
didn’t see that
gitter crapped out :(
yeah
you’ll want
localhost:7777,abortconnect=false
as the connection string
for event posts?
If you want I can meet up with you in the morning and take a look
or possibly later tonight after the gym
theit8514
@theit8514
Oct 09 2015 21:48
I got eventposts to work, but couldn't get daily mail to work. I figured I could trigger it whenever and get an email sent.
I'm headed out too. I'll work on it on Monday :)