These are chat archives for exceptionless/Discuss

14th
Oct 2015
Blake Niemyjski
@niemyjski
Oct 14 2015 09:12
morning
Frank Ebersoll
@frankebersoll
Oct 14 2015 09:31
morning
Blake Niemyjski
@niemyjski
Oct 14 2015 09:31
working from the car today
road trip with 2 friends to nashville tn
Frank Ebersoll
@frankebersoll
Oct 14 2015 09:32
nice! have fun
Blake Niemyjski
@niemyjski
Oct 14 2015 09:32
yeah
Frank Ebersoll
@frankebersoll
Oct 14 2015 09:32
it just started snowing over here.
Blake Niemyjski
@niemyjski
Oct 14 2015 09:32
8 years (fte) tomorrow work aniversarry and my 29th birthday on friday.
jealous
I want to go snowboarding so bad
Frank Ebersoll
@frankebersoll
Oct 14 2015 09:32
it just melts away. no snowboarding.
Blake Niemyjski
@niemyjski
Oct 14 2015 09:33
:(
Frank Ebersoll
@frankebersoll
Oct 14 2015 09:33
8 years for codesmith?
Blake Niemyjski
@niemyjski
Oct 14 2015 09:33
Yeah
Frank Ebersoll
@frankebersoll
Oct 14 2015 09:33
oh, that's quite some time!
Blake Niemyjski
@niemyjski
Oct 14 2015 09:34
yeah can’t believe i put up with @ejsmith that long
:D
Frank Ebersoll
@frankebersoll
Oct 14 2015 09:34
hah
I'm a bit lost, can you tell me what needs to be done to finalize my pull request?
There was some discussion on the naming of isAppExiting that hasn't been agreed on yet.
But aside from that?
Blake Niemyjski
@niemyjski
Oct 14 2015 09:36
it’s fine for now let me look at the commit
as long as it’s there we can always rename it later if we find a better name.. but that name works for me :)
let me look it over..
Frank Ebersoll
@frankebersoll
Oct 14 2015 09:37
i'm still not happy with my commits. I'll rather do many atomic commits with better names in the future, so the diffs are easier to review
This is my first remote-only project and i can see how it enforces good communication and documentation ;-)
Blake Niemyjski
@niemyjski
Oct 14 2015 09:39
it happens, I’m never happy with my code but it’s what makes you better. Yeah, having commit messages document what you did is great. I’ve learned that (but it took time for me to do that)
unlike @ejsmith last commit “Working better, but still broke” gotta dive into what’s still broke :S lol
I still could be better
Frank Ebersoll
@frankebersoll
Oct 14 2015 09:40
:-D I also looked into that and closed it real quick
Blake Niemyjski
@niemyjski
Oct 14 2015 09:40
lol
so
so here is a thought I just had and wanted your input
what if we never committed the dist folder on commits / pull requests until we actually did a relase (after a quick test)
release* kinda sucks because then the dist folder doesn’t get you latest of what’s in the repo but then at least you know it’s tested
would make reviewing thigns easier in the future too
at the expense of extra commits but I guess we’d just do it when we bump the verison numbers
Frank Ebersoll
@frankebersoll
Oct 14 2015 09:43
can't we do a build process for that?
Blake Niemyjski
@niemyjski
Oct 14 2015 09:43
possible
Frank Ebersoll
@frankebersoll
Oct 14 2015 09:43
I mean, releasing actually means building dist and publishing it.
Blake Niemyjski
@niemyjski
Oct 14 2015 09:44
we’d want to have it happen pre tag tho
not sure how to do that
Frank Ebersoll
@frankebersoll
Oct 14 2015 09:45
What is the dist folder used for?
  1. CDN
  2. If anyone wants to just grab the script from github
Anything else?
Blake Niemyjski
@niemyjski
Oct 14 2015 09:45
so we agreed that we would keep injecting the ISubmissionClient just incase someone wanted to change it
guess better to be open then to close everythign
Frank Ebersoll
@frankebersoll
Oct 14 2015 09:45
  1. Publishing the npm package
Blake Niemyjski
@niemyjski
Oct 14 2015 09:45
yeah and bower and npm packages use it
Frank Ebersoll
@frankebersoll
Oct 14 2015 09:46
@niemyjski We were indifferent about that, so I just left it as-is. Less work for refactoring, because I would have changed all usages of the ISubmissionClient
Blake Niemyjski
@niemyjski
Oct 14 2015 09:46
so people wouldn’t need to run our build process as part of their build
yeah
sounds good :)
quick question
import { Utils } from './Utils';
I had issues with that before typescript 1.5
is that something they fixed recently
?
Frank Ebersoll
@frankebersoll
Oct 14 2015 09:48
Obviously. Even more, 'Utils' doesn't work any more.
Blake Niemyjski
@niemyjski
Oct 14 2015 09:48
cool
Frank Ebersoll
@frankebersoll
Oct 14 2015 09:48
That's why I needed to fix those local references
Blake Niemyjski
@niemyjski
Oct 14 2015 09:48
I was cousous about that. I like it (way more consistent) just never looked into why it wasn’t working in ts1.4
or maybe it was and I’m just a nub
Frank Ebersoll
@frankebersoll
Oct 14 2015 09:49
I also like it how it is now.
Thought about changing everything from require to import.
Maybe I will put together a list of small refactorings and add them to an issue.
Finally got to reproduce the bug in tsproject, I opened an issue over there, too: ToddThomson/tsproject#45
Blake Niemyjski
@niemyjski
Oct 14 2015 09:52
todd’s really helpful
I had so many issues and he was really great about helping
so our tests are just mocking submission now?
Blake Niemyjski
@niemyjski
Oct 14 2015 09:58
I know i had it hitting a local server or returning invalid which didn’t test good when the server wasn’t running
Frank Ebersoll
@frankebersoll
Oct 14 2015 09:58
yes, and we test the content now.
Blake Niemyjski
@niemyjski
Oct 14 2015 09:59
wish we could fire up a server easily
wonder if we could point it at dev
Frank Ebersoll
@frankebersoll
Oct 14 2015 09:59
hitting a local server would be an integration test - but I would rather set that up with a mocked server in Node.js, too.
Blake Niemyjski
@niemyjski
Oct 14 2015 09:59
but better that we don't
yeah
someday I’d like to have integration tests
and auto deploy
Frank Ebersoll
@frankebersoll
Oct 14 2015 10:00
:-)
Blake Niemyjski
@niemyjski
Oct 14 2015 10:00
really like how you refactored this man
I like that we share this code
Frank Ebersoll
@frankebersoll
Oct 14 2015 10:01
It wasn't a big thing, and it all came out of having to spawn that child process.
Seemed most logical like that.
Blake Niemyjski
@niemyjski
Oct 14 2015 10:02
the only thing I see so far and we can do it later it’s 100% fine right now is using an interfaces for the callback definition
like in getSettings
var cb:interface = (interface) =>
Frank Ebersoll
@frankebersoll
Oct 14 2015 10:03
like SubmissionCallback.ts?
Blake Niemyjski
@niemyjski
Oct 14 2015 10:03
yeah
do you think it would be cleaner
I guess if we are only doing it in one or two spots it doesn’t make sense
Frank Ebersoll
@frankebersoll
Oct 14 2015 10:04
i would do it if it turns out it's used often and has many arguments.
I'm okay with (a:int, b:int)=>int
Blake Niemyjski
@niemyjski
Oct 14 2015 10:05
yeah
okay I think the only thing missing from the commit unless I missed it
is probably should update the express or node sample to throw the exception on startup
or do you think we should leave that out cause it would crash the app
hmm
yeah that would crash the app and then it wouldn’t work
so guess we don’t need it
commit looks great man!
I say commit it and we’ll do a round of testing and I’ll get my but in grear and fix a bug that I’m seeing and we’ll push it!!
Frank Ebersoll
@frankebersoll
Oct 14 2015 10:08
okay! with "commit it", do you mean merge it? from then, I will work in a feature branch?
Blake Niemyjski
@niemyjski
Oct 14 2015 10:08
merge it :)
Frank Ebersoll
@frankebersoll
Oct 14 2015 10:09
alright. thanks for your review!
Blake Niemyjski
@niemyjski
Oct 14 2015 10:09
what did you think of the code. feels so great having someone else doing major feature work on the code base
Frank Ebersoll
@frankebersoll
Oct 14 2015 10:09
I'll do some final testing myself and then merge it later the day.
Blake Niemyjski
@niemyjski
Oct 14 2015 10:09
if you ever see anything stupid, let me know.. I’ll never get offended just upset at myself for doing something stupid
sounds good :)
Frank Ebersoll
@frankebersoll
Oct 14 2015 10:10
I haven't seen something stupid yet - have to say that I'm no JavaScript expert either.
Blake Niemyjski
@niemyjski
Oct 14 2015 10:10
after it’s merged I’ll also do a round and then we’ll update it and I’ll update npm
Frank Ebersoll
@frankebersoll
Oct 14 2015 10:10
great
Blake Niemyjski
@niemyjski
Oct 14 2015 10:11
once I get this signalr stuff done
I’ll update the server to check ref ids
Frank Ebersoll
@frankebersoll
Oct 14 2015 10:12
then, I will update the client to submit as often as needed, using ref ids
Blake Niemyjski
@niemyjski
Oct 14 2015 10:13
I’m wondering if that should still be opt in on the client
but it probably would be good to have
is there a good way to broadcast a message in javascript
would be kind of cool to say hey an error occurred with a reference id so users could update their page with a banner or something
but i guess they could do a plugin for that
KISS
@frankebersoll feeling any better today
Frank Ebersoll
@frankebersoll
Oct 14 2015 10:26
broadcast from where to where? you mean, a local message bus?
Blake Niemyjski
@niemyjski
Oct 14 2015 10:28
yeah in the browser or node app
but would be pretty easy to do something specific in a plugin if the user wanted
Sander Rijken
@srijken
Oct 14 2015 11:19
I like that idea a lot :)
Magnus Lindhe
@mgnslndh
Oct 14 2015 11:34
Hi! Is there a way to see what's new in one of Exceptionless' nuget packages? Release notes or changes or something like that.
Blake Niemyjski
@niemyjski
Oct 14 2015 11:47
@mgnslndh currently the only way is to look at our releases section on the repo or individual commit messages
we try to include detailed release notes
Magnus Lindhe
@mgnslndh
Oct 14 2015 12:26
Nice, I see now that GitHub has a link for each release showing the commits made after the release. That's what I'm looking for. Thanks!
Will each commit result in a new NuGet package or are they released manually?
Blake Niemyjski
@niemyjski
Oct 14 2015 12:44
it will deploy a new release to our myget feed
but we manually push from there to nuget
Blake Niemyjski
@niemyjski
Oct 14 2015 12:57
@mgnslndh do you need this pushed asap?
Magnus Lindhe
@mgnslndh
Oct 14 2015 13:34
I have made a local build of the assemblies and I can use them until you need to release next version.
Blake Niemyjski
@niemyjski
Oct 14 2015 13:55
ok
I’ll review it and see if anything else needs to go into it and push it
Thanks again!
everything else working out pretty good?
Magnus Lindhe
@mgnslndh
Oct 14 2015 14:38
yes, Exceptionless is looking good so far. Nothing in production. About to ship first alpha so I wanted to incorporate crash reporting. Nice work on the .NET libs.
This is among my first contributions to other projects so I slowly get the hang of it. Hope to be of more use in the future!
Blake Niemyjski
@niemyjski
Oct 14 2015 14:41
:)
Eric J. Smith
@ejsmith
Oct 14 2015 15:26
@niemyjski dang. Can’t believe I’ve been getting trolled for 8 years. :-)
@mgnslndh awesome!!