These are chat archives for exceptionless/Discuss

22nd
Jan 2016
Frank Ebersoll
@frankebersoll
Jan 22 2016 12:31
i added a failing test to the .NET project
Eric J. Smith
@ejsmith
Jan 22 2016 13:39
Awesomel
thanks
Blake Niemyjski
@niemyjski
Jan 22 2016 14:01
I'll take a look at it this morning
Frank Ebersoll
@frankebersoll
Jan 22 2016 14:12
after steping through loads of serialization code, we found it...
int maxDepth = 5 :-(
the default submission client has no way to configure that, so our only option would be creating an own implementation
Eric J. Smith
@ejsmith
Jan 22 2016 14:15
Ahhh we have that because some people had infinitely recursive errors.
Blake Niemyjski
@niemyjski
Jan 22 2016 14:20
But that only applied to extended data I thought
On a side note are we 100% happy with the Ui and server? It would be nice to deploy that today?
Eric did we want to spend anytime talking over a solution on session start merging?
Or can that wait
Eric J. Smith
@ejsmith
Jan 22 2016 14:25
We can review soon.
Blake Niemyjski
@niemyjski
Jan 22 2016 14:34
ok
would like to get that merged in
Frank Ebersoll
@frankebersoll
Jan 22 2016 14:48
@niemyjski maxDepth seems to affect any serialized data
Eric J. Smith
@ejsmith
Jan 22 2016 14:53
Maybe a more reasonable default with a config setting?
Blake Niemyjski
@niemyjski
Jan 22 2016 14:55
@frankebersoll where did you see this being applied as
yeah a config setting woud be better
Frank Ebersoll
@frankebersoll
Jan 22 2016 14:57
first line of SubmitEvents does the serialization
it calls .Serialize, which has a default of maxDepth = 5 in the interface
this gets respected every time it wants to serialize a property (ShouldBeSerialized or so)
Blake Niemyjski
@niemyjski
Jan 22 2016 14:59
public SubmissionResponse PostEvents(IEnumerable<Event> events, ExceptionlessConfiguration config, IJsonSerializer serializer) {
var data = serializer.Serialize(events);
might not be that easy to create a config setting
lots of places have that serialize call and no access to the config
Blake Niemyjski
@niemyjski
Jan 22 2016 15:11
how do we feel about bumping it up to 10?
from 5
or adding a config setting an injecting configuration everywhere
Frank Ebersoll
@frankebersoll
Jan 22 2016 15:12
i would vote for a config setting
to be fair, 10 would be enough most of the times. i'm indifferent.
Blake Niemyjski
@niemyjski
Jan 22 2016 15:13
I’m all for configuration, the problem I have with people setting it is they might look at that and set it to a really high number
and then you start sending very large amounts of data over the wire + more processing time all around
ef will create some really nasty recursive extended data / properties on exceptions with the full entity graph
but at the end of the day if your stupid enough to set it to int.maxvalue then you deserve to live with your choices
so is this something we want to default to 10 and make a config setting for?
Frank Ebersoll
@frankebersoll
Jan 22 2016 15:15
when it's <= 0, we set it to int.MaxValue somewhere
Blake Niemyjski
@niemyjski
Jan 22 2016 15:16
I’d say if it’s less than 0 we set it back to our default
greater than 0 is yours
idk
I don’t know what we’ve been doing in that case maybe we have been doing what you just said would have to look at our config
    public int SubmissionBatchSize {
        get { return _submissionBatchSize; }
        set {
            if (value > 0)
                _submissionBatchSize = value;
        }
    }
looks like we only set it if its positive
Is this something we need?
Eric J. Smith
@ejsmith
Jan 22 2016 15:32
I agree. We can’t leave it unlimited.
In fact, we need to enforce some upper limit even if we do make it configurable.
Blake Niemyjski
@niemyjski
Jan 22 2016 15:32
yeah
what do we want to do right now
up it to 10?
Eric J. Smith
@ejsmith
Jan 22 2016 15:32
We have seen single errors that are like 1mb all by themselves.
Blake Niemyjski
@niemyjski
Jan 22 2016 15:32
or make a confing setting and do quite a bit of work
Eric J. Smith
@ejsmith
Jan 22 2016 15:33
yeah, we can bump it to 10
I say we just change it to 10.
5 does seem pretty limiting.
I guess this is one of those things that can bite you and you won’t know about it.
like @frankebersoll just got bit.
Blake Niemyjski
@niemyjski
Jan 22 2016 15:33
I’m going to update us to the latest version of json.net as well
Eric J. Smith
@ejsmith
Jan 22 2016 15:33
not sure what a better solution would be.
we can’t leave it unlimited.
Blake Niemyjski
@niemyjski
Jan 22 2016 15:34
on extended data I’m going to leave it to 5
as you can control that
but for everything else it’s getting bumped
Eric J. Smith
@ejsmith
Jan 22 2016 15:35
ok
wish we could leave some sort of marker on the object
indicating that it got truncated.
so we could show something in the UI saying that.
otherwise you are just wondering a big WTF.
Frank Ebersoll
@frankebersoll
Jan 22 2016 15:37
that sounds really useful
Blake Niemyjski
@niemyjski
Jan 22 2016 15:42
pushed
lets see how the build server handles it
and then we need to do a round of serious testing. Can you help with this frank?
bit nervous as we updated json.net from 6.0.8 to 8.0.2… granted we have serializer unit tests but need to run through a round
Blake Niemyjski
@niemyjski
Jan 22 2016 15:53
awesome
well gotta revert that commit
because JSON.NET requires the new compiler and same old issue on Windows 7
Frank Ebersoll
@frankebersoll
Jan 22 2016 15:54
f.
Blake Niemyjski
@niemyjski
Jan 22 2016 15:55
:|
sometimes, I seriously want to fly to redmond and kick the guy in charge square in the nuts..
not sure how you let an issue that big just sit there for 6+ months, while customers are running into it
and it’s a huge compatibility issue
now they want to punt to vs next and that github issue exploded yesterday and everyone is like we need this now..
the guy from elastic search contacted me yesterday and was like I see you ran into that too...
so dam near everyone is hitting it
Frank Ebersoll
@frankebersoll
Jan 22 2016 15:59
and then, suddenly, it disappeared on my machine
yesterday you asked me for the actual stack trace, and i was like, give me a second, and i open the studio and hit Play and it just works
not any exception to be seen.
Blake Niemyjski
@niemyjski
Jan 22 2016 16:00
:(
Frank Ebersoll
@frankebersoll
Jan 22 2016 16:01
and i freak out and my colleague asks "did you restart it?" and i said "yes, but, wait..." and, as it happens, i installed 4.6 with some freeware tool 4 weeks ago and didn't restart in the meantime
and yesterday i restarted and 4.6 magically fixes it under the hood.
Blake Niemyjski
@niemyjski
Jan 22 2016 16:02
:(
yep
unacceptable
I was an honary vsip member for how much I helped out on VS
I got so pissed at them and let them know how frustrated I was.
every time a new major of vs was released.. and you had an issue with say VS2013. they would say can you reproduce on VS2015.. and I’m like guys it doesn’t matter I still gotta support this.
and like they won’t help until you check it and the docs never got any better or the api
or one update would break it and you’d have to wait months for a second update to revert something in the first update, mean while you look like an idiot to all of your customers
Kinda feeling all of that now, with this msbuild issue
“oh it can ship with the next version of Visual Studio” which there are no ctp bits for or even talk of
btw, end of rant @frankebersoll can you test the build off of myget quick and then I’ll push out a new release and nuget build
Frank Ebersoll
@frankebersoll
Jan 22 2016 16:13
i try
myget url?
Blake Niemyjski
@niemyjski
Jan 22 2016 16:14
I have that unit test that we created for the json serializer
and I just changed the property depth increase I think it should be fine
don’t you think
that’s been the only change
Frank Ebersoll
@frankebersoll
Jan 22 2016 16:14
that should work fine
if the unit test was red and now is green, that's about it
Blake Niemyjski
@niemyjski
Jan 22 2016 16:15
I simplified the test a bit as well
I’m going to push it
Frank Ebersoll
@frankebersoll
Jan 22 2016 16:26
looks great
can't check the 4.5 issue on my machine any more, but will check that on monday in our integration system (4.5.1)
the inner exception looks great now.
one question about line numbers: in the stack frames, we have something like " at offset 15"
Blake Niemyjski
@niemyjski
Jan 22 2016 16:28
yeah
that’s the il offset
Frank Ebersoll
@frankebersoll
Jan 22 2016 16:29
that's the column. i think the line is more important, actually i could do very well without the column
ah!
okay. i already wondered. okay"!
Blake Niemyjski
@niemyjski
Jan 22 2016 16:29
hehe
Blake Niemyjski
@niemyjski
Jan 22 2016 20:35
had sushi for lunch
was soo good
Eric J. Smith
@ejsmith
Jan 22 2016 20:43
from where?
Blake Niemyjski
@niemyjski
Jan 22 2016 20:44
green bay
kokos
Eric J. Smith
@ejsmith
Jan 22 2016 20:44
what are you doing in GB?
Blake Niemyjski
@niemyjski
Jan 22 2016 20:44
not as good as crolls but I haven’t had any sushi in a few months
it hit the spot
Eric J. Smith
@ejsmith
Jan 22 2016 20:44
We found a new sushi place that is really good.
Blake Niemyjski
@niemyjski
Jan 22 2016 20:44
I had a bee keeping meeting wensday night so I came up and moved some more stuff.
yeah, I’ll have to come check it out
Eric J. Smith
@ejsmith
Jan 22 2016 20:45
bee keeping meeting??
Blake Niemyjski
@niemyjski
Jan 22 2016 20:45
9 days till the big move
yeah
kinda excited :) my little girls (10k) are going to be here on april 19th
Eric J. Smith
@ejsmith
Jan 22 2016 20:49
your little girls eh
?
so aren’t they all males?
Blake Niemyjski
@niemyjski
Jan 22 2016 20:52
nope
only drones are males
and out of 60k in the hive only a few hundred (100-200) are males
Eric J. Smith
@ejsmith
Jan 22 2016 20:52
isn’t that all of them?
Blake Niemyjski
@niemyjski
Jan 22 2016 20:53
99.9% of them are female lol
Eric J. Smith
@ejsmith
Jan 22 2016 20:53
bet you can’t wait to get your hands on those little bitches and have your way with them, eh?
Blake Niemyjski
@niemyjski
Jan 22 2016 20:53
haha
“get to work making my honey"
pretty excited tho, such a facinating little creature.. They definitely have a mind of there own and have really good teamwork
Eric J. Smith
@ejsmith
Jan 22 2016 20:55
bitch betta have my honey!
Blake Niemyjski
@niemyjski
Jan 22 2016 20:56
hehe
there are like 90 people in that club
just in green bay alone
met a few people who were really nice and said they would be a mentor
Eric J. Smith
@ejsmith
Jan 22 2016 21:02
killing me
Blake Niemyjski
@niemyjski
Jan 22 2016 21:02
what?
Eric J. Smith
@ejsmith
Jan 22 2016 21:02
unbeelievable
I can’t beelieve that you want to use your time doing that.
Blake Niemyjski
@niemyjski
Jan 22 2016 21:04
yeah will be fun
20 hours a year isn’t that much time
Eric J. Smith
@ejsmith
Jan 22 2016 21:04
yeah, I bet it will bee fun.
Blake Niemyjski
@niemyjski
Jan 22 2016 21:04
When I actually do get honey, I’m going to give some too you and family.
Then I’m going to make some honey mead and get TORE up
:D
Eric J. Smith
@ejsmith
Jan 22 2016 21:05
That will bee great. I want to try some fresh honey.
Blake Niemyjski
@niemyjski
Jan 22 2016 21:08
wonder what kind of butter that place has
honey butter would be good
Eric J. Smith
@ejsmith
Jan 22 2016 21:09
I want to bee there the next time they have honey butter. That shit is good.
Blake Niemyjski
@niemyjski
Jan 22 2016 21:09
I love putting honey over my ribs as it traps in the bbq/rub when grilling them
bet fresh honey would be good
Eric J. Smith
@ejsmith
Jan 22 2016 21:09
You’ve never had any?
Blake Niemyjski
@niemyjski
Jan 22 2016 21:10
honey butter (yes I have)
Eric J. Smith
@ejsmith
Jan 22 2016 21:10
I bet it would bee really good if you drink it right out of the faucet.
Blake Niemyjski
@niemyjski
Jan 22 2016 21:10
that’s what I bought
stick my mouth right under there or toast and be golden
Frank Ebersoll
@frankebersoll
Jan 22 2016 21:12
😐
Blake Niemyjski
@niemyjski
Jan 22 2016 21:14
what :dancer:
Eric J. Smith
@ejsmith
Jan 22 2016 21:16
we shouldn’t bee talking about bees in the Exceptionless channel and boring everyone. :-)
Frank Ebersoll
@frankebersoll
Jan 22 2016 21:16
seems like a honey machine right out of kickstarter
i bet it is.
Blake Niemyjski
@niemyjski
Jan 22 2016 21:18
yeah
it takes some of the work out of processing but you still need to do the maintance and real work :)
Adam Zolotarev
@adamzolotarev
Jan 22 2016 21:33
Is there a way to set custom grouping on an exception and at the same time preserve the exception information?
I can do ExceptionlessClient.Default.CreateEvent().SetType(Event.KnownTypes.Error).SetSource("customSource");
And "customSource" will become my grouping, but I'm losing Exception tab. If I instead do exception.ToExceptionless().SetSource("customSource"); it still uses default grouping.
Blake Niemyjski
@niemyjski
Jan 22 2016 21:44
what do you mean by custom grouping? stacking??
Eric J. Smith
@ejsmith
Jan 22 2016 21:45
yeah, I wouldn’t mind having some sort of property on the event that you can set that would override the default stacking behaviour and let you stack things in custom ways.
Frank Ebersoll
@frankebersoll
Jan 22 2016 21:47
+1
Blake Niemyjski
@niemyjski
Jan 22 2016 21:59
@adamzolotarev, do you want to create an issue for this so we can discuss it further and maybe get a pull request for this? :)
Going over the change log for the new server release...
DANG there were a ton of commits
need to add some images to it
feels good getting those out there
it’s been since october since our last release
now we can focus on adding features and some bug fixes like serialization
and deduping :)
looks like I’m going to be putting on my writing hat for the next week.
got a lot of new topics to write about since we pushed the new releases
Eric J. Smith
@ejsmith
Jan 22 2016 22:35
might want to check Facebook @niemyjski
Sander Rijken
@srijken
Jan 22 2016 22:38
hi
Eric J. Smith
@ejsmith
Jan 22 2016 22:42
hi
Blake Niemyjski
@niemyjski
Jan 22 2016 22:52
ok
wow what a troll
Sander Rijken
@srijken
Jan 22 2016 22:57
ugh.. it’s nearly impossible to find out what GetHashCode() implementation I’m missing
Sander Rijken
@srijken
Jan 22 2016 23:06
can’t we do this after serialization?
oh then you loose the fact the others can implement it on their own
when they add custom stuff to datadictionary
in RequestInfo there’s 2 Dictionary<string, string> properties. What do I do there? Insert a custom collection that derives from the dictionary and implements GetHashCode()?
Eric J. Smith
@ejsmith
Jan 22 2016 23:23
I would say just iterate over the dictionary in request info and build up a hash.
Sander Rijken
@srijken
Jan 22 2016 23:23
can do that
Eric J. Smith
@ejsmith
Jan 22 2016 23:23
What do you think?
Sander Rijken
@srijken
Jan 22 2016 23:24
I’ll do that
not too hard
Eric J. Smith
@ejsmith
Jan 22 2016 23:24
Ok
Sander Rijken
@srijken
Jan 22 2016 23:24
@niemyjski if you’d like to help with one thing, I’m stuck testing, and it’s a good time to be stuck because I’m going to bed :)
if you put a breakpoint here: https://github.com/exceptionless/Exceptionless.Net/blob/deduplication/Source/Tests/Plugins/PluginTests.cs#L219
and then inspect the error, first time it has 9 modules inside Event.Data[“@Error”].Modules
second time, Modules is empty
I think that’s why my test is still failing at the moment